The proposal to merge
lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat into
lp:account-financial-tools has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position
The proposal to merge
lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat into
lp:account-financial-tools has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check
Review: Approve functional - no code review
LGTM
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check-vat/+merge/186515
Your team OpenERP Community Reviewer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~open
@Pedro
The code style is OK for you now ?
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check-vat/+merge/186515
Your team OpenERP Community Reviewer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-com
Review: Approve code review and test
Hi, Alexis, thank you very much for the changes!
I have tested the module and it works correctly.
Please make a last change: rename translation template file to .pot, to get
automatically recognised by Launchpad Rosetta.
Regards.
--
https://code.launchpad
About revno 5 : I had recently a new idea for this module : add an on_change on
the fiscal position of res.partner : when you switch to a fiscal position that
have "must have VAT" and the partner doesn't have a VAT, you get a warning
pop-up.
I have checked everything again, including translatio
Review: Approve code review and test
Thanks, Alexis,
Your changes are working good, but please let changes of this size for another
MP instead of doing them in the middle of the MP, because first 'Approve'
doesn't count for the second change, confusing anyone that see the overview.
Regards.
--
Review: Approve
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check-vat/+merge/186515
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewe
Review: Resubmit
Hi Alexis, I tried to merge your branch in lp:account-financial-tools/7.0 but I
get:
bzr: ERROR: Branches have no common ancestor, and no merge base revision
was specified.
Can you check?
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-posit
My branch only contains my module, it's not a "full" branch. So a bzr replay
should work, but a merge doesn't work. If it's a problem, I will prepare a
"full" branch of account-financial-tools with my module inside, but i'm not
sure if I will be able to push it in the same branch (if I can't, it
10 matches
Mail list logo
