[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2014-01-06 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-12-24 Thread Alexis de Lattre
@Yannick All your remarks are now integrated. -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-12-20 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review, no tests Hello Alexis, Can you add translation pot files? l.1745 can you split your tiny comment ? With it I can't have twice your code aside on a single screen (not a so tiny one) in my vim =) And other lines that are a bit too long

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-12-04 Thread Raphaël Valyi - http : //www . akretion . com
Review: Approve LGTM, no tests -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-11-11 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review Thanks Alexis for taking up the changes! Finally: LGTM :-) Lorenzo, does your comment count as an 'Approved'? -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-11-06 Thread Lorenzo Battistini - Agile BG
We tested 'account_cutoff_prepaid' and 'account_cutoff_base' and they work well. Thanks Alexis! -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-11-06 Thread Guewen Baconnier @ Camptocamp
Hi Alexis, Thanks for your changes! I'm back from vacation since weeks now, so it's time to come back to this proposal! There is still a 'raise' alone at line 557. Otherwise, nothing struck me. -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

2013-11-06 Thread Alexis de Lattre
@Lorenzo You're welcome ! I am happy that you like my modules. @Guewen I replaced the raise by an assert -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: