[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-10-14 Thread Holger Brunn (Therp)
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1189480/+merge/168463 -- https://code.launchpad.net/~camptocamp/ocb-

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-10-14 Thread Holger Brunn (Therp)
Review: Approve code review I agree with your code but also agree with the need for a test. Setting this to work in progress meanwhile. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1189480/+merge/168463 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-ad

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-11-27 Thread Matthieu Dietrich @ camptocamp
Review: Needs Fixing Actually, I investigated this branc, since it caused performance issues in our instance using it. The multiple read() are a major impact, given it will be done for each child project. It seems that the computation is off a bit as well; projects with children will not add th

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-12-09 Thread Matthieu Dietrich @ camptocamp
Review: Disapprove Please reject this MP, since https://code.launchpad.net/~camptocamp/ocb-addons/7.0-bugfix-1189480-with-perf-mdh supersedes it. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1189480/+merge/168463 Your team OpenERP Community Backports Team is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-12-18 Thread Yannick Vaucher @ Camptocamp
Review: Disapprove superseeded -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1189480/+merge/168463 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-communit