[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-25 Thread noreply
The proposal to merge lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 -- ht

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-02-28 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report. Requested reviews: Account Core Editors (account-core-editors) Related bugs: Bug #1284049 in Account - Invoicing Reports: "serial numbers on invoice

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-10 Thread Nicola Malcontenti - Agile BG
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Hi Alexandre, Sorry For the late, i have write the automated test for checking the bug. Regards. -N. -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 You

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-11 Thread Lorenzo Battistini - Agile BG
Review: Needs Fixing Nico, line 74,76: I think you should use 'lot_icecream_0' and 'lot_icecream_1' line 91: you are writing 'prodlot_id' field with another lot, but I think it's unnecessary, as lots are already assigned by 'stock.move.split' wizard. line 115: the test is checking if the invoi

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-14 Thread Lorenzo Battistini - Agile BG
Review: Approve code review just remove "name = ''" at line 110 Thanks! -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: htt

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-16 Thread Nicola Malcontenti - Agile BG
Tests should be ready -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-02-28 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM. Is there any chance I could convince you to write an automated test for this? -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-02-28 Thread Nicola Malcontenti - Agile BG
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Sorry i forgot it, i'll made soon -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branc