Alex Comba - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
Commit message:
[FIX] bug #1312024
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-b
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into
lp:purchase-wkfl has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
--
https://code.launchpad.net/~agileb
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into
lp:purchase-wkfl has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
--
https://code.launchpad.net/~agilebg/purc
Review: Needs Information
Thanks Alex,
why did you remove the 'images' and 'sequence' items?
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~agilebg/purchase-wkfl/7.0-bug-13
Lorenzo,
following are listed the reasons:
'images': this key doesn't compare in
https://doc.openerp.com/trunk/server/03_module_dev_01/#manifest-file-openerp-py:
also comparing https://www.openerp.com/apps/7.0/product_by_supplier/ and
https://www.openerp.com/apps/7.0/product_supplier_info/ I n
Review: Needs Fixing code review
Hi, Alex, some remarks:
- Contributors are put on 'contributors' key in manifest file as a list, not in
description.
- I prefer to add purchase as dependency that changes the place where the menu
is displayed, because this query is not useful if you don't use pu
Hi Pedro,
thank you for your review, my comments are in line.
> Contributors are put on 'contributors' key in manifest file as a list, not in
> description.
As far as I can see here
https://doc.openerp.com/contribute/05_developing_modules/#modules-description
it's written differently.
> I pre
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-
Review: Approve code review
Hi, Alex,
Thanks for the changes. Indeed, in contributors section of the documentation,
there's still a reference to add it at the end of the description. Initial
intention was to get a dedicated section under the key 'contributors' of the
manifest file to be displa
Review: Approve code review
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-rev
10 matches
Mail list logo
