Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-24 Thread Alexandre Fayolle - camptocamp
following the comment by Alexis on 23/04/2014 I'm setting this MP as work in progress -- https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-24 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-24 Thread Romain Deheele - Camptocamp
Review: Needs Fixing code review, test on_change_invoice_id function uses company_id in parameters, you need to add the field company_id in the crm.claim view crm_case_claims_form_view. Regards, Romain --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-23 Thread Alexis de Lattre
Just adding a small comment to say that Raphaël Valyi discovered a bug when doing a -u crm_claim_rma with that branch (it breaks on the duplicate constraint). We started digging to find a solution, but we didn't had time to implement it yet. --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-23 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no tests Hi, Thanks for improving the module. I may not have the time to read all carefully, just what I saw in a few minutes here: * L269 : For the method _get_default_warehouse, I prefer to get the WH through the user because take one from