Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread Matthieu Dietrich @ camptocamp
I fixed the store fields (not only department_id; other related() as well) to be refreshed if the distant field is modified. Regards, Matthieu -- https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 Your team OpenERP Community Reviewer/Maintainer is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test Well done Thanks LGTM -- https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test 42 + 'account.hours.block': (lambda self, cr, uid, ids, c=None: 43 + ids, ['invoice_id'], 10), this is a very bad line split, please keep the 'ids' on the same line as the lambda missing i18n update --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread Matthieu Dietrich @ camptocamp
@afayolle: thanks, I re-formatted it now. -- https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-04-02 Thread noreply
The proposal to merge lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-03-17 Thread Matthieu Dietrich @ camptocamp
To expand a bit: this MP is to add 2 things related to hours block: - a new field for the department, which is filterable/searchable, - a new button in the project form view, in order to get the hours block related to a project. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing If department is changed in invoice the related field won't be updated. Please set the proper store triggers. Cheers, -- https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212 Your team OpenERP Community Reviewer/Maintainer is subscribed

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-02-06 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management. Requested reviews: Contract Management Core Editors (contract-management-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-02-06 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management. Requested reviews: Contract Management Core Editors (contract-management-core-editors) For more details, see: