The proposal to merge
lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
--
https://code.lau
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into
lp:hr-timesheet/7.0.
Requested reviews:
Nicolas Bessi - Camptocamp (nbessi-c2c): credentials
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)
Alexandre Fayolle - c
@stefan Thanks for the review. I added the disclaimer and reStructured
__openerp__.py
Please merge it
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
@Maxime can you update your review Status ? Thanks
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list: https://launchpad.net/~openerp-communi
@Alexandre was your question answered with my comment
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124/comments/396592?
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community R
Patch was accepted in OCB addons.
Ready for review !
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet/7.0.
--
Mailing list: https://launchpad.net/~openerp-
Review: Approve code review
Thanks! What happens when you run this branch on standard OpenERP branches?
Maybe add a disclaimer about this in the module description.
Otherwise approved. I noticed that some column names changed in hr_holiday_rel
but this should be alright as it concerns a transie
Review: Approve code review, no tests
LGTM, Thanks !
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet/7.0.
--
Mailing list: https://launchpad.net/~openerp-
9 matches
Mail list logo
