[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-03 Thread Luc De Meyer (Noviat)
Luc De Meyer (Noviat) has proposed merging lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report. Requested reviews: Account Report Core Editors (account-report-core-editor) For more details, see: https://code.launchpad

[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~luc-demeyer/account-financial-r

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-04-10 Thread Nicolas Bessi - Camptocamp
hello, Any news on this one -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-04-14 Thread Luc De Meyer (Noviat)
I am just back from a week of holiday. I have reserved a bit of time in my agenda to make the MP by the end of this week. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Nicolas

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-04-17 Thread Luc De Meyer (Noviat)
MP: cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Be

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-05-07 Thread Nicolas Bessi - Camptocamp
Thanks I will have a look on https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 ASAP -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Guewen Baconnier @ Camptocamp
Review: Needs Fixing Hi, Thanks for the proposal. While I understand the logic you want to change I don't understand what problem you want to fix (I could maybe guess but I'm not sure). The code you propose was the same and we had to replace it by the more convoluted version that you want to r

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Luc De Meyer (Noviat)
The problem is that you have many OpenERP systems out there which have been used for years for other purposes than accounting. During those years, accounting entries have been generated but these entries were only used for e.g. one department or only sale/purchase of goods, ... Real reconciliati

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Guewen Baconnier @ Camptocamp
> The problem is that you have many OpenERP systems out there which have been > used for years for other purposes than accounting. > During those years, accounting entries have been generated but these entries > were only used for e.g. one department or only sale/purchase of goods, ... > Real recon

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Nhomar - Vauxoo
2013/11/4 Luc De Meyer (Noviat) > The problem is that you have many OpenERP systems out there which have > been used for years for other purposes than accounting. > During those years, accounting entries have been generated but these > entries were only used for e.g. one department or only sale/p

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Luc De Meyer (Noviat)
> Understand. Though, that's not working if you have a year without accounting > entries at all and 1 (empty) opening period. We have seen this situation before and we just removed the opening period. This is of course a workaround that doesn't tackle the real issue. > Considering all the case

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Pedro Manuel Baeza
To have it as reference, there is another old MP that treats the same topic (and I think with the same solution): https://code.launchpad.net/~account-report-core-editor/account-financial-report/fix-opening-period-search/+merge/162772 Regards. -- https://code.launchpad.net/~luc-demeyer/account-f

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2013-11-04 Thread Luc De Meyer (Noviat)
>We face this problem too, but we used to fix the not reconciled entries >(Importing historical paymens too globally and in some cases just to close >correctly all periods when we will start to use the accounting approach), it >means, if we >report some periods in one way and other periods in ot

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-01-31 Thread Pedro Manuel Baeza
Review: Approve code review Good improvement! -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: http

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-14 Thread Yannick Vaucher @ Camptocamp
Review: Needs Information @Luc anything was done about this proposed change ? > I have the impression that we move to a consensus to fix this issue by adding > a parameter on the company settings with callback to current method if not > defined. -- https://code.launchpad.net/~luc-demeyer/accou

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-14 Thread Luc De Meyer (Noviat)
No, If you agree with the proposed approach, than I an make an MP. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Yannick Vaucher @ Camptocamp Sent: vrijdag 14 maart 2014 9:48

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
Hello, The parameter/fallback solution seems reasonable assuming that period parameter is not mandatory. For me you can update the MP with that solution. Also as the change will alter data structure the revision number of the module must be increased in MP. I'm putting the MP in work in prog

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

2014-03-18 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~opene