On Fri, Jun 26, 2009 at 03:04:23AM -0300, Daniel Ribeiro wrote:
> Em Sex, 2009-06-26 às 00:37 +0100, Mark Brown escreveu:
> > actively being used off is likely to cause issues. Regulator drivers
> > should just leave everything as they find it and leave it up to the core
> > and machine drivers t
Em Sex, 2009-06-26 às 11:55 +0100, Mark Brown escreveu:
> On Fri, Jun 26, 2009 at 03:04:23AM -0300, Daniel Ribeiro wrote:
> > So, the regulator is enabled at boot, but it can't be disabled because
> > use_count is 0. This is the same issue as twl4030-mmc, but instead of a
> > enable/disable pair on
On Fri, Jun 26, 2009 at 09:26:32AM -0300, Daniel Ribeiro wrote:
> Em Sex, 2009-06-26 às 11:55 +0100, Mark Brown escreveu:
> > You need to either do that or add an API allowing consumers to claim a
> > regulator for exclusive use. If the regulator is claimed for exclusive
> > use then other consum
On Thu, 25 Jun 2009 17:45:49 -0300
Daniel Ribeiro wrote:
> RTC driver for PCAP2 PMIC.
>
> This patch was sent some time ago and acked by Alessandro, but we had to
> change some stuff on the core driver and consequently on this driver
> too, so I'm submitting it again for review (sorry).
>
> Sig
Em Sex, 2009-06-26 às 16:08 +0100, Mark Brown escreveu:
> > If the above is not possible, then regulator_is_enabled() doesn't match
> > regulator_enable()/regulator_disable() pair. Maybe the API should make
> > this clear?
>
> Frankly I'm not sure how much any documentation is going to help here.
On Fri, 2009-06-26 at 13:23 -0700, Andrew Morton wrote:
> > diff -puN /dev/null drivers/rtc/rtc-pcap.c
> > --- /dev/null
> > +++ a/drivers/rtc/rtc-pcap.c
[]
> > +static irqreturn_t pcap_rtc_irq(int irq, void *_pcap_rtc)
> > +{
> > + struct pcap_rtc *pcap_rtc = _pcap_rtc;
> > + unsigned long rtc
The voltage regulator framework can't sanely deal with voltage
regulators which are left enabled by the bootloader. We workaround this
by forcing an enable()/disable() pair so it has a sane use_count.
Signed-off-by: Daniel Ribeiro
---
drivers/mmc/host/pxamci.c | 12
1 files chang
Changed: Removed workaround for regulator use_count issues.
=== CUT HERE ===
Add (partial) support for the voltage regulators on the PCAP2 PMIC.
Signed-off-by: Daniel Ribeiro
---
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pcap-re
Hi Andrew,
Em Sex, 2009-06-26 às 13:23 -0700, Andrew Morton escreveu:
> This could be coded more simply:
>
> unsigned long rtc_events;
>
> if (irq == pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_1HZ))
> rtc_events = RTC_IRQF | RTC_UF;
> else if (irq == pcap_to_irq(pcap_rt
On Fri, 26 Jun 2009 20:57:38 -0300 Daniel Ribeiro wrote:
> Hi Andrew,
>
> Em Sex, 2009-06-26 __s 13:23 -0700, Andrew Morton escreveu:
> > This could be coded more simply:
> >
> > unsigned long rtc_events;
> >
> > if (irq == pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_1HZ))
> > rtc
On Fri, Jun 26, 2009 at 07:26:55PM -0300, Daniel Ribeiro wrote:
> Em Sex, 2009-06-26 às 16:08 +0100, Mark Brown escreveu:
> > Fundamentally, if your consumer is trying to explicitly force the
> > regulator off then it's not able to cope with the regulator being
> > shared. I suspect that if someo
On Fri, Jun 26, 2009 at 08:07:48PM -0300, Daniel Ribeiro wrote:
> The voltage regulator framework can't sanely deal with voltage
> regulators which are left enabled by the bootloader. We workaround this
> by forcing an enable()/disable() pair so it has a sane use_count.
Please write a commit messa
On Fri, Jun 26, 2009 at 08:08:41PM -0300, Daniel Ribeiro wrote:
> Changed: Removed workaround for regulator use_count issues.
The usual place for these comments is after the --- with the diffstat
(the tools can then deal automatically with them). Incidentally, the
code you had would only help pxa
Em Sáb, 2009-06-27 às 02:04 +0100, Mark Brown escreveu:
> > + if (vreg->n_voltages == 1)
> > + return -EINVAL;
>
> It'd be a little more friendly to check if the supported voltage is in
> the requested range. However, that'd only be an issue if constraints
> allowed voltage changes wh
Em Sáb, 2009-06-27 às 01:48 +0100, Mark Brown escreveu:
> > + /*
> > +* When the bootloader leaves a supply active, it's
> > +* initialized with zero usecount ... and we can't
> > +* disable it without first enabling it. Until the
> > +* fr
Provides an atomic set_bits functions, as needed by the pcap-regulator
driver.
Signed-off-by: Daniel Ribeiro
---
drivers/mfd/ezx-pcap.c | 23 +++
include/linux/mfd/ezx-pcap.h |1 +
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/ezx-pc
Add (partial) support for the voltage regulators on the PCAP2 PMIC.
Signed-off-by: Daniel Ribeiro
---
Changes since V2: Fix a race condition.
Mark, can you please assert that this only gets merged after Samuel has
a chance to merge the set_bits patch? Thanks!
drivers/regulator/Kconfig
RTC driver for PCAP2 PMIC.
Signed-off-by: Daniel Ribeiro
Signed-off-by: guiming zhuo
Acked-by: Alessandro Zummo
---
drivers/rtc/Kconfig|7 ++
drivers/rtc/Makefile |1 +
drivers/rtc/rtc-pcap.c | 224
3 files changed, 232 insertion
18 matches
Mail list logo
