On Tue, May 5, 2009 at 6:30 AM, Daniel Ribeiro wrote:
> Eric, can you please take a look at this?
Sure, I seem to remember PGSRx will be preserved across
low power and run modes, but looks I'm wrong and I'll double
check with the spec.
On Tue, May 5, 2009 at 6:36 AM, Eric Miao wrote:
> On Tue, May 5, 2009 at 6:30 AM, Daniel Ribeiro wrote:
>> Eric, can you please take a look at this?
>
> Sure, I seem to remember PGSRx will be preserved across
> low power and run modes, but looks I'm wrong and I'll
On Wed, May 6, 2009 at 9:43 AM, Daniel Ribeiro wrote:
> I want to reuse tosa/spitz gpio_reset code, but my board needs the reset
> gpio to be driven high during normal operation.
>
This makes sense to me. Dmitry, your Ack is welcome.
On Wed, May 6, 2009 at 3:20 PM, Dmitry Eremin-Solenikov
wrote:
> Daniel Ribeiro wrote:
>
>> I want to reuse tosa/spitz gpio_reset code, but my board needs the reset
>> gpio to be driven high during normal operation.
>>
>> Signed-off-by: Daniel Ribeiro
>
> Acked-by: Dmitry Eremin-Solenikov
>
Tha
On Thu, May 7, 2009 at 2:05 PM, Daniel Ribeiro wrote:
>
> Signed-off-by: Daniel Ribeiro
>From the coding style point of view, we might better keep the number
of those "#ifdef CONFIG_REGULATOR .. #endif" to a minimum, e.g.
#ifdef CONFIG_REGULATOR
static void mmc_host_set_vcc(int vcc)
{
I'd rather it's implemented something like below (it's only for illustration
purpose):
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index 793ab2a..6fa7a05 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -73,42 +73,28 @@ struct pxamci_host {
};
#if
On Thu, May 14, 2009 at 5:31 PM, Daniel Ribeiro wrote:
> Em Qui, 2009-05-14 às 17:11 +0800, Eric Miao escreveu:
>> I'd rather it's implemented something like below (it's only for illustration
>> purpose):
>
> I dont think we can set ocr_avail on set_ios(). S
On Fri, May 15, 2009 at 11:34 AM, Eric Miao wrote:
> On Thu, May 14, 2009 at 5:31 PM, Daniel Ribeiro wrote:
>> Em Qui, 2009-05-14 às 17:11 +0800, Eric Miao escreveu:
>>> I'd rather it's implemented something like below (it's only for illustration
>>&g
On Fri, May 15, 2009 at 5:06 PM, Daniel Ribeiro wrote:
> Em Sex, 2009-05-15 às 11:34 +0800, Eric Miao escreveu:
>> Yes, so that's for illustration purpose only. My point is to abstract
>> the operation and hide the detail there, and make the driver logic
>> part generic.
On Fri, May 15, 2009 at 5:51 PM, Stefan Schmidt
wrote:
> Hello.
>
> On Fri, 2009-05-15 at 06:33, Daniel Ribeiro wrote:
>> Fix LPM configuration on ezx.c
>>
>> Signed-off-by: Daniel Ribeiro
>
> Eric, just in case you are wondering. EZX patches coming from Daniel are fine
> without any SOB or ACK f
On Fri, May 15, 2009 at 5:33 PM, Daniel Ribeiro wrote:
> Fix LPM configuration on ezx.c
>
> Signed-off-by: Daniel Ribeiro
Daniel,
Will it affect the EZX's normal suspend/resume without this patch?
I'm wondering if I'd queue this into the 'fix' branch.
On Sat, May 16, 2009 at 3:27 AM, Russell King - ARM Linux
wrote:
> On Thu, May 14, 2009 at 05:11:00PM +0800, Eric Miao wrote:
>> +static void pxamci_set_power(struct pxamci_host *host, unsigned int vdd)
>> {
> ...
>> + struct mmc_host *mmc = host->mmc;
>>
On Fri, May 15, 2009 at 6:17 PM, Daniel Ribeiro wrote:
> Em Sex, 2009-05-15 às 17:59 +0800, Eric Miao escreveu:
>> Daniel,
>>
>> Will it affect the EZX's normal suspend/resume without this patch?
>> I'm wondering if I'd queue this into the 'fix
2009/6/2 Daniel Ribeiro :
> Em Seg, 2009-06-01 às 12:26 +0200, Antonio Ospite escreveu:
>> Setup gpio-keys for EzX phones
>>
>> Signed-off-by: Antonio Ospite
>
> Acked-by: Daniel Ribeiro
>
OK. Applied to 'devel'.
Daniel Ribeiro wrote:
> Em Sáb, 2009-06-27 às 01:48 +0100, Mark Brown escreveu:
>>> + /*
>>> +* When the bootloader leaves a supply active, it's
>>> +* initialized with zero usecount ... and we can't
>>> +* disable it without first enabling it. Until t
Daniel Ribeiro wrote:
> Signed-off-by: Daniel Ribeiro
>
Applied to 'devel', thanks.
> ---
> arch/arm/mach-pxa/Kconfig |1 +
> arch/arm/mach-pxa/include/mach/irqs.h |2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/a
On Fri, Oct 23, 2009 at 6:36 AM, Antonio Ospite
wrote:
> Hi,
>
> I get this warning on shutdown. How to fix it properly?
>
This is weird, as if pxa2xx_set_spi_info() is used, the pxa2xx-spi device
is actually created by platform_device_alloc(), which has a default
release function of "platform_de
Hi Antonio,
Patch looks generally OK except for the MFP/GPIO usage, check my
comments below, thanks.
> +/* camera */
> +static int a780_pxacamera_init(struct device *dev)
> +{
> + int err;
> +
> + /*
> + * GPIO50_GPIO is CAM_EN: active low
> + * GPIO19_GPIO is CAM_RST: a
This patch looks good, will apply later.
On Wed, Nov 4, 2009 at 12:45 AM, Antonio Ospite
wrote:
> Signed-off-by: Antonio Ospite
> ---
> arch/arm/mach-pxa/ezx.c | 53
> +++
> 1 files changed, 53 insertions(+), 0 deletions(-)
>
> diff --git a/arch/ar
On Wed, Nov 4, 2009 at 4:40 AM, Antonio Ospite wrote:
> On Tue, 3 Nov 2009 18:44:30 +0100
> Stefan Schmidt wrote:
>
>> Hello.
>>
>> [Put Eric in CC]
>>
>
>
> Thanks, I've realized that the best practice to write the summary
> message is via 'git format-patch --cover-letter' to add the needed
> r
On Wed, Nov 4, 2009 at 5:14 PM, Antonio Ospite wrote:
> On Wed, 4 Nov 2009 14:38:40 +0800
> Eric Miao wrote:
>
>> Hi Antonio,
>>
>> Patch looks generally OK except for the MFP/GPIO usage, check my
>> comments below, thanks.
>>
>
> Ok, will resend
On Tue, Nov 10, 2009 at 8:48 PM, Antonio Ospite
wrote:
> On Wed, 4 Nov 2009 14:38:40 +0800
> Eric Miao wrote:
>
>> Hi Antonio,
>>
>> Patch looks generally OK except for the MFP/GPIO usage...
>
> Eric,
>
> while I was at it I also checked the orig
On Wed, Nov 11, 2009 at 7:01 PM, Antonio Ospite
wrote:
> Signed-off-by: Bart Visscher
> Signed-off-by: Antonio Ospite
>
> ---
> Changes since v2:
>
> - Bart's SOB goes first, as he is the original author.
> - Add MFP_LPM_DRIVE_HIGH to camera gpios, as per Motorola original
> code.
> - s/pxa
On Fri, Nov 13, 2009 at 4:49 AM, Guennadi Liakhovetski
wrote:
> On Thu, 12 Nov 2009, Antonio Ospite wrote:
>
>> Signed-off-by: Bart Visscher
>> Signed-off-by: Antonio Ospite
>
> Acked-by: Guennadi Liakhovetski
>
Applied, thanks.
On Wed, Nov 4, 2009 at 2:40 PM, Eric Miao wrote:
> This patch looks good, will apply later.
>
> On Wed, Nov 4, 2009 at 12:45 AM, Antonio Ospite
> wrote:
>> Signed-off-by: Antonio Ospite
Applied to 'devel', thanks.
25 matches
Mail list logo
