Re: [PATCH] E680: add support for Boomer LM4857 FM amplifier

2008-03-26 Thread Stefan Schmidt
Hello. On Mon, 2008-03-24 at 17:53, Andreas Mohr wrote: On Mon, Feb 18, 2008 at 02:30:55AM +0100, [EMAIL PROTECTED] wrote: From: Stefan Schmidt [EMAIL PROTECTED] Precedence: list Todo list in code again. Perhaps just a question of personal taste. _This_ one IMHO should very much

Re: [PATCH] E680: add support for Boomer LM4857 FM amplifier

2008-03-24 Thread Andreas Mohr
Hi, [let's hope my mails make it through SMTP correctly this time] On Mon, Feb 18, 2008 at 02:30:55AM +0100, [EMAIL PROTECTED] wrote: From: Stefan Schmidt [EMAIL PROTECTED] Precedence: list On Sun, 2008-02-17 at 19:19, Daniel Ribeiro wrote: +#ifdef CONFIG_I2C_BOARDINFO +static struct

Re: [PATCH] E680: add support for Boomer LM4857 FM amplifier

2008-02-17 Thread Stefan Schmidt
Hello. Some minor comments. Nothing that can't get cleanup after applying it. Normally we haven't done much code review on this list. Perhaps it is worth to establish this. At least I try to start it for myself. On Sun, 2008-02-17 at 19:19, Daniel Ribeiro wrote: +#ifdef CONFIG_I2C_BOARDINFO

Re: [PATCH] E680: add support for Boomer LM4857 FM amplifier

2008-02-17 Thread Daniel Ribeiro
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Mohr wrote: Feel free to give me any feedback you might come up with concerning my driver layout / placement, mixer control map, test results or future development. The code looks good, thanks! I have split the patch into 3 patches,