Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

2009-06-29 Thread Dmitry Torokhov
Hi Daniel, On Sat, Jun 27, 2009 at 02:02:18PM -0300, Daniel Ribeiro wrote: Touchscreen driver for PCAP2 PMIC. Signed-off-by: Daniel Ribeiro drw...@gmail.com --- drivers/input/touchscreen/Kconfig |9 ++ drivers/input/touchscreen/Makefile |1 +

Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

2009-06-28 Thread Trilok Soni
Hi Daniel, 2009/6/27 Daniel Ribeiro drw...@gmail.com: Touchscreen driver for PCAP2 PMIC. Some more description in commit text really helps. +static irqreturn_t pcap_ts_event_touch(int pirq, void *data) +{ +       struct pcap_ts *pcap_ts = data; + +       if (pcap_ts-read_state ==

Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

2009-06-28 Thread Antonio Ospite
Daniel, some trivial comments, I can do the changes if you want. On Sat, 27 Jun 2009 14:02:18 -0300 Daniel Ribeiro drw...@gmail.com wrote: Touchscreen driver for PCAP2 PMIC. Signed-off-by: Daniel Ribeiro drw...@gmail.com --- drivers/input/touchscreen/Kconfig |9 ++

Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

2009-06-28 Thread Daniel Ribeiro
Em Dom, 2009-06-28 às 16:35 +0200, Antonio Ospite escreveu: + pcap_ts-pcap = platform_get_drvdata(pdev); + platform_set_drvdata(pdev, pcap_ts); + + input_dev = input_allocate_device(); + if (!pcap_ts || !input_dev) Can pcap_ts be ever NULL here? This test can be simplified.