On Tue, 12 Apr 2011 13:44:02 +0200
Johannes Berg johan...@sipsolutions.net wrote:
On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:
+ * static struct regulator_consumer_supply pcap_regulator_V6_consumers
[] = {
+ * { .dev_name = rfkill-regulator.0, supply = vrfkill },
On Tue, 12 Apr 2011 13:41:28 +0200
Johannes Berg johan...@sipsolutions.net wrote:
+ dev_info(pdev-dev, initialized\n);
Is that message really useful?
I can print the pdata-name here as well as an excuse to keep it,
reality is that I just like visual feedback in dmesg when a driver has
On Tue, Apr 12, 2011 at 05:23:01PM +0200, Johannes Berg wrote:
On Tue, 2011-04-12 at 08:15 -0700, Mark Brown wrote:
No, if you're passing supply names through platform data something has
gone wrong - that's a big no no.
Ok. The comment seems a little wrong still though, maybe leftover bits
On Fri, 2011-04-08 at 12:59 +0200, Antonio Ospite wrote:
Add a regulator consumer driver for rfkill to enable controlling radio
transmitters connected to voltage regulators using the regulator
framework.
A new vrfkill virtual supply is provided to use in platform code.
Signed-off-by:
On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:
+ * static struct regulator_consumer_supply pcap_regulator_V6_consumers []
= {
+ * { .dev_name = rfkill-regulator.0, supply = vrfkill },
+ * };
It's a comment, but it should be .supply = (missing the .)
+ if
On Tue, Apr 12, 2011 at 01:44:02PM +0200, Johannes Berg wrote:
On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:
+ if (pdata-name == NULL || pdata-type == 0) {
+ dev_err(pdev-dev, invalid name or type in platform data\n);
+ return -EINVAL;
+ }
+ vcc =
On Tue, 2011-04-12 at 08:15 -0700, Mark Brown wrote:
On Tue, Apr 12, 2011 at 01:44:02PM +0200, Johannes Berg wrote:
On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:
+ if (pdata-name == NULL || pdata-type == 0) {
+ dev_err(pdev-dev, invalid name or type in
