Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-14 Thread Abhijit Kumbhare
gt; *To:* Robert Varga > *Cc:* Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) < > dmala...@cisco.com>; openflowplugin-dev opendaylight.org>; Release (rele...@lists.opendaylight.org) < > rele...@lists.opendaylight.org> > *Subject:* Re: [openflowplugin-dev]

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-14 Thread Colin Dixon
obert Varga > *Cc:* Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) < > dmala...@cisco.com>; openflowplugin-dev opendaylight.org>; Release (rele...@lists.opendaylight.org) < > rele...@lists.opendaylight.org> > *Subject:* Re: [openflowplugin-dev] [release] [WE

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-14 Thread Colin Dixon
gt; *Sent:* Thursday, November 10, 2016 7:53 PM > *To:* Robert Varga > *Cc:* openflowplugin-dev ; > Release (rele...@lists.opendaylight.org) ; > Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) < > dmala...@cisco.com> > *Subject:* Re: [openflowplugin-dev] [rel

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-14 Thread Jozef Bacigál
: Friday, November 11, 2016 4:03 AM To: Robert Varga Cc: Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) ; openflowplugin-dev ; Release (rele...@lists.opendaylight.org) Subject: Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin Folks, Perhaps this

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-14 Thread Jozef Bacigál
: openflowplugin-dev ; Release (rele...@lists.opendaylight.org) ; Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) Subject: Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin Something something. Reality vs. practice. Something something. More seriously

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-11 Thread Andrej Záň
Hi, no without additional codding. Currently you can create filter which in fact will not filter anything, but as output we support only i2rs topology model and it will not contain any information augmented by OFP Regards Andrej Záň Od: Robert Varga Odo

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Abhijit Kumbhare
Folks, Perhaps this discussion is going a bit more detailed than the issue itself. Jozef's change was to let the topology ID be a config option with the default of "openflow" instead of "flow" - which necessitated a weather report as applications would have needed to change from the hardcoded valu

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Robert Varga
On 11/10/2016 07:40 PM, Ryan Goulding wrote: > What they should be doing is probably far from what they actually are > doing. Is this expectation actually written anywhere? Otherwise, how > are consumers supposed to know? Lets not punish people for trying to > use our product. I agree on the 'n

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Colin Dixon
Something something. Reality vs. practice. Something something. More seriously, if we have a suggested best practice to avoid hard coding this in and then can search through all the projects and help them move away from it, I'm sure that would be appreciated by lots of people. --Colin On Thu, N

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Ryan Goulding
What they should be doing is probably far from what they actually are doing. Is this expectation actually written anywhere? Otherwise, how are consumers supposed to know? Lets not punish people for trying to use our product. Regards, Ryan Goulding On Thu, Nov 10, 2016 at 1:12 PM, Robert Varga

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Robert Varga
On 11/10/2016 06:44 PM, Colin Dixon wrote: > I think flow:1 is hard code a lot of places even inside OpenDaylight... That is a *really* bad idea. This is equivalent of assuming a particular implementation of an interface. Whoever is using this hard-coded value should be getting a reference to a t

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Abhijit Kumbhare
Yes that's the reason we decided to keep the existing flow:1 as the default. Jozef's change already supports a config knob to be able to change it to openflow:1 (or any other string). This decision makes the weather report as informational - projects can change the string if they want to but are no

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Colin Dixon
I think flow:1 is hard code a lot of places even inside OpenDaylight... --Colin On Thu, Nov 10, 2016 at 11:42 AM, Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco) wrote: > For DLUX we’ll update topology app a bit and put there a select box. > > It will be populated with all av

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Daniel Malachovsky -X (dmalacho - PANTHEON TECHNOLOGIES at Cisco)
For DLUX we’ll update topology app a bit and put there a select box. It will be populated with all available topologies and user can pick the one he is interested in. I just started this with a simple question if “flow:1” is hardcoded somewhere in openflow as a constant. Because in DLUX is ☺ da

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Abhijit Kumbhare
We have decided in the OpenFlow Plugin meeting to have a config knob to change the name from flow/1 to openflow/1 (for Dlux project) , but keep the default as flow/1 to require no changes on the dependent projects. On Thu, Nov 10, 2016 at 8:04 AM, Robert Varga wrote: > Can we instantiate a proxy

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Robert Varga
Can we instantiate a proxy via topoprocessing to keep compatibility? Bye, Robert On 11/10/2016 04:22 PM, Abhijit Kumbhare wrote: > Yes - I agree with Colin. > > On Thu, Nov 10, 2016 at 7:16 AM, Colin Dixon > wrote: > > I've commented on the relevant patch, but

Re: [openflowplugin-dev] [release] [WEATHER] - topology id in openflowplugin

2016-11-10 Thread Abhijit Kumbhare
Yes - I agree with Colin. On Thu, Nov 10, 2016 at 7:16 AM, Colin Dixon wrote: > I've commented on the relevant patch, but I'll also say it here. It's > really not clear to me that this will reduce confusion. My guess is that > changing the name we've used for 5 releases will cause at least as mu