On Wed, Feb 20, 2013 at 02:37:31PM +0100, Stanislav Kozina wrote:
Hi,
  
> Pretty often I search for the revision right before given change was 
> introduced, i.e. "how this code looked like before commit #1234".

Just click on "History" and choose whatever you want ;-)
  
> That's why I'd like to add one more column in annotate view, so it would 
> look like:
> Line # | Previous commit | Annotate commit | Commiter | Source code line
> 
> By clicking the "Previous commit" you would see how the code looked like 
> before.
> 
> What do you think?

-1 ,
too much clutter, and introduces AFAICS wrt. to the current head
(i.e inefficient Annotation and JS-less list.jsp impl.) too much
overhead wrt. size and probably processing, so the poor Sunray users
would start whineing even more ;-). 
With a JS-based/better impl. like
http://src.iws.cs.ovgu.de/source/xref/opengrok-jel/src/org/opensolaris/opengrok/history/Annotation.java
and
http://src.iws.cs.ovgu.de/source/xref/opengrok-jel/web/static/opengrok.js#226
it would be easy to implement and overhead would be negligible, however,
IMHO still to much clutter ;-)

Regards,
jel.
-- 
Otto-von-Guericke University     http://www.cs.uni-magdeburg.de/
Department of Computer Science   Geb. 29 R 027, Universitaetsplatz 2
39106 Magdeburg, Germany         Tel: +49 391 67 52768
_______________________________________________
opengrok-discuss mailing list
opengrok-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opengrok-discuss

Reply via email to