[openib-general] Re: [PATCH] [1/2] SQE handling on MAD QPs

2004-11-12 Thread Hal Rosenstock
On Thu, 2004-11-11 at 20:41, Sean Hefty wrote: This patch recovers from send queue errors on QP 0/1. (It should also work in the case of fatal errors, but does not try to recover.) Code was tested by forcing send errors and checking that the port could still go to active. Patch can

Re: [openib-general] [PATCH] Enable inet6 on ib interface

2004-11-12 Thread Nitin Hande
Roland Dreier wrote: Tom Would you really bring both interfaces up? If this is a Tom problem, the spec should have the pkey be part of the link Tom local address. It actually seems to work fine to bring up multiple IPv6 interfaces that end up with the same link local address

Re: [openib-general] New OpenIB webpages

2004-11-12 Thread Roland Dreier
Matt FAQ wiki does sound good. I'll look into it. In general having a wiki would be great (there have been a few times in the past where I would have liked to have been able to create a quick wiki page). - R. ___ openib-general mailing list

[openib-general] Re: [PATCH] [1/2] SQE handling on MAD QPs

2004-11-12 Thread Sean Hefty
Hal Rosenstock wrote: On Thu, 2004-11-11 at 20:41, Sean Hefty wrote: This patch recovers from send queue errors on QP 0/1. (It should also work in the case of fatal errors, but does not try to recover.) Code was tested by forcing send errors and checking that the port could still go to active.

[openib-general] Re: [PATCH] [1/2] SQE handling on MAD QPs

2004-11-12 Thread Hal Rosenstock
On Fri, 2004-11-12 at 12:13, Sean Hefty wrote: Not sure what the issue is. Let me make sure that I've pulled the latest code and resubmit the patch. It looks right to me. Does it work for you ? Can you send a normal rather than unified diff ? -- Hal

Re: [openib-general] [PATCH] agent: Fix agent_mad_send PCI mapping and gather address and length

2004-11-12 Thread Sean Hefty
Hal Rosenstock wrote: On Wed, 2004-11-10 at 11:59, Roland Dreier wrote: Sean What exactly does it mean then when process_mad returns Sean success? Do any of the return bits from process_mad Sean indicate that the MAD was for the HCA driver? SUCCESS means that process_mad didn't encounter

[openib-general] Re: [PATCH] [2/2] change QP state to SQE

2004-11-12 Thread Roland Dreier
I thought about this a little, and it seems that having the CQ poll operation update the QP state is not the right solution. It seems it would be better to add support for the Current QP state modifier for the modify QP operation and expect the consumer to use that to indicate that the QP is in

[openib-general] Re: [PATCH] [2/2] change QP state to SQE

2004-11-12 Thread Sean Hefty
Roland Dreier wrote: I thought about this a little, and it seems that having the CQ poll operation update the QP state is not the right solution. It seems it would be better to add support for the Current QP state modifier for the modify QP operation and expect the consumer to use that to

[openib-general] Re: [PATCH] [1/2] SQE handling on MAD QPs

2004-11-12 Thread Hal Rosenstock
On Fri, 2004-11-12 at 12:54, Sean Hefty wrote: On Fri, 12 Nov 2004 12:18:32 -0500 Can you try this version? I'll also revert back to the original code and see if I can apply the patch. Don't bother (if you haven't already). This patch worked. -- Hal

[openib-general] Re: [PATCH] [1/2] SQE handling on MAD QPs

2004-11-12 Thread Hal Rosenstock
On Fri, 2004-11-12 at 12:54, Sean Hefty wrote: Can you try this version? Thanks. Applied. -- Hal ___ openib-general mailing list [EMAIL PROTECTED] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit

RE: [openib-general] OpenIB gen1 stack u/kDAPL by NTT DATA

2004-11-12 Thread Woodruff, Robert J
Hi Masanori, Matt Leninger from Sandia controls who has access to the svn tree. You should probably contact him for providing contributions. cheers woody -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Masanori ITOH Sent: Thursday, November 11, 2004

[openib-general] Re: [PATCH] [2/2] change QP state to SQE

2004-11-12 Thread Roland Dreier
Sean That would work fine, and be only a minor update to the MAD Sean code. Will you be generated a patch for mthca? Yes, eventually. (ib_verbs.h will also need an update to add the field to ib_qp_attr) - R. ___ openib-general mailing list

[openib-general] [PATCH] Remove unneeded call in MAD code

2004-11-12 Thread Sean Hefty
This patch removes ib_mad_return_posted_send_mads, which isn't needed when shutting down. There cannot be any sends outstanding at this point, or clients still exist. - Sean Index: core/mad.c === --- core/mad.c (revision 1222) +++

[openib-general] Re: [PATCH] Remove unneeded call in MAD code

2004-11-12 Thread Hal Rosenstock
On Fri, 2004-11-12 at 15:39, Sean Hefty wrote: This patch removes ib_mad_return_posted_send_mads, which isn't needed when shutting down. There cannot be any sends outstanding at this point, or clients still exist. Thanks. Applied. -- Hal ___

[openib-general] [PATCH] collapse MAD function calls

2004-11-12 Thread Sean Hefty
This patch callapses several function calls into one when activating the MAD QPs. This avoids repeated allocation/freeing of memory. I have plans to examine the QP transitions to the reset state to see if these are necessary and if a race condition exists between shutting down a port and

[openib-general] Re: [PATCH] collapse MAD function calls

2004-11-12 Thread Hal Rosenstock
On Fri, 2004-11-12 at 19:45, Sean Hefty wrote: This patch callapses several function calls into one when activating the MAD QPs. This avoids repeated allocation/freeing of memory. I have plans to examine the QP transitions to the reset state to see if these are necessary and if a race

[openib-general] Re: [PATCH] [2/2] change QP state to SQE

2004-11-12 Thread Roland Dreier
OK, here's a patch that adds support for Current QP state in the modify QP verb. Does this look OK? Thanks, Roland Index: infiniband/include/ib_verbs.h === --- infiniband/include/ib_verbs.h (revision 1223) +++