Re: [openib-general] Re: inline support in Gen2

2005-05-13 Thread Roland Dreier
I just checked in implementations of ibv_attach_mcast() and ibv_detach_mcast(). I didn't really test them, so please let me know if you see any problems using them. - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailma

Re: [openib-general] Re: slab error in kmem_cache_destroy(): cache `ib_mad': Can't free all objects

2005-05-13 Thread Hal Rosenstock
On Fri, 2005-05-06 at 12:52, Hal Rosenstock wrote: > On Wed, 2005-05-04 at 02:57, Michael S. Tsirkin wrote: > > > If this only occurs on machines which are running OpenSM, it could be a > > > problem with the local MAD handling where ib_free_recv_mad is not called > > > for some case where it sho

Re: [openib-general] Re: inline support in Gen2

2005-05-13 Thread Roland Dreier
The max_inline_data changes are now checked in. You can pass a request for a max_inline_data value into ibv_create_qp() via qp_attr.cap.max_inline_data, and the actual value (guaranteed to be at least as much as you requested) will be returned in the same location. - R. _

[openib-general] [PATCH] [kdapl] CM: Eliminate explicit send DREQ on error in do_rep_recv

2005-05-13 Thread Hal Rosenstock
CM: Eliminate explicit send DREQ on error in do_rep_recv Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Index: dapl_openib_cm.c === --- dapl_openib_cm.c(revision 2348) +++ dapl_openib_cm.c(working copy) @@ -99,7 +99,6 @@

[openib-general] [PATCH] kDAPL: change EXPORT_SYMBOL to EXPORT_SYMBOL_GPL

2005-05-13 Thread Tom Duffy
On Fri, 2005-05-13 at 11:52 -0700, Caitlin Bestler wrote: > What about kernel clients that are compiled separately from the kernel > that want to be OS neutral and use kdat.h as published by the DAT > Collaborative? Make sure this doesn't happen. Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Inde

[openib-general] Re: [PATCH 1/2] (fixed) mthca: max_inline_data support

2005-05-13 Thread Roland Dreier
Thanks, I ended up committing this slightly modified patch: --- infiniband/hw/mthca/mthca_dev.h (revision 2287) +++ infiniband/hw/mthca/mthca_dev.h (working copy) @@ -439,12 +439,14 @@ int mthca_alloc_qp(struct mthca_dev *dev struct mthca_cq *recv_cq,

Re: [openib-general] [PATCH 2/2] libmthca: max_inline_data support

2005-05-13 Thread Roland Dreier
Thanks, I committed the following patch. I fixed the computation + qp->sq.max_gs= align(cap->max_inline_data + +sizeof (struct mthca_inline_seg), +sizeof (struct mthca_data_seg)); to divide by sizeof (struct mthca_

[openib-general] Re: MAD module removal and MAD cache

2005-05-13 Thread Hal Rosenstock
On Fri, 2005-05-13 at 15:31, Sean Hefty wrote: > Hal Rosenstock wrote: > > Hi Sean, > > > > The MAD send code can place a send request on the send list, the QP's > > send queue, or overflow list. > > > > On port close, I see the receive queue being cleaned up but not these. > > > > Am I missing

[openib-general] [PATCH] [CM] reject stale connections

2005-05-13 Thread Sean Hefty
The following patch will reject stale connection requests. It also fixes a couple of minor error handling cleanup issues found during testing, and fixes a bug handling a stale connection reject message where the cm_id would access an invalid timewait pointer. Signed-off-by: Sean Hefty <[EMAIL PROT

[openib-general] Re: [PATCH][TRIVIAL] [kdapl] Minor CM Changes

2005-05-13 Thread James Lentini
Committed in revision 2346. On Fri, 13 May 2005, Hal Rosenstock wrote: halr> Minor CM changes halr> Change label in do_rep_recv to more appropriate name halr> halr> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> halr> halr> Index: dapl_openib_cm.c halr> =

[openib-general] Re: MAD module removal and MAD cache

2005-05-13 Thread Sean Hefty
Hal Rosenstock wrote: Hi Sean, The MAD send code can place a send request on the send list, the QP's send queue, or overflow list. On port close, I see the receive queue being cleaned up but not these. Am I missing something ? If I'm not, then this may be the MAD cache leak which causes a problem

[openib-general] Re: [PATCH] libibcm building

2005-05-13 Thread Libor Michalek
On Fri, May 13, 2005 at 10:22:53AM -0400, Hal Rosenstock wrote: > Hi Libor, > > A couple of minor libibcm building comments: > > 1. When running autogen.sh, it warns about: > Makefile.am:19: variable `ucm_version_script' not defined > > 2. example/simple is not built by the current makefile gene

Re: [openib-general] Re: [openib-commits] r2337 - gen2/users/jlentini/linux-kernel

2005-05-13 Thread Roland Dreier
James> I had a hard time checking in this update. Subversion kept James> spitting out messages that my text-base file didn't have James> the correct checksum value. Has anyone ever seen that? Is it possible that you modified a file in a .svn directory somewhere? Based on the typo check

[openib-general] Re: [PATCH] libibcm/examples/simple.c: Eliminate a couple of warnings

2005-05-13 Thread Libor Michalek
On Fri, May 13, 2005 at 10:41:57AM -0400, Hal Rosenstock wrote: > libibcm/examples/simple.c: Eliminate a couple of warnings > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Applied, but including netinet/in.h required me to rename connect() because of the type conflict in socket.h. Also I

[openib-general] MAD module removal and MAD cache

2005-05-13 Thread Hal Rosenstock
Hi Sean, The MAD send code can place a send request on the send list, the QP's send queue, or overflow list. On port close, I see the receive queue being cleaned up but not these. Am I missing something ? If I'm not, then this may be the MAD cache leak which causes a problem when running SM, ki

Re: [openib-general] Re: [PATCHv2] kDAPL: remove DAT_RETURN

2005-05-13 Thread Grant Grundler
Caitlin, there has been sufficient discussion about user vs kernel space on this list in the past. I'll recap key points. But you'll want to use google (or something) to read some of the previous discussion on this topic. On Fri, May 13, 2005 at 11:52:34AM -0700, Caitlin Bestler wrote: > What abou

Re: [openib-general] Re: [openib-commits] r2337 - gen2/users/jlentini/linux-kernel

2005-05-13 Thread Tom Duffy
On Fri, 2005-05-13 at 14:10 -0400, James Lentini wrote: > I had a hard time checking in this update. Subversion kept spitting > out messages that my text-base file didn't have the correct checksum > value. Has anyone ever seen that? I haven't. I might suggest blowing away your whole archive an

[openib-general] Re: [PATCH] [kdapl]: Reduce CM retry count

2005-05-13 Thread James Lentini
Committed in revision 2341. On Fri, 13 May 2005, Hal Rosenstock wrote: halr> Reduce CM retry count halr> halr> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> halr> halr> Index: dapl_openib_cm.h halr> === halr> -- dapl_openib_cm

Re: [openib-general] Re: [PATCHv2] kDAPL: remove DAT_RETURN

2005-05-13 Thread Tom Duffy
On Fri, 2005-05-13 at 11:52 -0700, Caitlin Bestler wrote: > What about kernel clients that are compiled separately from the kernel > that want to be OS neutral and use kdat.h as published by the DAT > Collaborative? That never want to be put back into mainline Linux? Too bad. Not our problem. -

RE: [openib-general] Re: [PATCH] make private data pointers const

2005-05-13 Thread Sean Hefty
>> This patch affects ib_cm.h and cm.c, which appear to be maintained >> by Sean, and ucm.c, which appears to be maintained by Libor. >> >> The patch adds the const qualifier to private data pointers passed >> into the IB layer. > >Sean, if you're going to check in the CM portion, go ahead and chec

Re: [openib-general] Re: [PATCHv2] kDAPL: remove DAT_RETURN

2005-05-13 Thread Caitlin Bestler
On 5/13/05, James Lentini <[EMAIL PROTECTED]> wrote: > > caitlin> DAT_RETURN serves two distinct purposes: it is an immediate return > caitlin> to a kernel specific caller, and it is a standardized error encoding > for > caitlin> clients outside of the linux kernel (loadable modules and or proxie

[openib-general] Re: [PATCH] SDP & CM: change some functions to return void

2005-05-13 Thread Libor Michalek
On Fri, May 13, 2005 at 09:30:32AM -0700, Sean Hefty wrote: > Tom Duffy wrote: > > This patch changes some functions to return void rather than an int > > since they were always returning 0, thus making checking return values > > rather pointless. The patch touches both SDP and CM. > > Thanks, To

[openib-general] Re: [PATCH] make private data pointers const

2005-05-13 Thread Libor Michalek
On Thu, May 12, 2005 at 10:00:47PM -0400, James Lentini wrote: > > This patch affects ib_cm.h and cm.c, which appear to be maintained > by Sean, and ucm.c, which appears to be maintained by Libor. > > The patch adds the const qualifier to private data pointers passed > into the IB layer. Sean,

Re: [openib-general] Re: [PATCHv2] kDAPL: remove DAT_RETURN

2005-05-13 Thread James Lentini
caitlin> DAT_RETURN serves two distinct purposes: it is an immediate return caitlin> to a kernel specific caller, and it is a standardized error encoding for caitlin> clients outside of the linux kernel (loadable modules and or proxied caitlin> user consumers). caitlin> caitlin> Even if the func

[openib-general] $B?75,EPO?$NJ}$O(B10000$B1_J,L5NA(B

2005-05-13 Thread info
$B0lK|1_J,!*40A4L5NA$G;HMQ(BOK $B"#:#$J$i4V$K9g$&(BW$B%A%c%s%9!*L5NA%]%$%s%H%"%C%W3Z$7$5(B100$BG\!*"#(B $B"([EMAIL PROTECTED](B $B0l0L!'5U1g!J(B189$BL>EPO?!K(B $BFs0L!'1g8r!J(B429$BL>EPO?!K(B $B;00L!'(BSM$B5U1g!J(B243$BL>EPO?!K(B $B;M0L!'%;%U%l!J(B1038$BL>EPO?!K(B $B8^

[openib-general] Re: [openib-commits] r2337 - gen2/users/jlentini/linux-kernel

2005-05-13 Thread James Lentini
On Fri, 13 May 2005, Tom Duffy wrote: tduffy> On Fri, 2005-05-13 at 10:51 -0700, [EMAIL PROTECTED] wrote: tduffy> > Modified: gen2/users/jlentini/linux-kernel/TODO tduffy> > === tduffy> > --- gen2/users/jlentini/linux-kernel/TODO

Re: [openib-general] Re: [openib-commits] r2337 - gen2/users/jlentini/linux-kernel

2005-05-13 Thread Tom Duffy
On Fri, 2005-05-13 at 11:04 -0700, Tom Duffy wrote: > On Fri, 2005-05-13 at 10:51 -0700, [EMAIL PROTECTED] wrote: > > Modified: gen2/users/jlentini/linux-kernel/TODO > > === > > --- gen2/users/jlentini/linux-kernel/TODO 2005-05-13 17

[openib-general] Re: [openib-commits] r2337 - gen2/users/jlentini/linux-kernel

2005-05-13 Thread Tom Duffy
On Fri, 2005-05-13 at 10:51 -0700, [EMAIL PROTECTED] wrote: > Modified: gen2/users/jlentini/linux-kernel/TODO > === > --- gen2/users/jlentini/linux-kernel/TODO 2005-05-13 17:31:24 UTC (rev > 2336) > +++ gen2/users/jlentini/linux-k

Re: [openib-general] Re: user-mode verbs on Itanium

2005-05-13 Thread Bernhard Fischer
On Thu, May 12, 2005 at 08:55:50AM -0700, Grant Grundler wrote: >On Wed, May 11, 2005 at 10:21:38AM +0300, Michael S. Tsirkin wrote: >> You mean just sample the clock before the first post? > >Yes. > >> That would be easy, but lets look at what does it measure: >> >> On the client, you just get th

Re: [openib-general] Re: use of virt_to_phys in sdp

2005-05-13 Thread Roland Dreier
Libor> It is incorrect. The regular send/recv path uses the DMA Libor> API correctly, but RDMA to internal buffers on both the Libor> send and receive path is still using plain old Libor> virt_to_phys. Also, does FMR map/unmap use the DMA API, or Libor> does that need to be ta

[openib-general] Re: [PATCH] kDAPL: remove typedef DAT_NAME_PTR

2005-05-13 Thread James Lentini
Committed in revision 2336. On Thu, 12 May 2005, Tom Duffy wrote: tduffy> Remove typedef DAT_NAME_PTR. Also get rid of DAT_UVERYLONG & DAT_PADDR tduffy> that are not used anywhere outside of dat.h. Also, a little more tduffy> whitespace cleaning that should have been done with the DAT_RETURN t

[openib-general] Re: use of virt_to_phys in sdp

2005-05-13 Thread Libor Michalek
On Fri, May 13, 2005 at 05:06:00PM +0300, Michael S. Tsirkin wrote: > Use of virt_to_phys looks wrong in sdp_recv and sdp_send. > Must not the DMA API be used to get the physical address > to be put in ib_sge? It is incorrect. The regular send/recv path uses the DMA API correctly, but RDMA to in

Re: [openib-general] Re: [PATCH] (repost) sdp: replace mlock with get_user_pages

2005-05-13 Thread Libor Michalek
On Fri, May 13, 2005 at 04:51:45PM +0300, Michael S. Tsirkin wrote: > Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > > > > Libor> Always call aio_complete() immediately when > > Libor> iocb_complete() is called, and only spawn the work thread > > Libor> to unlock the memory after th

Re: [openib-general] [PATCH] CM: add invalid service ID handling

2005-05-13 Thread Sean Hefty
William Jordan wrote: Patch to respond to invalid REQs (no listener) with a REJ message. As just an FYI in case you're working on other CM areas, I'm working on sending REJs in the case of a stale connection, followed by adding in MRA support. I'm hoping to finish the state connection handling t

[openib-general] Re: [PATCH] SDP & CM: change some functions to return void

2005-05-13 Thread Sean Hefty
Tom Duffy wrote: This patch changes some functions to return void rather than an int since they were always returning 0, thus making checking return values rather pointless. The patch touches both SDP and CM. Thanks, Tom. Since the majority of these changes affect SDP, and the check-ins should b

[openib-general] [PATCH] SDP & CM: change some functions to return void

2005-05-13 Thread Tom Duffy
This patch changes some functions to return void rather than an int since they were always returning 0, thus making checking return values rather pointless. The patch touches both SDP and CM. Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> Index: linux-2.6.11-openib/drivers/infiniband/ulp/sdp/sdp_l

[openib-general] $B?75,EPO?$NJ}$O(B10000$B1_J,L5NA(B

2005-05-13 Thread info
$B0lK|1_J,!*40A4L5NA$G;HMQ(BOK $B"#:#$J$i4V$K9g$&(BW$B%A%c%s%9!*L5NA%]%$%s%H%"%C%W3Z$7$5(B100$BG\!*"#(B $B"([EMAIL PROTECTED](B $B0l0L!'5U1g!J(B189$BL>EPO?!K(B $BFs0L!'1g8r!J(B429$BL>EPO?!K(B $B;00L!'(BSM$B5U1g!J(B243$BL>EPO?!K(B $B;M0L!'%;%U%l!J(B1038$BL>EPO?!K(B $B8^

[openib-general] [PATCH] libibcm/examples/simple.c: Eliminate a couple of warnings

2005-05-13 Thread Hal Rosenstock
libibcm/examples/simple.c: Eliminate a couple of warnings Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Index: simple.c === --- simple.c(revision 2331) +++ simple.c(working copy) @@ -45,6 +45,7 @@ #include #include #

Re: [openib-general] Re: DAPL CM Reject Questions

2005-05-13 Thread James Lentini
If I don't use a function's return value, I cast it to void to say "I know this function returns something but I don't want to use it". I'm not sure were I picked up this habit, but I think it is fairly common. Some compilers will give a warning if you don't perform the cast, although gcc does

[openib-general] [PATCH] libibcm building

2005-05-13 Thread Hal Rosenstock
Hi Libor, A couple of minor libibcm building comments: 1. When running autogen.sh, it warns about: Makefile.am:19: variable `ucm_version_script' not defined 2. example/simple is not built by the current makefile generated. Below is a patch for this. -- Hal Add building of simple example for us

[openib-general] Re: [PATCH] Re: 0 op factor

2005-05-13 Thread Michael S. Tsirkin
Quoting r. Libor Michalek <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] Re: 0 op factor > > On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: > > On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: > > > > > - remove expect from _sdp_cm_path_complete(). > > > > When I

[openib-general] use of virt_to_phys in sdp

2005-05-13 Thread Michael S. Tsirkin
Use of virt_to_phys looks wrong in sdp_recv and sdp_send. Must not the DMA API be used to get the physical address to be put in ib_sge? -- MST - Michael S. Tsirkin ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listi

[openib-general] Re: user-mode verbs on Itanium

2005-05-13 Thread Michael S. Tsirkin
Quoting r. Grant Grundler <[EMAIL PROTECTED]>: > Subject: Re: user-mode verbs on Itanium > > On Wed, May 11, 2005 at 10:21:38AM +0300, Michael S. Tsirkin wrote: > > You mean just sample the clock before the first post? > > Yes. > > > That would be easy, but lets look at what does it measure: > >

Re: [openib-general] Re: [PATCH] (repost) sdp: replace mlock with get_user_pages

2005-05-13 Thread Michael S. Tsirkin
Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: [openib-general] Re: [PATCH] (repost) sdp: replace mlock with > get_user_pages > > Libor> Always call aio_complete() immediately when > Libor> iocb_complete() is called, and only spawn the work thread > Libor> to unlock th

[openib-general] [PATCH] user_mad: Support RMPP on send side

2005-05-13 Thread Hal Rosenstock
user_mad: Support RMPP on send side Note that this change will need a coordinated change to OpenSM and some userspace/management libraries which will be done as soon as possible once this patch is accepted. Receive side support for RMPP will be added separately. Signed-off-by: Hal Rosenstock <[E

[openib-general] [PATCH][TRIVIAL] [kdapl] Minor CM Changes

2005-05-13 Thread Hal Rosenstock
Minor CM changes Change label in do_rep_recv to more appropriate name Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Index: dapl_openib_cm.c === -- dapl_openib_cm.c (revision 2331) +++ dapl_openib_cm.c(working copy) @@ -68

[openib-general] [PATCH] [kdapl]: Reduce CM retry count

2005-05-13 Thread Hal Rosenstock
Reduce CM retry count Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Index: dapl_openib_cm.h === -- dapl_openib_cm.h(revision 2331) +++ dapl_openib_cm.h(working copy) @@ -40,7 +40,7 @@ #define DAPL_OPENIB_RC_RETRY_COUNT

[openib-general] Check it out!

2005-05-13 Thread Damon Karen
We offer three products at this point of time, please read the complete email for more information on each. Digital Cable Filters: http://SG3D.1clickresults.info Fuel Savers: http://ow1B.1clicktime.info Ebay Business Traning Program: http://SqX6.1clickaccess.info Free PPV: Unlock: *PPV ch

openib-general@openib.org

2005-05-13 Thread info
$B"v!&!yL5NAEPO?%-%c%s%Z!<%sCf!y!&"v(B $B!!$d$C$Q$j=P0)$&$J$i$46a=j$G2q$($kAjhttp://www.jumpb2.net/?join $B!!%3%3$K%"%I8x3+$GBT$C$F$$$k$46a=jL<$,$$$C$Q$$(B(o^$B"O(B^o)[EMAIL PROTECTED]&!&(B $BEPO?8e(B5$BJ,0JFb$K$46a=j$G2q$([EMAIL PROTECTED]>R2pCW$7$^$9!#(B $

Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-13 Thread Bernhard Fischer
On Thu, May 12, 2005 at 03:48:57PM -0700, Libor Michalek wrote: >On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: >> On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: >> >> > - remove expect from _sdp_cm_path_complete(). >> >> When I said that the SDP_EXPECT should

Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-13 Thread Bernhard Fischer
On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: >On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: >> - remove '0 operator factor' statements. >> - a bit of whitespace removal. >> - remove return at end of void functions. > > If you're removing the 'return' why not