[openib-general] [2.6 patch] drivers/infiniband/hw/cxgb3/: cleanups

2007-02-21 Thread Adrian Bunk
On Tue, Feb 20, 2007 at 08:43:06AM -0600, Steve Wise wrote: On Tue, 2007-02-20 at 01:02 +0100, Adrian Bunk wrote: This patch contains the following possible cleanups: - don't mark static functions in C files as inline - gcc should know best whether inlining makes sense - never compile

[openib-general] [2.6 patch] drivers/infiniband/hw/cxgb3/: possible cleanups

2007-02-19 Thread Adrian Bunk
() - iwch_provider.c: iwch_get_qp() - #if 0 the following unused global functions: - cxio_hal.c: cxio_allocate_stag() - cxio_resource.: cxio_hal_get_rhdl() - cxio_resource.: cxio_hal_put_rhdl() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/Makefile|1

[openib-general] [2.6 patch] infiniband/hw/mthca/mthca_mr.c: make 2 functions static

2007-02-19 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/infiniband/hw/mthca/mthca_mr.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) --- linux-2.6.20-mm1/drivers/infiniband/hw/mthca/mthca_mr.c.old 2007-02-17 17:41

[openib-general] infiniband/hw/amso1100/c2_provider.c: possible NULL dereference

2006-11-08 Thread Adrian Bunk
The Coverity checker noted the following in drivers/infiniband/hw/amso1100/c2_provider.c: -- snip -- ... int c2_register_device(struct c2_dev *dev) { int ret; int i; /* Register pseudo network device */ dev-pseudo_netdev = c2_pseudo_netdev_init(dev);

[openib-general] 2.6.19-rc4: known unfixed regressions (v4)

2006-11-07 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering

[openib-general] 2.6.19-rc4: known unfixed regressions (v3)

2006-11-05 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc4 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[openib-general] [-mm patch] drivers/infiniband/hw/amso1100/: possible cleanups

2006-09-04 Thread Adrian Bunk
() - c2_cq.c: c2_cq_get() - c2_cq.c: c2_cq_put() - c2_qp.c: to_ib_state() - c2_qp.c: to_ib_state_str() - c2_rnic.c: c2_rnic_query() - #if 0 the following unused global function: - c2_mq.c: c2_mq_count() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/infiniband/hw/amso1100/c2.h

[openib-general] 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile error

2006-09-01 Thread Adrian Bunk
On Fri, Sep 01, 2006 at 01:58:18AM -0700, Andrew Morton wrote: ... Changes since 2.6.18-rc4-mm3: ... +amso1100-build-fix.patch Fix git-infiniband.patch ... This causes the following compile error on i386: -- snip -- ... CC drivers/infiniband/hw/amso1100/c2.o

Re: [openib-general] [patch 02/45] IB/mthca: restore missing PCI registers after reset

2006-08-09 Thread Adrian Bunk
On Tue, Aug 08, 2006 at 02:39:37AM +0300, Michael S. Tsirkin wrote: Quoting r. Michael S. Tsirkin [EMAIL PROTECTED]: Subject: Re: [patch 02/45] IB/mthca: restore missing PCI registers after reset Quoting r. Adrian Bunk [EMAIL PROTECTED]: Thanks for this information, I've applied

Re: [openib-general] [patch 02/45] IB/mthca: restore missing PCI registers after reset

2006-08-07 Thread Adrian Bunk
On Sun, Aug 06, 2006 at 08:04:25AM +0300, Michael S. Tsirkin wrote: Quoting r. Adrian Bunk [EMAIL PROTECTED]: Subject: Re: [patch 02/45] IB/mthca: restore missing PCI registers after reset It seems this patch should also be included in the 2.6.16.x branch, or do I miss anything

Re: [openib-general] [patch 02/45] IB/mthca: restore missing PCI registers after reset

2006-08-05 Thread Adrian Bunk
It seems this patch should also be included in the 2.6.16.x branch, or do I miss anything? TIA Adrian On Mon, Jul 17, 2006 at 09:25:31AM -0700, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- mthca does not restore the following

[openib-general] [-mm patch] drivers/scsi/qla2xxx/: make some functions static

2006-06-21 Thread Adrian Bunk
On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: ... Changes since 2.6.17-rc6-mm2: ... git-infiniband.patch ... git trees ... This patch makes some needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gbl.h |6

[openib-general] [2.6 patch] drivers/infiniband/hw/mthca/mthca_mad.c: make a function static

2006-04-18 Thread Adrian Bunk
This patch makes the needlessly global mthca_update_rate() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.17-rc1-mm3-full/drivers/infiniband/hw/mthca/mthca_mad.c.old 2006-04-18 21:38:06.0 +0200 +++ linux-2.6.17-rc1-mm3-full/drivers/infiniband/hw/mthca

[openib-general] 2.6.16-rc6-mm2: new RDMA CM EXPORT_SYMBOL's

2006-03-18 Thread Adrian Bunk
On Sat, Mar 18, 2006 at 04:40:56AM -0800, Andrew Morton wrote: ... Changes since 2.6.16-rc6-mm1: ... git-infiniband.patch ... git trees. ... I'm not exactly happy that this tree adds tons of RDMA CM EXPORT_SYMBOL's that are neither currently used nor _GPL. cu Adrian -- Is there

[openib-general] Re: [PATCH 18 of 20] ipath - kbuild infrastructure

2006-03-13 Thread Adrian Bunk
On Thu, Mar 09, 2006 at 04:35:48PM -0800, Bryan O'Sullivan wrote: ... --- /dev/null Thu Jan 1 00:00:00 1970 + +++ b/drivers/infiniband/hw/ipath/MakefileThu Mar 9 16:17:00 2006 -0800 @@ -0,0 +1,42 @@ +EXTRA_CFLAGS += -O3 I'm still a bit surprised, since in the rest of the kernel we

[openib-general] Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile

2005-12-17 Thread Adrian Bunk
On Fri, Dec 16, 2005 at 03:48:55PM -0800, Roland Dreier wrote: ... --- /dev/null +++ b/drivers/infiniband/hw/ipath/Kconfig @@ -0,0 +1,18 @@ +config IPATH_CORE + tristate PathScale InfiniPath Driver + depends on PCI_MSI X86_64 ... The driver shouldn't use assembler code and

Re: [openib-general] Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile

2005-12-17 Thread Adrian Bunk
On Sat, Dec 17, 2005 at 02:54:44PM -0800, Robert Walsh wrote: The driver shouldn't use assembler code and therefore no longer depend on X86_64. Agreed about the assembler, but one way or the other, x86_64 is the only arch we support. ... There's a difference between technically supported

[openib-general] Re: [PATCH 03/13] [RFC] ipath copy routines

2005-12-17 Thread Adrian Bunk
On Sat, Dec 17, 2005 at 07:19:32PM -0800, Andrew Morton wrote: ... In what form is this chip available? As a standard PCI/PCIX card which people will want to plug into power4/ia64/x86 machines? Or is it in some way exclusively tied to x86_64? Hardware can hardly be exclusively tied to x86_64

[openib-general] Re: [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

2005-11-29 Thread Adrian Bunk
On Mon, Nov 28, 2005 at 09:59:17AM -0800, Roland Dreier wrote: Adrian Can you Cc me when forwarding it to Linus? Looks like it went into Linus's tree directly from you (which is fine). It went through Andrew. Adrian After it's in Linus' tree, Greg will accept it for the Adrian

[openib-general] Re: [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

2005-11-27 Thread Adrian Bunk
On Sun, Nov 27, 2005 at 03:51:41PM -0800, Roland Dreier wrote: Thanks, I already have this in my git tree of pending changes (I found it by actually hitting the crash it causes with CONFIG_DEBUG_SLAB=y). Can you Cc me when forwarding it to Linus? After it's in Linus' tree, Greg will accept it

[openib-general] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

2005-11-26 Thread Adrian Bunk
The Coverity checker spotted this obvious NULL pointer dereference caused by a wrong order of the cleanups. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 23 Nov 2005 - 21 Nov 2005 --- linux-2.6.15-rc1-mm2-full/drivers/infiniband/core/mad.c.old 2005-11-20

[openib-general] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

2005-11-23 Thread Adrian Bunk
The Coverity checker spotted this obvious NULL pointer dereference caused by a wrong order of the cleanups. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 21 Nov 2005 --- linux-2.6.15-rc1-mm2-full/drivers/infiniband/core/mad.c.old 2005-11-20 22:04

[openib-general] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

2005-11-20 Thread Adrian Bunk
The Coverity checker spotted this obvious NULL pointer dereference caused by a wrong order of the cleanups. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.15-rc1-mm2-full/drivers/infiniband/core/mad.c.old 2005-11-20 22:04:36.0 +0100 +++ linux-2.6.15-rc1-mm2-full/drivers

[openib-general] 2.6.11-rc4-mm1: infiniband/core/user_mad.c warning

2005-02-24 Thread Adrian Bunk
On Wed, Feb 23, 2005 at 01:42:33AM -0800, Andrew Morton wrote: ... Changes since 2.6.11-rc3-mm1: ... bk-driver-core-infiniband-build-fix.patch ... This gives me the following compile error: -- snip -- ... CC drivers/infiniband/core/user_mad.o drivers/infiniband/core/user_mad.c:587:

[openib-general] [2.6 patch] infiniband: possible cleanups

2005-01-03 Thread Adrian Bunk
|2 - drivers/infiniband/ulp/ipoib/ipoib_main.c |2 - drivers/infiniband/ulp/ipoib/ipoib_multicast.c |4 +-- 14 files changed, 73 insertions(+), 9 deletions(-) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.10-mm1-full/drivers/infiniband/ulp/ipoib

[openib-general] infiniband: rename two source files?

2005-01-03 Thread Adrian Bunk
drivers/infiniband/core/Makefile contains the following: -- snip -- ... ib_sa-y := sa_query.o ib_umad-y :=user_mad.o -- snip -- Is it planned to add other objects to ib_sa and/or ib_umad, or would you accept a patch to rename the source files? cu

[openib-general] Re: [2.6 patch] infiniband: possible cleanups

2005-01-03 Thread Adrian Bunk
On Mon, Jan 03, 2005 at 11:45:53AM -0800, Roland Dreier wrote: Thanks, I've applied the changes adding static to our tree. I'm holding off on the #if 0 changes since some is code useful for debugging modules and other code is used by modules in development. Is there an ETA when the debugging

[openib-general] Re: [PATCH][RFC/v2][2/21] Add core InfiniBand support

2004-11-23 Thread Adrian Bunk
On Tue, Nov 23, 2004 at 08:14:19AM -0800, Roland Dreier wrote: Add implementation of core InfiniBand support. This can be thought of as a midlayer that provides an abstraction between low-level hardware drivers and upper level protocols (such as IP-over-InfiniBand). Signed-off-by: Roland