Re: [openib-general] [PATCH 5/6] Use pci_find_ht_capability() in drivers/pci/quirks.c

2006-11-12 Thread Benjamin Herrenschmidt
> It's not pretty I admit. pci_find_next_ht_capability() would also take a > ttl, and pass it through to pci_find_next_capability(). AFAICT that > would avoid any infinite hang scenarios? What if we didn't try to solve a problem we don't have ? Have we yet encountered an HT device with that sort

Re: [openib-general] Can't build drivers/infiniband/hw/ipath/ipath_keys.c on arch/powerpc

2006-11-06 Thread Benjamin Herrenschmidt
On Mon, 2006-11-06 at 08:52 -0800, Roland Dreier wrote: > > I'm surprised that something as recent as infiniband requires a > > long-deprecated function bus_to_virt(). > > > > What is it trying to do there that needs that call ? > > Don't ask -- just enjoy the fact that you don't know about t

Re: [openib-general] Can't build drivers/infiniband/hw/ipath/ipath_keys.c on arch/powerpc

2006-11-06 Thread Benjamin Herrenschmidt
On Mon, 2006-11-06 at 18:33 +1100, Michael Ellerman wrote: > Hi, > > Just a heads-up, drivers/infiniband/hw/ipath/ipath_keys.c doesn't build > on powerpc because we have don't have bus_to_virt(). > > (Actually you can't select CONFIG_INFINIBAND_IPATH on mainline because > powerpc doesn't enable P

Re: [openib-general] [PATCH 2.6.19 4/4] ehca: ehca_av.c use constant for max mtu

2006-11-05 Thread Benjamin Herrenschmidt
Can you fix your patch sending technique ? A mangled patch inline with a non-mangled one in attachment... that's a bit gross. Just get a proper one inline and be done with it. If your mailer can't be coerced into not damaging patches, then use another one for sending them. Cheers, Ben _

Re: [openib-general] [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: > On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: > > > > +int ipath_unordered_wc(void) > > > +{ > > > + return 1; > > > +} > > > > How is the above providin

Re: [openib-general] [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
> +#if defined(__powerpc__) > + /* There isn't a generic way to specify writethrough mappings */ > + pgprot_val(vma->vm_page_prot) |= _PAGE_NO_CACHE; > + pgprot_val(vma->vm_page_prot) |= _PAGE_WRITETHRU; > + pgprot_val(vma->vm_page_prot) &= ~_PAGE_GUARDED; > +#endif I don't see an