[openib-general] [PATCH] osm_vendor_mlx.c : missing pointer check

2006-05-08 Thread Ofer Gigi
Hi Hal, Bug fix: When the driver is down and you try to raise opensm - it exits in segmentation fault. The reason for this is that __osm_vendor_internal_unbind is called with h_bind==0. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_vendor_mlx.c

RE: [openib-general] [PATCH] osm_port_info_rcv.c : clear clientreregister bit

2006-05-01 Thread Ofer Gigi
Hi Hal, Did you apply this one below? I forgot to CC you, and as far as I can see it is not applied. Thanks! Ofer -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ofer Gigi Sent: Thursday, April 27, 2006 1:46 PM To: OPENIB Subject: [openib-general] [PATCH

[openib-general] [PATCH] osm_lid_mgr.c : exit only if exit_on_fatal in case of corrupted guid2lid file

2006-05-01 Thread Ofer Gigi
of a corrupted guid2lid file - it will just put an error in the log. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_lid_mgr.c === --- osm_lid_mgr.c (revision 6640) +++ osm_lid_mgr.c (working copy) @@ -304,11

[openib-general] RE: [PATCH] osm_lid_mgr.c : exit only if exit_on_fatal in case of corrupted guid2lid file

2006-05-01 Thread Ofer Gigi
Hi Hal, Please apply to trunk and branch. Thanks! Ofer -Original Message- From: Ofer Gigi Sent: Monday, May 01, 2006 11:23 AM To: 'openib-general@openib.org' Cc: '[EMAIL PROTECTED]' Subject: [PATCH] osm_lid_mgr.c : exit only if exit_on_fatal in case of corrupted guid2lid file Hi Hal

[openib-general] [PATCH] osm_switch.c : bug fix

2006-05-01 Thread Ofer Gigi
Hi Hal, Bug fix: In the function osm_switch_get_fwd_tbl_block in osm_switch.c we were missing one block in case the maximum lid was the multiplication of lids_per_block (==64). Adding = instead of to fix the problem. Please apply to trunk and branch. Thanks Ofer G. Signed-off-by: Ofer Gigi

[openib-general] [PATCH] osm_port_info_rcv.c : clear client reregister bit

2006-04-27 Thread Ofer Gigi
Hi Hal, Bug Fix: On receive of client reregister - clear the reregister bit - so reregistering won't be sent again and again Please apply to trunk and branch. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_port_info_rcv.c

[openib-general] [PATCH] osm_sa_mcmember_record : MCMember Get/GetTable Trusted mode

2006-04-26 Thread Ofer Gigi
Hi Hal, Small minor chnages: 1. Adding () for the if statement 2. Clearer messages when duplicate guids are found Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm/opensm/osm_node_info_rcv.c === --- osm

RE: FW: [openib-general] [PATCH] osm_sa_mcmember_record :MCMemberGet/GetTable Trusted mode

2006-03-25 Thread Ofer Gigi
Hi Hal, I had a problem sending this email. So if you got several copies, please pick any one of them - all of them are the same. Thanks! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Friday, March 24, 2006 5:24 PM To: Ofer Gigi Cc: openib-general

[openib-general] [PATCH] osm_sa_mcmember_record : MCMember Get/GetTable Trusted mode

2006-03-23 Thread Ofer Gigi
, ProxyJoin, and the JoinState components set to 0, except where trust is specified as indicated above, in that case the actual contents for the above components will be provided. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_sa_mcmember_record.c

[openib-general] [PATCH] osm_mcast_mgr: using deleted handle caused segmentation fault

2006-03-20 Thread Ofer Gigi
running osmtest -f m -M 3 and running opensm compiled with efence - memory allocation tool. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_mcast_mgr.c === --- osm_mcast_mgr.c (revision 5887

[openib-general] RE: [PATCH] vendor: identify rmpp mads

2006-03-19 Thread Ofer Gigi
not there, I looked on the file mad.c in my machine, and I am not sure it is updated) Thanks! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Friday, March 17, 2006 2:07 AM To: Ofer Gigi Cc: OPENIB Subject: Re: [PATCH] vendor: identify rmpp mads Hi Ofer, On Thu

[openib-general] [PATCH] vendor: identify rmpp mads

2006-03-16 Thread Ofer Gigi
know whether they are defined as constants or not - so I didn't handle them. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_vendor_mlx_svc.h === --- osm_vendor_mlx_svc.h(revision 5836

RE: [openib-general] [PATCH] vendor: identify rmpp mads

2006-03-16 Thread Ofer Gigi
) IB_MGMT_RMPP_FLAG_ACTIVE) ((struct ib_rmpp_mad *)mad)-rmpp_hdr.rmpp_type == IB_MGMT_RMPP_TYPE_DATA); } -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ofer Gigi Sent: Thursday, March 16, 2006 7:14 PM To: OPENIB Subject: [openib-general

[openib-general] RE: [PATCH] osm_lid_mgr: handle different MTU

2006-03-12 Thread Ofer Gigi
Hi Hal, I retested it with the fix: __osm_lid_mgr_set_remote_pi_state_to_init(p_mgr, p_physp); and it is OK. Please check-in this change. Thanks again! Ofer -Original Message- From: Ofer Gigi Sent: Sunday, March 12, 2006 10:02 AM To: 'Hal Rosenstock' Cc: OPENIB Subject: RE: [PATCH

[openib-general] RE: [PATCH] osm_lid_mgr: handle different MTU

2006-03-11 Thread Ofer Gigi
Hi Hal, Thanks a lot for your comments. It should be as you said: __osm_lid_mgr_set_remote_pi_state_to_init(p_mgr, p_physp); I will retest it. Thanks! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Thursday, March 09, 2006 4:36 PM To: Ofer Gigi Cc: OPENIB

[openib-general] [PATCH] osm_link_mgr: handle different MTU

2006-03-08 Thread Ofer Gigi
. The change below fixes this issue. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_lid_mgr.c === --- osm_lid_mgr.c (revision 5628) +++ osm_lid_mgr.c (working copy) @@ -893,6 +893,21

[openib-general] [PATCH] osm: support for trivial PKey manager

2006-03-01 Thread Ofer Gigi
Hi Hal, Please add an empty file management/osm/include/opensm/osm_svn_revision.h This file is needed since during the build process we write into it the revision. When the file doesn't exists the writing fails. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED

[openib-general] [PATCH] osm: Adding revision empty file

2006-03-01 Thread Ofer Gigi
-by: Ofer Gigi [EMAIL PROTECTED] ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] RE: [PATCH] osm: Adding revision empty file

2006-03-01 Thread Ofer Gigi
! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 01, 2006 3:55 PM To: Ofer Gigi Cc: OPENIB Subject: Re: [PATCH] osm: support for trivial PKey manager Hi Ofer, On Wed, 2006-03-01 at 08:42, Ofer Gigi wrote: Hi Hal, Please add an empty file

[openib-general] RE: [PATCH] osm: Adding revision empty file

2006-03-01 Thread Ofer Gigi
/osmtest' make: *** [distdir] Error 1 Regards, Vladimir -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 01, 2006 4:29 PM To: Ofer Gigi Cc: OPENIB; Yael Kalka; Eitan Zahavi; Vladimir Sokolovsky; Tziporet Koren Subject: RE: [PATCH] osm: Adding revision

[openib-general] Send packets above ibumad and waiting for a response

2006-01-17 Thread Ofer Gigi
Hi, I am trying to write a test that will send/receive packets directly above IBUMAD. Does anyone have such a chunk of code that do this? Thanks a lot in advance! Ofer ___ openib-general mailing list openib-general@openib.org

[openib-general] [PATCH] osm: support for trivial PKey manager

2006-01-10 Thread Ofer Gigi
Hi Hal, Removing redundant error in the log. If the physical port is not valid, nothing is needed to be the done here. Thanks Ofer G. Signed-off-by: Ofer Gigi [EMAIL PROTECTED] Index: osm_pkey_mgr.c === --- osm_pkey_mgr.c

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2006-01-01 Thread Ofer Gigi
No space after while keyword - removed Should these comments just be removed ? No, please leave them, so people will know what they mean. Thanks ! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Friday, December 30, 2005 4:52 PM To: Ofer Gigi Cc: OPENIB

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Ofer Gigi
PM To: Ofer Gigi Cc: OPENIB Subject: Re: [PATCH] osm: support for trivial PKey manager Hi Ofer, On Thu, 2005-12-29 at 05:20, Ofer Gigi wrote: Hi Hal, My name is Ofer Gigi, and I am a new software engineer in Mellanox working on OpenSM. This patch provides a new manager that solves

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Ofer Gigi
that all physical ports have now 0x Thanks! Ofer -Original Message- From: Hal Rosenstock [mailto:[EMAIL PROTECTED] Sent: Thursday, December 29, 2005 4:24 PM To: Ofer Gigi Cc: OPENIB Subject: Re: [PATCH] osm: support for trivial PKey manager Hi Ofer, On Thu, 2005-12-29 at 05:20