Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-13 Thread Bernhard Fischer
On Thu, May 12, 2005 at 03:48:57PM -0700, Libor Michalek wrote: >On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: >> On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: >> >> > - remove expect from _sdp_cm_path_complete(). >> >> When I said that the SDP_EXPECT should

Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-13 Thread Bernhard Fischer
On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: >On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: >> - remove '0 operator factor' statements. >> - a bit of whitespace removal. >> - remove return at end of void functions. > > If you're removing the 'return' why not

Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-12 Thread Libor Michalek
On Tue, May 10, 2005 at 05:47:00PM -0700, Libor Michalek wrote: > On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: > > > - remove expect from _sdp_cm_path_complete(). > > When I said that the SDP_EXPECT should eventually be removed, I meant > that the functions which have their

Re: [PATCH] Re: [openib-general] 0 op factor

2005-05-10 Thread Libor Michalek
On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote: > On Thu, May 05, 2005 at 05:21:22PM -0700, Libor Michalek wrote: > > No point other then the obvious, changing the sign of the variables > >value. It's just a style convention that I have no problem changing. > > - remove '0 oper

[PATCH] Re: [openib-general] 0 op factor

2005-05-07 Thread Bernhard Fischer
On Thu, May 05, 2005 at 05:21:22PM -0700, Libor Michalek wrote: > No point other then the obvious, changing the sign of the variables >value. It's just a style convention that I have no problem changing. - remove '0 operator factor' statements. - a bit of whitespace removal. - remove return at e