Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
>> If name service resolution gives me an IPv6 address that's off of the local >> subnet, but the ARP response gives me an address that's on the local >> subnet, then I think we can assume that ARP was unsuccessful is resolving >> the address to the remote GID. (I.e. the GID should be for a router

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 07:23:47PM -0500, Hal Rosenstock wrote: > > One feature I've thought has been underused in IBA is the raw IPv6 > > packet feature. > > I thought raw support (including IPv6 header) although still in the spec > was largely deprecated as the CRC protection was deemed too weak

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Hal Rosenstock
On Wed, 2007-02-07 at 17:49, Jason Gunthorpe wrote: > On Wed, Feb 07, 2007 at 02:40:51PM -0800, Sean Hefty wrote: > > Are you referring to the SLID in the CM REQ? If so, I've been looking at > > this issue as well. I simply cannot think of any way to come up with this > > LID, and my current so

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Hal Rosenstock
On Wed, 2007-02-07 at 16:31, Jason Gunthorpe wrote: > On Wed, Feb 07, 2007 at 12:24:08PM -0800, Sean Hefty wrote: > > >I didn't get too far on getting CMA to work. Beyond the bad HopLimit > > >feild I was seeing Hal pointed out a number of problems in IBA that > > >would prevent it from working as

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Hal Rosenstock
On Wed, 2007-02-07 at 15:24, Sean Hefty wrote: > > I didn't get too far on getting CMA to work. Beyond the bad HopLimit > > feild I was seeing Hal pointed out a number of problems in IBA that > > would prevent it from working as is :< > > I've started thinking about what it would take to get the r

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
> We don't want to have the routers snoop and alter CM GMPs. agreed > The passive side cannot use information from the LRH to get the router > LID since the LRH may not be reversible. argh... I was interpreting symmetric paths at the network layer (SGID to DGID) and applying it at the link laye

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Roland Dreier
Jason> Basically, if IB routers are used, and the IPoIB feature of Jason> *not* spanning a subnet is used (for scalabililty?) then Jason> you need an alternate way to specify addresses to rdma cm. You mean if the IB router is also an IP router for IPoIB? Then I think there are some se

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 02:31:10PM -0800, Sean Hefty wrote: > >I agree that special casing some IPv6 addresses is a bad idea. It > >needs to be integrated correctly with NET and the routing table/etc > I haven't given this more than a few minutes of thought, but I was thinking > more along the

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 02:40:51PM -0800, Sean Hefty wrote: > Are you referring to the SLID in the CM REQ? If so, I've been looking at > this issue as well. I simply cannot think of any way to come up with this > LID, and my current solution is to punt this problem over to the passive > side,

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
> I don't think that is the main problem - though clearly the way things > are now (for better or worse) rdma cm requires the IPoIB subnet to > span all of the IB subnets.. The main problem with the protocol is in > the LID selection for routed paths on the passive side. It can't rely > on the acti

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 12:24:08PM -0800, Sean Hefty wrote: > >I didn't get too far on getting CMA to work. Beyond the bad HopLimit > >feild I was seeing Hal pointed out a number of problems in IBA that > >would prevent it from working as is :< > > I've started thinking about what it would take to

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Roland Dreier
> I've started thinking about what it would take to get the rdma cm to > work across a router. I think the rdma cm may need to treat IPv6 > addresses as a GID for this to work across subnets, versus trying to > map an ipoib IP address to a GID based on ARP. Hmm, why is that? Shouldn't IPoIB

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 01:35:25PM -0800, Roland Dreier wrote: > Hmm, why is that? Shouldn't IPoIB work through a router, and > correctly get the GID of the final destination via ARP just fine? Basically, if IB routers are used, and the IPoIB feature of *not* spanning a subnet is used (for scalab

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
> Basically, if IB routers are used, and the IPoIB feature of *not* > spanning a subnet is used (for scalabililty?) then you need an > alternate way to specify addresses to rdma cm. This was the case I was thinking of. Without global IB name service resolution, how do you get the GID of the rem

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
> I didn't get too far on getting CMA to work. Beyond the bad HopLimit > feild I was seeing Hal pointed out a number of problems in IBA that > would prevent it from working as is :< I've started thinking about what it would take to get the rdma cm to work across a router. I think the rdma cm ma

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Jason Gunthorpe
On Wed, Feb 07, 2007 at 10:55:00AM -0800, Sean Hefty wrote: > >Oops, I'll fix these style things and send a new patch. > > Jason, what's the status of this patch? (I ask because I'm starting to > look at router support in the stack.) I was going to resend it after Roland's earlier patch to clea

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Roland Dreier
> I was going to resend it after Roland's earlier patch to clean up the > ib_init_ah_from_path was accepted.. Sorry, I started having second thoughts about the part about changing it to return void (it seems more sensible to check it the other places it's called). But I'll look at that again s

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-02-07 Thread Sean Hefty
> Oops, I'll fix these style things and send a new patch. Jason, what's the status of this patch? (I ask because I'm starting to look at router support in the stack.) - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Roland Dreier
> ib_init_ah_from_path() is only used to initialize the ah_attr before > calling ib_create_ah(). We have to trap for failure from > ib_create_ah(), so if ib_init_ah_from_path simply aborts, would > ib_create_ah() simply fail later? Right now if ib_init_ah_from_path() fails then ib_create_ah()

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Sean Hefty
>> And even if that can occur, can the problem be pushed off until the user >> calls ib_create_ah? > > Not sure what you mean by this. ib_init_ah_from_path() is only used to initialize the ah_attr before calling ib_create_ah(). We have to trap for failure from ib_create_ah(), so if ib_init_ah_

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Hal Rosenstock
On Fri, 2007-01-26 at 16:45, Sean Hefty wrote: > >Maybe the best fix is to have ib_init_ah_from_path() itself print a > >warning if the GID index can't be found, just set the gid_index to 0 > >in that case, and change ib_init_ah_from_path() to return void? > > > >What do you think of doing somethin

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Sean Hefty
>Maybe the best fix is to have ib_init_ah_from_path() itself print a >warning if the GID index can't be found, just set the gid_index to 0 >in that case, and change ib_init_ah_from_path() to return void? > >What do you think of doing something like this for 2.6.21: Changing this to a void seems fi

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Roland Dreier
> I don't know. The other two users in the tree ignore the return > code right now.. The only reason it could fail is if it fails to map a local GID to a GID index. Which should never happen under normal circumstance. But it does look like the two other uses are somewhat buggy since they might

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-26 Thread Jason Gunthorpe
On Thu, Jan 25, 2007 at 09:15:31PM -0800, Roland Dreier wrote: > > + if ((ret = > ib_init_ah_from_path(priv->ca,priv->port,pathrec,&av))) > > kernel style is spaces after commas, like Oops, I'll fix these style things and send a new patch. > > + ipoib_dbg(priv, "Path

Re: [openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-25 Thread Roland Dreier
> +if ((ret = > ib_init_ah_from_path(priv->ca,priv->port,pathrec,&av))) kernel style is spaces after commas, like ib_init_ah_from_path(priv->ca, priv->port, pathrec, &av) also, I really prefer to see code like this written as ret = ib_init_ah_from_path(priv->ca, p

[openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

2007-01-25 Thread Jason Gunthorpe
ib_init_ah_from_path contains the logic to decide when to use a GRH so call ib_init_ah_from_path instead of the hand coded version in IPOIB. This change along with recent opensm changes allows unicast IPOIB traffic to traverse a router. Signed-off-by: Jason Gunthorpe <[EMAIL PROTECTED]> --- driv