Sasha Khapyorsky wrote:
I'm working on the changes below. I will send them all as one patch
EZ
> Hi Eitan,
>
> On 15:19 Thu 15 Jun , Eitan Zahavi wrote:
>
+/*
+* PARAMETERS
+* p_physp
+* [in] Pointer to an osm_physp_t object.
+*
+* RETURN VALUES
+* The poin
Hi Eitan,
On 15:19 Thu 15 Jun , Eitan Zahavi wrote:
> >>+/*
> >>+* PARAMETERS
> >>+* p_physp
> >>+* [in] Pointer to an osm_physp_t object.
> >>+*
> >>+* RETURN VALUES
> >>+* The pointer to the P_Key table object.
> >>+*
> >>+* NOTES
> >>+*
> >>+* SEE ALSO
> >>+* Port, Physical Port
> >>
On Thu, 2006-06-15 at 08:19, Eitan Zahavi wrote:
> >>+ p_pkey_tbl = osm_physp_get_mod_pkey_tbl( p_physp );
> >>+ if (! p_pkey_tbl)
> >
> >^
> > Is it possible?
> Yes it is ! I run into it during testing. The port did not have any pkey
> table.
PKey tables are optional
Sasha Khapyorsky wrote:
> Hi Eitan,
>
> Some comments about the patch.
Thanks for the review.
The major point you bring up is the fact I intentionally impose the result of
the
pkey settings on the SMDB and not wait for the GetResp to do that for me.
The idea I had was that once the Pkey Manage
Hi Eitan,
Some comments about the patch.
Personally I'm glad to see that you are using tab instead of spaces as
identaion character. But it would be nice if next time you will not mix
the functional changes and identaion fixes in the same patch, but instead
will provide two different patches. Als
Hi Hal,
Hal Rosenstock wrote:
> Hi Eitan,
>
> On Tue, 2006-06-13 at 08:54, Eitan Zahavi wrote:
>
>>--text follows this line--
>>Hi Hal
>>
>>This is a second take after debug and cleanup of the partition manager
>>patch I have previously provided.
>
>
> Thanks.
>
> So this patch superceeds the
Hi Eitan,
On Tue, 2006-06-13 at 08:54, Eitan Zahavi wrote:
> --text follows this line--
> Hi Hal
>
> This is a second take after debug and cleanup of the partition manager
> patch I have previously provided.
Thanks.
So this patch superceeds the previous version ? If so, in the future,
just indi
--text follows this line--
Hi Hal
This is a second take after debug and cleanup of the partition manager
patch I have previously provided. The functionality is the same but
this one is after 2 days of testing on the simulator.
I also did some code restructuring for clarity.
Tests passed were bot
Hi Hal
As I started to test the partition manager code (using ibmgtsim pkey test),
I realized the implementation does not really enforces the partition policy
on the given fabric. This patch fixes that. It was verified using the
simulation test. Several other corner cases were fixed too.
Eitan
