Arne Redlich wrote:
> In its current incarnation, cm_destroy_id() will not send a REJ if fed a
> magic number (err = -ENOMEM). This patch replaces this magic number with
> a more generic "reject" parameter.
The intent here is that if the user destroys their cm_id in the middle of
connection estab
Am Dienstag, den 18.07.2006, 17:31 +0300 schrieb Michael S. Tsirkin:
> Quoting r. Arne Redlich <[EMAIL PROTECTED]>:
> > Subject: Re: [PATCH 1/2] ib_cm: cm_destroy_id() cleanup
> >
> > Am Dienstag, den 18.07.2006, 06:59 -0700 schrieb Roland Dreier:
> > > > + cm_destroy_id(&cm_id_priv-
> > Would you consider pushing these to 2.6.18? If so, I'd happily provide
> > patches against rc1 or your git tree.
> Well, Sean is the judge here, but what's the motivation for this patch?
Yes, exactly.
Also, after looking at this, it seems like there must be a better way
to get the CM to s
Quoting r. Arne Redlich <[EMAIL PROTECTED]>:
> Subject: Re: [PATCH 1/2] ib_cm: cm_destroy_id() cleanup
>
> Am Dienstag, den 18.07.2006, 06:59 -0700 schrieb Roland Dreier:
> > > +cm_destroy_id(&cm_id_priv->id, (ret == -ENOMEM) ? 0 :
> > 1);
> >
> > This is rather obfuscated. How
Am Dienstag, den 18.07.2006, 06:59 -0700 schrieb Roland Dreier:
> > + cm_destroy_id(&cm_id_priv->id, (ret == -ENOMEM) ? 0 : 1);
>
> This is rather obfuscated. How about just
>
> cm_destroy_id(&cm_id_priv->id, ret != -ENOMEM);
>
> - R.
Sure. Fixed below for your conveni
> +cm_destroy_id(&cm_id_priv->id, (ret == -ENOMEM) ? 0 : 1);
This is rather obfuscated. How about just
cm_destroy_id(&cm_id_priv->id, ret != -ENOMEM);
- R.
___
openib-general mailing list
openib-general@openib.org
http:/
In its current incarnation, cm_destroy_id() will not send a REJ if fed a
magic number (err = -ENOMEM). This patch replaces this magic number with
a more generic "reject" parameter.
Signed-off-by: Arne Redlich <[EMAIL PROTECTED]>
Index: infiniband/core/cm.c
===
