Re: [openib-general] [PATCHv5] osm: partition manager force policy

2006-06-21 Thread Hal Rosenstock
Hi Eitan, On Wed, 2006-06-21 at 02:10, Eitan Zahavi wrote: > Hi Hal, > > Thanks for applying the patch. > > Regarding the issues : > > Hal Rosenstock wrote: > >>+ > >>+ CL_ASSERT( p_pkey_tbl ); > > > > > > Should the other routines also assert on this or should this be > > consistent with t

Re: [openib-general] [PATCHv5] osm: partition manager force policy

2006-06-20 Thread Eitan Zahavi
Hi Hal, Thanks for applying the patch. Regarding the issues : Hal Rosenstock wrote: >>+ >>+ CL_ASSERT( p_pkey_tbl ); > > > Should the other routines also assert on this or should this be > consistent with the others ? Yes it should b consistent. Normally I add assertion on OUT parameters s

Re: [openib-general] [PATCHv5] osm: partition manager force policy

2006-06-20 Thread Hal Rosenstock
On Mon, 2006-06-19 at 15:05, Eitan Zahavi wrote: > Hi Hal > > This is a 5th take after incorporating Sasha's last reported bug > on bad assignment of the used_blocks. > > This code was run again through my verification flow and also Sasha > had run some tests too. > > Eitan > > Signed-off-by:

[openib-general] [PATCHv5] osm: partition manager force policy

2006-06-19 Thread Eitan Zahavi
Hi Hal This is a 5th take after incorporating Sasha's last reported bug on bad assignment of the used_blocks. This code was run again through my verification flow and also Sasha had run some tests too. Eitan Signed-off-by: Eitan Zahavi <[EMAIL PROTECTED]> Index: include/opensm/osm_port.h ===