Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-13 Thread Or Gerlitz
On 11/13/06, Roland Dreier <[EMAIL PROTECTED]> wrote: > > This is a bug since there are architectures eg PPC64 where the native > > address size is u64 but dma_addr_t is u32. You are somehow in a > > problem here, since returning an unchopped cpu_addr to the consumer > > might cause a memory co

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-13 Thread Roland Dreier
...although one has to think through the implications for pci_unmap_addr_set() I guess... ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-13 Thread Roland Dreier
> This is a bug since there are architectures eg PPC64 where the native > address size is u64 but dma_addr_t is u32. You are somehow in a > problem here, since returning an unchopped cpu_addr to the consumer > might cause a memory corruption as they are expecting 32 bit value. Yes (although pp

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-12 Thread Muli Ben-Yehuda
On Thu, Nov 02, 2006 at 02:30:26PM -0800, Ralph Campbell wrote: > +static dma_addr_t ipath_dma_map_single(struct ib_device *dev, > +void *cpu_addr, size_t size, > +enum dma_data_direction direction) > +{ > + BUG_ON(directi

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-11 Thread Or Gerlitz
Ralph Campbell wrote: > IB/ipath - Implement new verbs DMA mapping functions > > This patch implements the interposing DMA mapping functions to allow > support for IOMMUs and remove the dependence on phys_to_virt(). > diff -r f37bd0e41fec drivers/infiniband/hw/ipath/ipath_dma.c > --- /dev/null Th

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-03 Thread James Lentini
On Fri, 3 Nov 2006, Ralph Campbell wrote: > On Fri, 2006-11-03 at 12:54 -0500, James Lentini wrote: > > Ralph, > > > > Could you add documentation to Documentation/infiniband/ explainin > > when a ULP needs to use the new verbs DMA mapping functions (what > > structures/function parameters mu

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-03 Thread Ralph Campbell
On Fri, 2006-11-03 at 12:54 -0500, James Lentini wrote: > Ralph, > > Could you add documentation to Documentation/infiniband/ explainin > when a ULP needs to use the new verbs DMA mapping functions (what > structures/function parameters must be specified using this API)? Good idea. I will. >

Re: [openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-03 Thread James Lentini
Ralph, Could you add documentation to Documentation/infiniband/ explainin when a ULP needs to use the new verbs DMA mapping functions (what structures/function parameters must be specified using this API)? Did you consider creating a new type, ib_dma_addr_t, and using this type for the verb

[openib-general] IB/ipath - Implement new verbs DMA mapping functions

2006-11-02 Thread Ralph Campbell
IB/ipath - Implement new verbs DMA mapping functions This patch implements the interposing DMA mapping functions to allow support for IOMMUs and remove the dependence on phys_to_virt(). From: Ralph Campbell <[EMAIL PROTECTED]> diff -r f37bd0e41fec drivers/infiniband/hw/ipath/Makefile --- a/drive