[openib-general] Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option

2005-01-19 Thread YOSHIFUJI Hideaki / $B5HF#1QL@(B
In article <[EMAIL PROTECTED]> (at Wed, 19 Jan 2005 13:19:55 +0530), Krishna Kumar <[EMAIL PROTECTED]> says: > Couple of minor comments on this : : > 3. I guess there is no clean way to avoid changing all consumers of ll_addr > to not worry > about the padding after the length and before the

[openib-general] Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option

2005-01-19 Thread Vivek Kashyap
I suggest that the implementation discussion not be reflected on ipoverib. I've bcc'd to ipoverib for this mail. Those interested in the details can follow it on netdev/openib. Thanks, Vivek On Wed, 19 Jan 2005, Krishna Kumar wrote: > > > > > > Hi Roland, > > Couple of minor comm

[openib-general] Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option

2005-01-18 Thread Krishna Kumar
(BHi Roland, (B (BCouple of minor comments on this : (B (B1 : In  "+static int ndisc_addr_option_pad(unsigned short type)", change the function (B name to ndisc_lladdr_option_pad() and the argument name to addr_type, to be (B more precise ? addr_option seems confusing, unless it is

[openib-general] Re: [Ipoverib] [PATCH] IPv6: Add correct padding to IPoIB link addr option

2005-01-18 Thread YOSHIFUJI Hideaki / $B5HF#1QL@(B
David, let me tkink about this. Thanks. In article <[EMAIL PROTECTED]> (at Tue, 18 Jan 2005 09:33:47 -0800), Roland Dreier <[EMAIL PROTECTED]> says: > +++ linux-bk/net/ipv6/ndisc.c 2005-01-14 21:20:55.736745091 -0800 > @@ -169,12 +169,33 @@ > > #define NDISC_OPT_SPACE(len) (((len)+2+7)&~7) >