[openib-general] Re: [PATCH] osm: support for trivial PKey manager

2006-03-01 Thread Hal Rosenstock
Hi Ofer, On Wed, 2006-03-01 at 08:42, Ofer Gigi wrote: Hi Hal, Please add an empty file management/osm/include/opensm/osm_svn_revision.h This file is needed since during the build process we write into it the revision. When the file doesn't exists the writing fails. What svn version

Re: [openib-general] Re: [PATCH] osm: support for trivial PKey manager

2006-03-01 Thread Bernhard Fischer
On Wed, Mar 01, 2006 at 08:54:41AM -0500, Hal Rosenstock wrote: Hi Ofer, On Wed, 2006-03-01 at 08:42, Ofer Gigi wrote: Hi Hal, Please add an empty file management/osm/include/opensm/osm_svn_revision.h This file is needed since during the build process we write into it the revision.

[openib-general] Re: [PATCH] osm: support for trivial PKey manager

2006-01-10 Thread Hal Rosenstock
On Tue, 2006-01-10 at 09:51, Ofer Gigi wrote: Hi Hal, Removing redundant error in the log. If the physical port is not valid, nothing is needed to be the done here. Thanks. Applied. ___ openib-general mailing list openib-general@openib.org

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2006-01-03 Thread Hal Rosenstock
On Sun, 2006-01-01 at 03:14, Ofer Gigi wrote: Hi Hal, 1. About the osm_indent - you are correct - it should have been in another patch. Thanks. Applied. 2. Extra spaces - please remove - thanks. Done. 3. + /* signal = osm_lid_mgr_process_sm( p_mgr-p_lid_mgr ); */ Why add this

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2006-01-01 Thread Ofer Gigi
Hi Hal, 1. About the osm_indent - you are correct - it should have been in another patch. 2. Extra spaces - please remove - thanks. 3. + /* signal = osm_lid_mgr_process_sm( p_mgr-p_lid_mgr ); */ Why add this commented out line ? My mistake, I commented the original code and forgot to remove

[openib-general] Re: [PATCH] osm: support for trivial PKey manager

2005-12-30 Thread Hal Rosenstock
Hi again Ofer, On Thu, 2005-12-29 at 05:20, Ofer Gigi wrote: Hi Hal, My name is Ofer Gigi, and I am a new software engineer in Mellanox working on OpenSM. This patch provides a new manager that solves the following problem: OpenSM is not currently compliant to the spec statement:

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Ofer Gigi
Hi Hal, Every time, between the stages of Heavy Sweep and Set Ucast Lids, the stage of the PKey Manager is done. During this stage, the SM goes through its database and verifies that each valid physical port has either 0x7fff (IB_DEFAULT_PARTIAL_PKEY) or 0x (IB_DEFAULT_PKEY). If it does have,

[openib-general] Re: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Hal Rosenstock
Hi Ofer, On Thu, 2005-12-29 at 05:20, Ofer Gigi wrote: Hi Hal, My name is Ofer Gigi, and I am a new software engineer in Mellanox working on OpenSM. This patch provides a new manager that solves the following problem: Thanks! I am starting to work on integrating this. I have a couple

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Ofer Gigi
Hi Hal, Sorry, I didn't see there are other questions below Here are the answers: 1. Might 0x7fff be better in this case ? As I said, currently all IB devices come up from reset with preconfigured 0x key. Since we don't want to be inconsistent, we decided to insert 0x. 2. Can you

[openib-general] RE: [PATCH] osm: support for trivial PKey manager

2005-12-29 Thread Hal Rosenstock
Hi again Ofer, On Thu, 2005-12-29 at 11:14, Ofer Gigi wrote: Hi Hal, Sorry, I didn't see there are other questions below Here are the answers: 1. Might 0x7fff be better in this case ? As I said, currently all IB devices come up from reset with preconfigured 0x key. Since we don't