> > That would make sense. Give it a non-ipath-related name and require that
> > all architectures which wish to run this driver must implement that
> > (documented) function.
> >
> > And, in Kconfig, make sure that architectures which don't implement that
> > library function do not attempt to b
On Sul, 2005-12-18 at 04:27 +0100, Andi Kleen wrote:
> Robert Walsh <[EMAIL PROTECTED]> writes:
> >
> > Any chance we could get these moved into the x86_64 arch directory,
> > then? We have to do double-word copies, or our chip gets unhappy.
>
> Standard memcpy will do double word copies if ever
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Sat, 17 Dec 2005 19:19:32 -0800
> That would make sense. Give it a non-ipath-related name and require that
> all architectures which wish to run this driver must implement that
> (documented) function.
>
> And, in Kconfig, make sure that architecture
On Sat, Dec 17, 2005 at 09:36:29PM -0800, Robert Walsh wrote:
> On Sun, 2005-12-18 at 04:27 +0100, Andi Kleen wrote:
> > Robert Walsh <[EMAIL PROTECTED]> writes:
> > >
> > > Any chance we could get these moved into the x86_64 arch directory,
> > > then? We have to do double-word copies, or our ch
On Sun, 2005-12-18 at 04:27 +0100, Andi Kleen wrote:
> Robert Walsh <[EMAIL PROTECTED]> writes:
> >
> > Any chance we could get these moved into the x86_64 arch directory,
> > then? We have to do double-word copies, or our chip gets unhappy.
>
> Standard memcpy will do double word copies if ever
> > Any chance we could get these moved into the x86_64 arch directory,
> > then?
>
> That would make sense. Give it a non-ipath-related name and require that
> all architectures which wish to run this driver must implement that
> (documented) function.
>
> And, in Kconfig, make sure that archit
On Sat, Dec 17, 2005 at 07:19:32PM -0800, Andrew Morton wrote:
>...
> In what form is this chip available? As a standard PCI/PCIX card which
> people will want to plug into power4/ia64/x86 machines? Or is it in some
> way exclusively tied to x86_64?
Hardware can hardly be exclusively tied to x86
Robert Walsh <[EMAIL PROTECTED]> writes:
>
> Any chance we could get these moved into the x86_64 arch directory,
> then? We have to do double-word copies, or our chip gets unhappy.
Standard memcpy will do double word copies if everything is suitably
aligned. Just use that.
-Andi
___
Robert Walsh <[EMAIL PROTECTED]> wrote:
>
> > > + movl %edx,%ecx
> > > + shrl $1,%ecx
> > > + andl $1,%edx
> > > + cld
> > > + rep
> > > + movsq
> > > + movl %edx,%ecx
> > > + rep
> > > + movsd
> > > + ret
> >
> > err, we have a portability problem.
>
> Any chance we could get these moved i
On Sat, 2005-12-17 at 12:38 -0800, Andrew Morton wrote:
> Roland Dreier <[EMAIL PROTECTED]> wrote:
> >
> > + .globl ipath_dwordcpy
> > +/* rdi destination, rsi source, rdx count */
> > +ipath_dwordcpy:
> > + movl %edx,%ecx
> > + shrl $1,%ecx
> > + andl $1,%edx
> > + cld
> > + re
On Sat, 2005-12-17 at 14:38 +0200, Pekka Enberg wrote:
> On 12/17/05, Roland Dreier <[EMAIL PROTECTED]> wrote:
> > +#define TRUE 1
> > +#define FALSE 0
>
> Please kill these.
OK.
--
Robert Walsh Email: [EMAIL PROTECTED]
PathScale, Inc.
Roland Dreier <[EMAIL PROTECTED]> wrote:
>
> + .globl ipath_dwordcpy
> +/* rdi destination, rsi source, rdx count */
> +ipath_dwordcpy:
> + movl %edx,%ecx
> + shrl $1,%ecx
> + andl $1,%edx
> + cld
> + rep
> + movsq
> + movl %edx,%ecx
> + rep
> + m
On Fri, Dec 16, 2005 at 03:48:54PM -0800, Roland Dreier wrote:
> Copy routines for ipath driver
NACK, assembler copy routines don't belong into drivers.
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-
On 12/17/05, Roland Dreier <[EMAIL PROTECTED]> wrote:
> +#define TRUE 1
> +#define FALSE 0
Please kill these.
Pekka
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
14 matches
Mail list logo