Re: [openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Ronald G. Minnich
On Tue, 28 Jun 2005, Greg KH wrote: > On Tue, Jun 28, 2005 at 04:03:43PM -0700, Roland Dreier wrote: > > +++ linux/drivers/infiniband/core/uverbs_main.c 2005-06-28 > > 15:20:04.363963991 -0700 > > @@ -0,0 +1,708 @@ > > +/* > > + * Copyright (c) 2005 Topspin Communications. All rights reser

[openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Greg KH
On Wed, Jun 29, 2005 at 10:01:53AM -0700, Roland Dreier wrote: > Greg> This is no longer needed with the class device interface in > Greg> the kernel today. Please use the new api (basically just > Greg> set dev_t in the class_device, and you get this for free.) > > Here's a patch tha

[openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Roland Dreier
Greg> This is no longer needed with the class device interface in Greg> the kernel today. Please use the new api (basically just Greg> set dev_t in the class_device, and you get this for free.) Here's a patch that applies on top of this patch set that fixes this: Greg KH pointed out

Re: [openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Troy Benjegerdes
On Wed, Jun 29, 2005 at 09:12:09AM -0700, Greg KH wrote: > On Tue, Jun 28, 2005 at 11:13:22PM -0500, Troy Benjegerdes wrote: > > On Tue, Jun 28, 2005 at 05:27:09PM -0700, Greg KH wrote: > > > On Tue, Jun 28, 2005 at 04:03:43PM -0700, Roland Dreier wrote: > > > > +++ linux/drivers/infiniband/core/uv

Re: [openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Greg KH
On Tue, Jun 28, 2005 at 11:13:22PM -0500, Troy Benjegerdes wrote: > On Tue, Jun 28, 2005 at 05:27:09PM -0700, Greg KH wrote: > > On Tue, Jun 28, 2005 at 04:03:43PM -0700, Roland Dreier wrote: > > > +++ linux/drivers/infiniband/core/uverbs_main.c 2005-06-28 > > > 15:20:04.363963991 -0700 > > > @@

[openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-29 Thread Roland Dreier
Greg> This is no longer needed with the class device interface in Greg> the kernel today. Please use the new api (basically just Greg> set dev_t in the class_device, and you get this for free.) Thanks, I've killed that code and just set class_dev.devt instead. - R. _

Re: [openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-28 Thread Troy Benjegerdes
On Tue, Jun 28, 2005 at 05:27:09PM -0700, Greg KH wrote: > On Tue, Jun 28, 2005 at 04:03:43PM -0700, Roland Dreier wrote: > > +++ linux/drivers/infiniband/core/uverbs_main.c 2005-06-28 > > 15:20:04.363963991 -0700 > > @@ -0,0 +1,708 @@ > > +/* > > + * Copyright (c) 2005 Topspin Communications.

Re: [openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-28 Thread Tom Duffy
On Tue, 2005-06-28 at 17:27 -0700, Greg KH wrote: > Ok, I've complained about this before, but due to the fact that you are > calling EXPORT_SYMBOL_GPL() only functions in this code, the ability for > it for someone to use the BSD license on it in the future, is pretty > much impossible, right? No

[openib-general] Re: [PATCH 05/16] IB uverbs: core implementation

2005-06-28 Thread Greg KH
On Tue, Jun 28, 2005 at 04:03:43PM -0700, Roland Dreier wrote: > +++ linux/drivers/infiniband/core/uverbs_main.c 2005-06-28 > 15:20:04.363963991 -0700 > @@ -0,0 +1,708 @@ > +/* > + * Copyright (c) 2005 Topspin Communications. All rights reserved. > + * Copyright (c) 2005 Cisco Systems. All