Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Jason Gunthorpe
On Mon, Mar 06, 2006 at 04:05:30PM -0800, Bryan O'Sullivan wrote: > Depends on the driver. Ours needs the interrupt vector rather than the > number, which means we don't work without CONFIG_PCI_MSI. That is, > unless there's some other way to get the vector that I don't know about > (entirely li

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 06 Mar 2006 15:40:56 -0800 > and 32 threads are probably good for flushing out SMP races. Indeed, guess what I've been spending most of my time working on lately? :) ___ openib-general mailing list open

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
Bryan> Depends on the driver. Ours needs the interrupt vector Bryan> rather than the number, which means we don't work without Bryan> CONFIG_PCI_MSI. That is, unless there's some other way to Bryan> get the vector that I don't know about (entirely likely). OK, fair enough. But t

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Bryan O'Sullivan
On Mon, 2006-03-06 at 15:40 -0800, Roland Dreier wrote: > Anyway IB works fine with standard INTx interrupts -- MSI is just icing. Depends on the driver. Ours needs the interrupt vector rather than the number, which means we don't work without CONFIG_PCI_MSI. That is, unless there's some other

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
Roland> I should look into getting some niagara machines to test Roland> with -- with PCIe slots they should actually be good for Roland> IB testing. David> You'll be cpu limited until we have Van Jacobson net David> channels. For IPoIB maybe but not for native IB which offloa

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 06 Mar 2006 14:41:21 -0800 > I should look into getting some niagara machines to test with -- with > PCIe slots they should actually be good for IB testing. You'll be cpu limited until we have Van Jacobson net channels. Also, since our existing

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
David> I wrote a test program and it looks ok: Cool, thanks. I should look into getting some niagara machines to test with -- with PCIe slots they should actually be good for IB testing. - R. ___ openib-general mailing list openib-general@openib.o

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 06 Mar 2006 14:32:28 -0800 > The fundamental question seems to be whether things like > > struct foo { > struct sockaddr_in6 src; > struct sockaddr_in6 dst; > }; > > and > > struct bar { >

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
David> Please make sure you check "x86_64 vs. x86", and then David> something like "powerpc64 vs. powerpc32" or "sparc64 David> vs. sparc32", as those are the two different classes of ABI David> layouts. Yes, I tried ppc64 vs ppc and it still comes out the same. Unfortunately I don

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 06 Mar 2006 13:58:32 -0800 > Sean> Unless I miss counted, they should be aligned. > Sean> ib_user_path_rec is defined near the end of patch 1/6. > > You're right. struct sockaddr_in6 is 28 bytes long (not a multiple of > 8) but gcc seems

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
Sean> Unless I miss counted, they should be aligned. Sean> ib_user_path_rec is defined near the end of patch 1/6. You're right. struct sockaddr_in6 is 28 bytes long (not a multiple of 8) but gcc seems to lay everything out the same on 32-bit and 64-bit architectures just the same. - R.

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Roland Dreier wrote: On the other hand I think it would be good to let this userspace interface cook a little more, say in -mm. I think that this makes sense. - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Roland Dreier wrote: > +struct rdma_ucm_query_route_resp { > + __u64 node_guid; > + struct ib_user_path_rec ib_route[2]; > + struct sockaddr_in6 src_addr; > + struct sockaddr_in6 dst_addr; > + __u32 num_paths; > + __u8 port_num; > + __u8 reserved[3]; > +}; Is there a 32-bit/64-bit compa

[openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
I think it makes sense to merge patches 1-5 independently of this patch. The kernel interface is needed by iSER and NFS/RDMA, and maintaining compatibility isn't a huge deal, so we can merge it now (assuming it looks mergable). On the other hand I think it would be good to let this userspace inte

[openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
> +struct rdma_ucm_query_route_resp { > +__u64 node_guid; > +struct ib_user_path_rec ib_route[2]; > +struct sockaddr_in6 src_addr; > +struct sockaddr_in6 dst_addr; > +__u32 num_paths; > +__u8 port_num; > +__u8 reserved[3]; > +}; Is there a 32-bit/64-bit compati