Michael> Not sure what changed - I thought new multicast has same
Michael> API. I'd have to review the code again then - we had lot
Michael> of subtle bugs in this area ...
Yes, that was my though too: why does the new multicast handling end
up scheduling the multicast join task again
Michael S. Tsirkin wrote:
Not sure what changed - I thought new multicast has same API.
I'd have to review the code again then - we had lot of subtle bugs in
this area ...
The new multicast module won't go into 2.6.17.
- Sean
___
openib-general mail
Quoting r. Roland Dreier <[EMAIL PROTECTED]>:
> Subject: Re: [RFC] [PATCH 2/2 v2] ipoib: convert to use new multicast
> interface
>
> Michael> Hmm, but this seems like 2.6.17 material. It should have
> Michael> the same effect with or without multicast group
> Michael> patch. Right?
Michael> Hmm, but this seems like 2.6.17 material. It should have
Michael> the same effect with or without multicast group
Michael> patch. Right?
I don't think so. With the current code, it shouldn't be possible to
get to that line with a join of the broadcast group pending.
- R.
_
Michael S. Tsirkin wrote:
void ipoib_mcast_join_task(void *dev_ptr)
@@ -553,7 +539,8 @@ void ipoib_mcast_join_task(void *dev_ptr
spin_unlock_irq(&priv->lock);
}
- if (!test_bit(IPOIB_MCAST_FLAG_ATTACHED, &priv->broadcast->flags)) {
+ if (!test_bit(IPOIB_MCAST_
Quoting r. Sean Hefty <[EMAIL PROTECTED]>:
> Subject: Re: [RFC] [PATCH 2/2 v2] ipoib: convert to use new multicast
> interface
>
> Sean Hefty wrote:
> > void ipoib_mcast_join_task(void *dev_ptr)
> >@@ -553,7 +539,8 @@ void ipoib_mcast_join_task(void *dev_ptr
> > spin_unlock_irq(&priv-
