Shirley> Hello Roland, Is there any particular reason to use
Shirley> ipoib_reap_ah thread?
Shirley> In my tx_ring removal patch, I tested without
Shirley> ipoib_reap_ah work queue by simply adding kref_get(),
Shirley> kref_put() in ipoib_send(), and i didn't see any
Shirle
Roland Dreier <[EMAIL PROTECTED]> wrote on 05/22/2006
09:58:13 AM:
> I think you should keep your patches simple --
"one idea per patch."
> So if you want to experiment with both tx_ring removal and the reap_ah
> removal, keep in mind that they should be merged as separate patches.
> So you should
Shirley> I will, thanks. If I seperate these two patches I will
Shirley> have to use last_send as atomic_t in tx_ring removal.
Why? And how does it help? ipoib never does any arithmetic on
last_send so I don't see what changing it to atomic_t accomplishes.
- R.
