Re: [openib-general] [PATCH 5/6] iser RDMA CM (CMA) and IB verbsinteraction

2006-05-01 Thread Or Gerlitz
Sean Hefty wrote: +static void iser_disconnected_handler(struct rdma_cm_id *cma_id) +{ + struct iser_conn *ib_conn; + + ib_conn = (struct iser_conn *)cma_id->context; + ib_conn->disc_evt_flag = 1; + + /* If this event is unsolicited this means that the conn is being */ +

Re: [openib-general] [PATCH 5/6] iser RDMA CM (CMA) and IB verbsinteraction

2006-05-01 Thread Or Gerlitz
Sean Hefty wrote: +static int iser_free_device_ib_res(struct iser_device *device) Can you eliminate the return code? +struct iser_device *iser_device_find_by_ib_device(struct rdma_cm_id *cma_id) + if (device == NULL) + goto end; goto out; // see belo

Re: [openib-general] [PATCH 5/6] iser RDMA CM (CMA) and IB verbsinteraction

2006-04-30 Thread Or Gerlitz
Sean Hefty wrote: +static int iser_free_device_ib_res(struct iser_device *device) +{ + BUG_ON(device->mr == NULL); + + tasklet_kill(&device->cq_tasklet); + + (void)ib_dereg_mr(device->mr); + (void)ib_destroy_cq(device->cq); + (void)ib_dealloc_pd(device->pd); + +

RE: [openib-general] [PATCH 5/6] iser RDMA CM (CMA) and IB verbsinteraction

2006-04-28 Thread Sean Hefty
>+static int iser_free_device_ib_res(struct iser_device *device) >+{ >+ BUG_ON(device->mr == NULL); >+ >+ tasklet_kill(&device->cq_tasklet); >+ >+ (void)ib_dereg_mr(device->mr); >+ (void)ib_destroy_cq(device->cq); >+ (void)ib_dealloc_pd(device->pd); >+ >+ device->mr =