RE: [openib-general] [RFC] [PATCH] mad: Add RMPP support for additionalmanagement classes

2006-03-17 Thread Hal Rosenstock
On Thu, 2006-03-16 at 23:09, Sean Hefty wrote: > > /** > >+ * ib_get_rmpp_data_offset - returns the data offset for a given > >+ * management class. > >+ * @mgmt_class: management class > >+ * > >+ * This routine returns the data offset in the MAD for the management > >+ * class requested. > >+ */

RE: [openib-general] [RFC] [PATCH] mad: Add RMPP support for additionalmanagement classes

2006-03-17 Thread Hal Rosenstock
On Thu, 2006-03-16 at 23:09, Sean Hefty wrote: > > /** > >+ * ib_get_rmpp_data_offset - returns the data offset for a given > >+ * management class. > >+ * @mgmt_class: management class > >+ * > >+ * This routine returns the data offset in the MAD for the management > >+ * class requested. > >+ */

Re: [openib-general] [RFC] [PATCH] mad: Add RMPP support for additionalmanagement classes

2006-03-16 Thread Roland Dreier
> > +int ib_get_rmpp_data_offset(u8 mgmt_class); > Maybe we should just make this an inline routine. It looks big enough that it's probably better not to inline (given that there are multiple call sites). - R. ___ openib-general mailing list openib-ge

RE: [openib-general] [RFC] [PATCH] mad: Add RMPP support for additionalmanagement classes

2006-03-16 Thread Sean Hefty
> /** >+ * ib_get_rmpp_data_offset - returns the data offset for a given >+ * management class. >+ * @mgmt_class: management class >+ * >+ * This routine returns the data offset in the MAD for the management >+ * class requested. >+ */ >+int ib_get_rmpp_data_offset(u8 mgmt_class); Maybe we should