In regard to: Re: [OpenIndiana-discuss] Fwd: 2nd round - Bug 1204 zoneadm...:
I would prefer the for ((; ; )) syntax over the x=0;while ... ; x=x+1
; done syntax because its IMHO more readable for people coming from C.
No offense intended, but shell is not C and trying to make a shell script
Ok, thank you for the review. Replies also inline below :)
On 2013-11-15 00:20, Cedric Blancher wrote:
The first thing I noticed is: Illumos has a POSIX shell but its not
used as such. Further comments are inline within the patch diff:
I was also confused by the different constructs being
On 15 November 2013 00:37, Jim Klimov jimkli...@cos.ru wrote:
Ok, thank you for the review. Replies also inline below :)
On 2013-11-15 00:20, Cedric Blancher wrote:
The first thing I noticed is: Illumos has a POSIX shell but its not
used as such. Further comments are inline within the patch
And some more replies below
On 2013-11-15 00:47, Cedric Blancher wrote:
On 15 November 2013 00:37, Jim Klimov jimkli...@cos.ru wrote:
--- /usr/lib/brand/ipkg/clone.orig 2011-09-12 15:01:44.0
+0400
+++ /usr/lib/brand/ipkg/clone 2013-11-13 05:31:27.756698164 +0400
@@ -45,9 +45,16
On 2013-11-15 00:47, Cedric Blancher wrote:
On 15 November 2013 00:37, Jim Klimov jimkli...@cos.ru wrote:
Ok, thank you for the review. Replies also inline below :)
Does this patch take care of all of your concerns (beside syntax
per se)?
