Re: [Openipmi-developer] [PATCH v3 00/16] ipmi: Allow raw access to KCS devices

2021-05-19 Thread Andrew Jeffery
Hi Corey, On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote: > Hello, > > This is the 3rd spin of the series refactoring the keyboard-controller-style > device drivers in the IPMI subsystem. > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > Cover letter: > https:/

Re: [Openipmi-developer] [PATCH v3 4/7] i2c: aspeed: Acknowledge Tx done w/wo ACK irq late

2021-05-19 Thread Guenter Roeck
On 5/19/21 4:43 PM, Joel Stanley wrote: On Wed, 19 May 2021 at 07:50, Quan Nguyen wrote: With Tx done w/wo ACK are ack'ed early at beginning of irq handler, Is w/wo a typo? If not, please write the full words ("with and without") it is observed that, usually, the Tx done with Ack irq raise

Re: [Openipmi-developer] [PATCH v3 4/7] i2c: aspeed: Acknowledge Tx done w/wo ACK irq late

2021-05-19 Thread Joel Stanley
On Wed, 19 May 2021 at 07:50, Quan Nguyen wrote: > > With Tx done w/wo ACK are ack'ed early at beginning of irq handler, Is w/wo a typo? If not, please write the full words ("with and without") > it is observed that, usually, the Tx done with Ack irq raises in the > READ REQUESTED state. This is

Re: [Openipmi-developer] [PATCH v3 3/7] i2c: aspeed: Fix unhandled Tx done with NAK

2021-05-19 Thread Joel Stanley
Ryan, can you please review this change? On Wed, 19 May 2021 at 07:50, Quan Nguyen wrote: > > It is observed that in normal condition, when the last byte sent by > slave, the Tx Done with NAK irq will raise. > But it is also observed that sometimes master issues next transaction > too quick while

Re: [Openipmi-developer] [PATCH v3 7/7] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

2021-05-19 Thread Rob Herring
On Wed, 19 May 2021 14:49:34 +0700, Quan Nguyen wrote: > Add device tree binding document for the Aspeed SSIF BMC driver. > > Signed-off-by: Quan Nguyen > --- > v3: > + Switched to use DT schema format [Rob] > > .../bindings/ipmi/aspeed-ssif-bmc.yaml| 33 +++ > 1 file

Re: [Openipmi-developer] [PATCH v3 0/7] Add Aspeed SSIF BMC driver

2021-05-19 Thread Corey Minyard
On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. > > v3: > + Switched binding doc to use DT schema format [Rob] > + Splited i

Re: [Openipmi-developer] [PATCH v3 2/7] ipmi: ssif_bmc: Add SSIF BMC driver

2021-05-19 Thread Corey Minyard
On Wed, May 19, 2021 at 02:49:29PM +0700, Quan Nguyen wrote: > The SMBus system interface (SSIF) IPMI BMC driver can be used to perform > in-band IPMI communication with their host in management (BMC) side. > > Signed-off-by: Quan Nguyen > --- > v3: > + Removed redundant license info [Joel] >

[Openipmi-developer] [PATCH v3 3/7] i2c: aspeed: Fix unhandled Tx done with NAK

2021-05-19 Thread Quan Nguyen via Openipmi-developer
It is observed that in normal condition, when the last byte sent by slave, the Tx Done with NAK irq will raise. But it is also observed that sometimes master issues next transaction too quick while the slave irq handler is not yet invoked and Tx Done with NAK irq of last byte of previous READ PROCE

[Openipmi-developer] [PATCH v3 2/7] ipmi: ssif_bmc: Add SSIF BMC driver

2021-05-19 Thread Quan Nguyen via Openipmi-developer
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. Signed-off-by: Quan Nguyen --- v3: + Removed redundant license info [Joel] + Switched to use traditional if-else [Joel] + Removed unused ssif_bmc_ioc

[Openipmi-developer] [PATCH v3 1/7] i2c: i2c-core-smbus: Expose PEC calculate function for generic use

2021-05-19 Thread Quan Nguyen via Openipmi-developer
Expose the PEC calculation i2c_smbus_pec() for generic use. Signed-off-by: Quan Nguyen --- drivers/i2c/i2c-core-smbus.c | 12 ++-- include/linux/i2c.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbu

[Openipmi-developer] [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy()

2021-05-19 Thread Quan Nguyen via Openipmi-developer
Slave i2c device on AST2500 received a lot of slave irq while it is busy processing the response. To handle this case, adds and exports aspeed_set_slave_busy() for controller to temporary stop slave irq while slave is handling the response, and re-enable them again when the response is ready. Sign

[Openipmi-developer] [PATCH v3 7/7] bindings: ipmi: Add binding for Aspeed SSIF BMC driver

2021-05-19 Thread Quan Nguyen via Openipmi-developer
Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- v3: + Switched to use DT schema format [Rob] .../bindings/ipmi/aspeed-ssif-bmc.yaml| 33 +++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bi

[Openipmi-developer] [PATCH v3 6/7] ipmi: ssif_bmc: Add Aspeed SSIF BMC driver

2021-05-19 Thread Quan Nguyen via Openipmi-developer
This commits adds SSIF BMC driver specifically for Aspeed AST2500 which commonly used as Board Management Controllers. Signed-off-by: Quan Nguyen --- v3: + Splited into separate commit [Corey, Joel] + Invoked aspeed-specific aspeed_set_slave_busy() when busy to address deadlock from Graeme an

[Openipmi-developer] [PATCH v3 0/7] Add Aspeed SSIF BMC driver

2021-05-19 Thread Quan Nguyen via Openipmi-developer
This series add support for the Aspeed specific SSIF BMC driver which is to perform in-band IPMI communication with the host in management (BMC) side. v3: + Switched binding doc to use DT schema format [Rob] + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] + Removed redundan

[Openipmi-developer] [PATCH v3 4/7] i2c: aspeed: Acknowledge Tx done w/wo ACK irq late

2021-05-19 Thread Quan Nguyen via Openipmi-developer
With Tx done w/wo ACK are ack'ed early at beginning of irq handler, it is observed that, usually, the Tx done with Ack irq raises in the READ REQUESTED state. This is unexpected and complaint as below appear: "Unexpected Ack on read request" Assumed that Tx done should only be ack'ed once it was t