[Openipmi-developer] [PATCH v7 2/3] bindings: ipmi: Add binding for SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
Add device tree binding document for the SSIF BMC driver. Signed-off-by: Quan Nguyen --- v7: + Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae] v6: + None v5: + None v4: + Fix warning with dt_binding_check [Rob] + Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan

[Openipmi-developer] [PATCH v7 3/3] i2c: aspeed: Assert NAK when slave is busy

2022-04-21 Thread Quan Nguyen via Openipmi-developer
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns -EBUSY, i2c controller should issue RxCmdLast command to assert NAK on the bus. Signed-off-by: Quan Nguyen --- v7: + None v6: + New introduced in v6 [Quan] drivers/i2c/busses/i2c-aspeed.c | 5 - 1 fi

[Openipmi-developer] [PATCH v7 0/3] Add SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
This series add support the SSIF BMC driver which is to perform in-band IPMI communication with their host in management (BMC) side. SSIF BMC driver in this series is tested with Aspeed AST2500. Discussion for v6: https://lkml.org/lkml/2022/3/10/340 v7: + Remove unnecessary del_timer() in resp

[Openipmi-developer] [PATCH v7 1/3] ipmi: ssif_bmc: Add SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. Thanks Dan for the copy_from_user() fix in the link below. Link: https://lore.kernel.org/linux-arm-kernel/20220310114119.13736-4-q...@os.amperecomputing.c

Re: [Openipmi-developer] [PATCH v7 0/3] Add SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
Added Krzysztof Kozlowski as I'm not aware of the email change - Quan On 22/04/2022 11:08, Quan Nguyen wrote: This series add support the SSIF BMC driver which is to perform in-band IPMI communication with their host in management (BMC) side. SSIF BMC driver in this series is tested with Aspee

Re: [Openipmi-developer] [PATCH v7 1/3] ipmi: ssif_bmc: Add SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
Added Krzysztof Kozlowski as I'm not aware of the email change - Quan On 22/04/2022 11:08, Quan Nguyen wrote: The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. Thanks Dan for the copy_from_user() fix in

Re: [Openipmi-developer] [PATCH v7 2/3] bindings: ipmi: Add binding for SSIF BMC driver

2022-04-21 Thread Quan Nguyen via Openipmi-developer
Added Krzysztof Kozlowski as I'm not aware of the email change - Quan On 22/04/2022 11:08, Quan Nguyen wrote: Add device tree binding document for the SSIF BMC driver. Signed-off-by: Quan Nguyen --- v7: + Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae] v6: + None

Re: [Openipmi-developer] [PATCH v7 3/3] i2c: aspeed: Assert NAK when slave is busy

2022-04-21 Thread Quan Nguyen via Openipmi-developer
Added Krzysztof Kozlowski as I'm not aware of the email change - Quan On 22/04/2022 11:08, Quan Nguyen wrote: When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns -EBUSY, i2c controller should issue RxCmdLast command to assert NAK on the bus. Signed-off-by: Quan Nguyen --- v7:

Re: [Openipmi-developer] [PATCH] ipmi: remove unnecessary type castings

2022-04-21 Thread Corey Minyard
On Thu, Apr 21, 2022 at 08:09:41AM -0700, Yu Zhe wrote: > remove unnecessary void* type castings. Thanks, queued for next release. -corey > > Signed-off-by: Yu Zhe > --- > drivers/char/ipmi/ipmi_msghandler.c | 6 +++--- > drivers/char/ipmi/ipmi_ssif.c | 6 +++--- > 2 files changed, 6 in

[Openipmi-developer] [PATCH] ipmi: remove unnecessary type castings

2022-04-21 Thread Yu Zhe
remove unnecessary void* type castings. Signed-off-by: Yu Zhe --- drivers/char/ipmi/ipmi_msghandler.c | 6 +++--- drivers/char/ipmi/ipmi_ssif.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandle

Re: [Openipmi-developer] [PATCH] ipmi: ipmi_ipmb: Fix null-ptr-deref in ipmi_unregister_smi()

2022-04-21 Thread Corey Minyard
On Thu, Apr 21, 2022 at 10:08:35AM +, Wei Yongjun wrote: > KASAN report null-ptr-deref as follows: > > KASAN: null-ptr-deref in range [0x0008-0x000f] > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 > 04/01/2014 > RIP: 0010:ipmi_unregiste

[Openipmi-developer] [PATCH] ipmi: ipmi_ipmb: Fix null-ptr-deref in ipmi_unregister_smi()

2022-04-21 Thread Wei Yongjun via Openipmi-developer
KASAN report null-ptr-deref as follows: KASAN: null-ptr-deref in range [0x0008-0x000f] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 RIP: 0010:ipmi_unregister_smi+0x7d/0xd50 drivers/char/ipmi/ipmi_msghandler.c:3680 Call Trace: i