Re: [Openipmi-developer] [PATCH 1/9] hyperv: Convert from tasklet to BH workqueue

2024-04-03 Thread Allen
> The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to regular workqueues except that the queued work item

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Jarkko Sakkinen
On Wed Apr 3, 2024 at 11:06 AM EEST, Arnd Bergmann wrote: > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c > index 2ea4882251cf..0c453f3f928d 100644 > --- a/drivers/char/tpm/tpm_ftpm_tee.c > +++ b/drivers/char/tpm/tpm_ftpm_tee.c > @@ -362,7 +362,7 @@ MODULE_DEVICE_TA

Re: [Openipmi-developer] [PATCH 7/9] s390: Convert from tasklet to BH workqueue

2024-04-03 Thread Allen
> > > > Signed-off-by: Allen Pais > > --- > > drivers/s390/block/dasd.c | 42 > > drivers/s390/block/dasd_int.h | 10 +++--- > > drivers/s390/char/con3270.c| 27 > > drivers/s390/crypto/ap_bus.c | 24 +++

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Andy Shevchenko
On Wed, Apr 03, 2024 at 07:47:49AM -0500, Corey Minyard wrote: > On Wed, Apr 03, 2024 at 12:30:44PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann ... > > > I considered splitting up the large patch into per subsystem pa

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Corey Minyard
On Wed, Apr 03, 2024 at 12:30:44PM +0300, Andy Shevchenko wrote: > On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra > > warnings enabled, a lot of driver cause a warning about an u

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Corey Minyard
On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra > warnings enabled, a lot of driver cause a warning about an unused > ID table: > > drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unuse

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 10:06, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra > warnings enabled, a lot of driver cause a warning about an unused > ID table: > > drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unused variable > 'of_ftp

Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Andy Shevchenko
On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra > warnings enabled, a lot of driver cause a warning about an unused > ID table: > > drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unuse

[Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Arnd Bergmann
From: Arnd Bergmann When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra warnings enabled, a lot of driver cause a warning about an unused ID table: drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unused variable 'of_ftpm_tee_ids' [-Werror,-Wunused-const-variable] drivers/dma/i

[Openipmi-developer] [PATCH 00/34] address all -Wunused-const warnings

2024-04-03 Thread Arnd Bergmann
From: Arnd Bergmann Compilers traditionally warn for unused 'static' variables, but not if they are constant. The reason here is a custom for C++ programmers to define named constants as 'static const' variables in header files instead of using macros or enums. In W=1 builds, we get warnings onl