Re: [Openipmi-developer] [PATCH][next] char: ipmi: remove redundant variable 'type' and check

2025-07-08 Thread Corey Minyard
On Tue, Jul 08, 2025 at 04:18:05PM +0100, Colin Ian King wrote: > The variable 'type' is assigned the value SI_INVALID which is zero > and later checks of 'type' is non-zero (which is always false). The > variable is not referenced anywhere else, so it is redundant and > so is the check, so remove

[Openipmi-developer] [PATCH][next] char: ipmi: remove redundant variable 'type' and check

2025-07-08 Thread Colin Ian King
The variable 'type' is assigned the value SI_INVALID which is zero and later checks of 'type' is non-zero (which is always false). The variable is not referenced anywhere else, so it is redundant and so is the check, so remove these. Signed-off-by: Colin Ian King --- drivers/char/ipmi/ipmi_si_in