Cosmo found that when there is a new request comes in while BMC is
ready for a response, the complete_response(), which is called to
complete the pending response, would accidentally clear out that new
request and force ssif_bmc to move back to abort state again.
This commit is to address that iss
On 03/01/2025 20:01, Corey Minyard wrote:
On Fri, Jan 03, 2025 at 10:44:46AM +0700, Quan Nguyen wrote:
On 01/01/2025 23:54, Cosmo Chou wrote:
Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
the new command is not lost when complete_response() is triggered.
Thanks C
On 03/01/2025 10:20, Corey Minyard wrote:
On Thu, Jan 02, 2025 at 12:54:31AM +0800, Cosmo Chou wrote:
Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
the new command is not lost when complete_response() is triggered.
Ok, I see, patch is applied. Thank you.
Quan, I as
On 01/01/2025 23:54, Cosmo Chou wrote:
Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
the new command is not lost when complete_response() is triggered.
Thanks Cosmo for the catch.
And, IMHO, the root cause is the memset() on part buffer called in
complete_response(
On 19/11/2024 18:30, Corey Minyard wrote:
On Wed, Oct 23, 2024 at 11:30 PM Quan Nguyen
wrote:
On 22/10/2024 08:20, Potin Lai wrote:
From: Cosmo Chou
Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
the host when a response is ready.
This improves host-BMC communica
On 22/10/2024 08:20, Potin Lai wrote:
From: Cosmo Chou
Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
the host when a response is ready.
This improves host-BMC communication efficiency by providing immediate
notification, potentially reducing host polling overhead.
S
On 12/06/2024 11:32, Potin Lai wrote:
In ARM SBMR document, the host can chosse to not read back the response of
“Send Boot Progress Code” command.
Thanks for proposing a solution for the case.
As per my understanding from the ARM SBMR document, the "host can choose
not to read back the re
Ssif_bmc driver discards the current request if there is no response
provided until the new request comes, during that period, there are
multiple warning printed out as below:
"ipmi-ssif-host 0-0010: Warn: on_stop_event unexpected SLAVE STOP in
state=SSIF_ABORTING
ipmi-ssif-host 0-0010: Warn: on
This fixes the following sparse warning:
sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:left side has type
>> restricted __poll_t
>> drivers/char/ipmi/ssif_bmc.c:254:22: sp
On 14/10/2022 20:05, Graeme Gregory wrote:
On Mon, Oct 10, 2022 at 12:08:24PM +0100, Graeme Gregory wrote:
On 10/10/2022 02:28, Quan Nguyen wrote:
On 07/10/2022 20:26, Graeme Gregory wrote:
On 04/10/2022 10:31, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be
On 07/10/2022 20:26, Graeme Gregory wrote:
On 04/10/2022 10:31, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
Link:
Dear Wolfram,
Thank you for your patience with me through many versions.
Best regards,
- Quan
On 06/10/2022 02:06, Wolfram Sang wrote:
On Tue, Oct 04, 2022 at 04:31:06PM +0700, Quan Nguyen wrote:
On I2C_SLAVE_WRITE_REQUESTED event, Slave already ACK'ed on the address
phase. But as the backen
Dear Corey,
Thank you so much for helping me with all the comments and guidelines
you've shared though many versions.
Best regards,
- Quan
On 06/10/2022 06:53, Corey Minyard wrote:
On Tue, Oct 04, 2022 at 04:31:03PM +0700, Quan Nguyen wrote:
This series add support the SSIF BMC driver which
On I2C_SLAVE_WRITE_REQUESTED event, Slave already ACK'ed on the address
phase. But as the backend driver is busy and unable to process any
request from Master, issue RxCmdLast for Slave to auto send NACK on
next incoming byte.
Signed-off-by: Quan Nguyen
---
v10:
+ Issuing RxCmdLast command for
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
Link:
https://lore.kernel.org/linux-arm-kernel/20220310114119.13736-4-q...@os.amperecomputing.c
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
Reviewed-by: Rob Herring
---
v10:
+ None
v9:
+ Update missing Reviewed-by tag from v7 [Rob]
v8:
+ None
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500 and AST2600
Discussion for v9:
https://lore.kernel.org/lkml/20220929080326.752907-1-q...@os.amperecompu
On 02/10/2022 05:55, Wolfram Sang wrote:
+ if (ret == -EBUSY)
Since we documented this:
"+ 'ret': 0 if the backend is ready, otherwise some errno"
the code above should be '(ret < 0)'
Will update.
Thanks a lot for the review.
- Quan
__
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
Reviewed-by: Rob Herring
---
v9:
+ Update missing Reviewed-by tag from v7 [Rob]
v8:
+ None
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
v6:
+ None
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500 and AST2600
Discussion for v8:
https://lore.kernel.org/linux-arm-kernel/20220615090259.1121405-1-q...@o
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
Link:
https://lore.kernel.org/linux-arm-kernel/20220310114119.13736-4-q...@os.amperecomputing.c
On I2C_SLAVE_WRITE_REQUESTED event, Slave already ACK'ed on the address
phase. But as the backend driver is busy and unable to process any
request from Master, issue RxCmdLast for Slave to auto send NACK on
next incoming byte.
Signed-off-by: Quan Nguyen
---
v9:
+ Update commit message and add c
On 17/06/2022 14:08, Quan Nguyen wrote:
On 16/06/2022 19:29, Wolfram Sang wrote:
Hi Quan,
On the first occurrence of I2C_SLAVE_WRITE_REQUESTED, the address is
already
received with ACK. So if slave return -EBUSY, the NAK will occur on
the next
Rx byte (on I2C_SLAVE_WRITE_RECEIVED event).
On 28/06/2022 05:00, Rob Herring wrote:
On Wed, Jun 15, 2022 at 04:02:58PM +0700, Quan Nguyen wrote:
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v8:
+ None
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
v6:
On 16/06/2022 17:47, Ryan Chen wrote:
Hello Nquyen,
-Original Message-
From: Linux-aspeed
On
Behalf Of Quan Nguyen
Sent: Wednesday, June 15, 2022 5:03 PM
To: Quan Nguyen ; Corey Minyard
; Rob Herring ; Krzysztof Kozlowski
; Brendan Higgins
; Benjamin Herrenschmidt
; Joel Stanley ; Andr
On 17/06/2022 03:47, Christophe JAILLET wrote:
Le 15/06/2022 à 11:02, Quan Nguyen a écrit :
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
L
On 16/06/2022 19:29, Wolfram Sang wrote:
Hi Quan,
On the first occurrence of I2C_SLAVE_WRITE_REQUESTED, the address is already
received with ACK. So if slave return -EBUSY, the NAK will occur on the next
Rx byte (on I2C_SLAVE_WRITE_RECEIVED event).
This is exactly why I2C_SLAVE_WRITE_RECEIVED
On 15/06/2022 23:06, Randy Dunlap wrote:
On 6/15/22 02:02, Quan Nguyen wrote:
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index b061e6b513ed..18a89093d64e 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BM
On 16/06/2022 03:32, Wolfram Sang wrote:
Hi Quan,
When tested with ast2500, it is observed that there's always a
I2C_SLAVE_WRITE_REQUESTED comes first then other I2C_SLAVE_WRITE_RECEIVED's
follow for all transactions.
Yes, that's the design of the interface :)
In case slave is busy, the NAK
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v8:
+ None
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
v6:
+ None
v5:
+ None
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
Link:
https://lore.kernel.org/linux-arm-kernel/20220310114119.13736-4-q...@os.amperecomputing.c
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500.
Discussion for v7: https://lkml.org/lkml/2022/4/22/4
v8:
+ Dropped ssif_bmc.h file and move its con
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
-EBUSY, i2c controller should issue RxCmdLast command to assert NAK
on the bus.
Signed-off-by: Quan Nguyen
---
v7 -> v8:
+ None
v6:
+ New introduced in v6 [Quan]
drivers/i2c/busses/i2c-aspeed.c | 5 -
On 02/06/2022 07:32, Corey Minyard wrote:
On Wed, Jun 01, 2022 at 03:23:11PM +0700, Quan Nguyen wrote:
On 04/05/2022 19:06, Corey Minyard wrote:
On Wed, May 04, 2022 at 01:45:03PM +0700, Quan Nguyen via Openipmi-developer
wrote:
I seem to remember mentioning this before, but there is no
On 04/05/2022 19:06, Corey Minyard wrote:
On Wed, May 04, 2022 at 01:45:03PM +0700, Quan Nguyen via Openipmi-developer
wrote:
I seem to remember mentioning this before, but there is no reason to
pack the structures below.
The packed structure is because we want to pick the len directly
On 14/05/2022 21:31, Wolfram Sang wrote:
On Fri, Apr 22, 2022 at 11:08:03AM +0700, Quan Nguyen wrote:
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
-EBUSY, i2c controller should issue RxCmdLast command to assert NAK
on the bus.
That should be I2C_SLAVE_WRITE_RECEIVED and it
On 23/04/2022 08:51, Corey Minyard wrote:
On Fri, Apr 22, 2022 at 11:08:01AM +0700, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the lin
My apology, Krzysztof.
This patchset was rebased with the tag next-20220421.
And it was my fault actually.
I was using last revision's recipient list after compare recipient names
with the output of get_maintainer.pl to make sure everyone included. But
I missed that your email @canonical.com
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
v6:
+ None
v5:
+ None
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
-EBUSY, i2c controller should issue RxCmdLast command to assert NAK
on the bus.
Signed-off-by: Quan Nguyen
---
v7:
+ None
v6:
+ New introduced in v6 [Quan]
drivers/i2c/busses/i2c-aspeed.c | 5 -
1 fi
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500.
Discussion for v6: https://lkml.org/lkml/2022/3/10/340
v7:
+ Remove unnecessary del_timer() in resp
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in the link below.
Link:
https://lore.kernel.org/linux-arm-kernel/20220310114119.13736-4-q...@os.amperecomputing.c
Added Krzysztof Kozlowski
as I'm not aware of the email change
- Quan
On 22/04/2022 11:08, Quan Nguyen wrote:
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspee
Added Krzysztof Kozlowski
as I'm not aware of the email change
- Quan
On 22/04/2022 11:08, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks Dan for the copy_from_user() fix in
Added Krzysztof Kozlowski
as I'm not aware of the email change
- Quan
On 22/04/2022 11:08, Quan Nguyen wrote:
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
v6:
+ None
Added Krzysztof Kozlowski
as I'm not aware of the email change
- Quan
On 22/04/2022 11:08, Quan Nguyen wrote:
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
-EBUSY, i2c controller should issue RxCmdLast command to assert NAK
on the bus.
Signed-off-by: Quan Nguyen
---
v7:
On 17/03/2022 20:13, Corey Minyard wrote:
snip...
+
+static void response_timeout(struct timer_list *t)
+{
+ struct ssif_bmc_ctx *ssif_bmc = from_timer(ssif_bmc, t, response_timer);
+ unsigned long flags;
+
Is there a possible race here? The timeout can happen at the same time
On 11/03/2022 08:19, Corey Minyard wrote:
On Thu, Mar 10, 2022 at 06:41:16PM +0700, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Thanks for the update, and removing slave_enabl
On 15/03/2022 01:15, Jae Hyun Yoo wrote:
Hi Quan,
[...]
+static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8
*val)
+{
+ if (ssif_bmc->state == SSIF_READY ||
+ ssif_bmc->state == SSIF_START ||
+ ssif_bmc->state == SSIF_REQ_RECVING ||
+ ssif_bmc->stat
Added Dan as I have missed Dan's email address in the first place.
My apologize,
- Quan
On 11/03/2022 13:58, Wolfram Sang wrote:
On Thu, Mar 10, 2022 at 06:41:18PM +0700, Quan Nguyen wrote:
From: Dan Carpenter
The copy_from_user() function returns the number of bytes remaining to
be copied bu
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Signed-off-by: Quan Nguyen
---
v6:
+ Drop the use of slave_enable() [Wolfram]
+ Make i2c-aspeed to issue RxCmdLast command
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
Message-Id: <20210714033833.11640-4-q...@os.amperecomputing.com>
Reviewed-by: Rob Herring
Signed-off-by: Corey Minyard
---
v6:
+ None
v5:
+ None
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change
When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
-EBUSY, i2c controller should issue RxCmdLast command to assert NAK
on the bus.
Signed-off-by: Quan Nguyen
---
v6:
+ New introduced in v6 [Quan]
drivers/i2c/busses/i2c-aspeed.c | 5 -
1 file changed, 4
From: Dan Carpenter
The copy_from_user() function returns the number of bytes remaining to
be copied but we should return -EFAULT here.
Fixes: 501c25b59508 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by: Dan Carpenter
Signed-off-by: Corey Minyard
Signed-off-by: Quan Nguyen
---
v6:
+
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500.
Discussion for v5: https://lkml.org/lkml/2021/7/13/868
v6:
+ Drop the use of slave_enable()
On 30/11/2021 02:22, Wolfram Sang wrote:
Hi,
I still wonder if we can't get the SSIF BMC driver upstream...
Thanks Wolfram to help bring this up,
This driver was tested with Aspeed ast2500 and we have tried many way to
avoid using slave_enable() to toggle slave mode but there is no progress
On 16/07/2021 06:32, Corey Minyard wrote:
On Wed, Jul 14, 2021 at 10:38:30AM +0700, Quan Nguyen wrote:
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST250
On 16/07/2021 00:43, Rob Herring wrote:
On Wed, 14 Jul 2021 10:38:33 +0700, Quan Nguyen wrote:
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v5:
+ None
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-bmc.y
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v5:
+ None
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]
v3:
+ Switched to use DT schema format [Rob]
v2:
+ None
.../devicetree/bindings/ip
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Signed-off-by: Quan Nguyen
---
v5:
+ None
v4:
+ Send response with Completion code 0xFF when aborting [Quan]
+ Added bounding check on SMBus
Slave needs time to prepare the response data before Master could
enquiry via read transaction. However, there is no mechanism for
i2c-aspeed Slave to notify Master that it needs more time to process
and this make Master side to time out when trying to get the response.
This commit introduces the
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500.
v5:
+ Correct the patches order to fix the bisect issue found by
kernel build robot
v4:
+ Fix r
On 14/07/2021 07:17, Corey Minyard wrote:
On Wed, Jul 14, 2021 at 06:29:27AM +0700, Quan Nguyen wrote:
On 13/07/2021 22:44, Corey Minyard wrote:
On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
This series add support the SSIF BMC driver which is to perform in-band
IPMI communicati
On 13/07/2021 22:44, Corey Minyard wrote:
On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
Per the kernel build robot, looks like patch 3 introduces
Slave needs time to prepare the response data before Master could
enquiry via read transaction. However, there is no mechanism for
i2c-aspeed Slave to notify Master that it needs more time to process
and this make Master side to time out when trying to get the response.
This commit introduces the
Add device tree binding document for the SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]
v3:
+ Switched to use DT schema format [Rob]
v2:
+ None
.../devicetree/bindings/ipmi/ssif-bmc.yam
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Signed-off-by: Quan Nguyen
---
v4:
+ Send response with Completion code 0xFF when aborting [Quan]
+ Added bounding check on SMBus writes and th
This series add support the SSIF BMC driver which is to perform in-band
IPMI communication with their host in management (BMC) side.
SSIF BMC driver in this series is tested with Aspeed AST2500.
v4:
+ Fix recursive spinlock [Graeme]
+ Send response with Co
On 21/05/2021 13:09, Ryan Chen wrote:
-Original Message-
From: Quan Nguyen
Sent: Thursday, May 20, 2021 10:10 PM
To: Ryan Chen ; Corey Minyard
; Rob Herring ; Joel Stanley
; Andrew Jeffery ; Brendan Higgins
; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-developer@list
On 25/05/2021 17:30, Ryan Chen wrote:
-Original Message-
From: Quan Nguyen
Sent: Monday, May 24, 2021 6:49 PM
To: Ryan Chen ; Corey Minyard
; Rob Herring ; Joel Stanley
; Andrew Jeffery ; Brendan Higgins
; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-developer@lists.s
On 24/05/2021 17:36, Ryan Chen wrote:
-Original Message-
From: Quan Nguyen
Sent: Monday, May 24, 2021 6:20 PM
To: Ryan Chen ; Corey Minyard
; Rob Herring ; Joel Stanley
; Andrew Jeffery ; Brendan Higgins
; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-developer@lists.s
On 24/05/2021 17:06, Ryan Chen wrote:
-Original Message-
From: openbmc
On Behalf
Of Quan Nguyen
Sent: Wednesday, May 19, 2021 3:50 PM
To: Corey Minyard ; Rob Herring ;
Joel Stanley ; Andrew Jeffery ; Brendan
Higgins ; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-devel
On 19/05/2021 22:29, Rob Herring wrote:
On Wed, 19 May 2021 14:49:34 +0700, Quan Nguyen wrote:
Add device tree binding document for the Aspeed SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v3:
+ Switched to use DT schema format [Rob]
.../bindings/ipmi/aspeed-ssif-bmc.yaml| 33 +
On 20/05/2021 08:19, Guenter Roeck wrote:
On 5/19/21 4:43 PM, Joel Stanley wrote:
On Wed, 19 May 2021 at 07:50, Quan Nguyen
wrote:
With Tx done w/wo ACK are ack'ed early at beginning of irq handler,
Is w/wo a typo? If not, please write the full words ("with and without")
it is observed th
On 20/05/2021 18:28, Ryan Chen wrote:
-Original Message-
From: Joel Stanley
Sent: Thursday, May 20, 2021 7:29 AM
To: Quan Nguyen ; Ryan Chen
Cc: Corey Minyard ; Rob Herring ;
Andrew Jeffery ; Brendan Higgins
; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-developer@li
On 19/05/2021 19:34, Corey Minyard wrote:
On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote:
This series add support for the Aspeed specific SSIF BMC driver which
is to perform in-band IPMI communication with the host in management
(BMC) side.
v3:
+ Switched binding doc to use DT s
On 19/05/2021 19:30, Corey Minyard wrote:
On Wed, May 19, 2021 at 02:49:29PM +0700, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Signed-off-by: Quan Nguyen
---
v3:
+ Removed r
On 20/05/2021 18:06, Ryan Chen wrote:
-Original Message-
From: openbmc
On Behalf
Of Quan Nguyen
Sent: Wednesday, May 19, 2021 3:50 PM
To: Corey Minyard ; Rob Herring ;
Joel Stanley ; Andrew Jeffery ; Brendan
Higgins ; Benjamin Herrenschmidt
; Wolfram Sang ; Philipp Zabel
; openipmi-devel
On 20/05/2021 06:43, Joel Stanley wrote:
On Wed, 19 May 2021 at 07:50, Quan Nguyen wrote:
With Tx done w/wo ACK are ack'ed early at beginning of irq handler,
Is w/wo a typo? If not, please write the full words ("with and without")
It is "with and without", will fix in next version
it is
On 20/05/2021 06:28, Joel Stanley wrote:
Ryan, can you please review this change?
On Wed, 19 May 2021 at 07:50, Quan Nguyen wrote:
It is observed that in normal condition, when the last byte sent by
slave, the Tx Done with NAK irq will raise.
But it is also observed that sometimes master issu
It is observed that in normal condition, when the last byte sent by
slave, the Tx Done with NAK irq will raise.
But it is also observed that sometimes master issues next transaction
too quick while the slave irq handler is not yet invoked and Tx Done
with NAK irq of last byte of previous READ PROCE
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
Signed-off-by: Quan Nguyen
---
v3:
+ Removed redundant license info [Joel]
+ Switched to use traditional if-else [Joel]
+ Removed unused ssif_bmc_ioc
Expose the PEC calculation i2c_smbus_pec() for generic use.
Signed-off-by: Quan Nguyen
---
drivers/i2c/i2c-core-smbus.c | 12 ++--
include/linux/i2c.h | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbu
Slave i2c device on AST2500 received a lot of slave irq while it is
busy processing the response. To handle this case, adds and exports
aspeed_set_slave_busy() for controller to temporary stop slave irq
while slave is handling the response, and re-enable them again when
the response is ready.
Sign
Add device tree binding document for the Aspeed SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
v3:
+ Switched to use DT schema format [Rob]
.../bindings/ipmi/aspeed-ssif-bmc.yaml| 33 +++
1 file changed, 33 insertions(+)
create mode 100644 Documentation/devicetree/bi
This commits adds SSIF BMC driver specifically for Aspeed AST2500 which
commonly used as Board Management Controllers.
Signed-off-by: Quan Nguyen
---
v3:
+ Splited into separate commit [Corey, Joel]
+ Invoked aspeed-specific aspeed_set_slave_busy() when busy
to address deadlock from Graeme an
This series add support for the Aspeed specific SSIF BMC driver which
is to perform in-band IPMI communication with the host in management
(BMC) side.
v3:
+ Switched binding doc to use DT schema format [Rob]
+ Splited into generic ssif_bmc and aspeed-specific [Corey, Joel]
+ Removed redundan
With Tx done w/wo ACK are ack'ed early at beginning of irq handler,
it is observed that, usually, the Tx done with Ack irq raises in the
READ REQUESTED state. This is unexpected and complaint as below appear:
"Unexpected Ack on read request"
Assumed that Tx done should only be ack'ed once it was t
Hi Corey,
Thank you for reviewing
I'll put my respond inline below.
-Quan
On 02/04/2021 21:21, Corey Minyard wrote:
On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote:
This series add support for the Aspeed specific SSIF BMC driver which
is to perform in-band IPMI communication with
On 02/04/2021 19:01, Philipp Zabel wrote:
Hi Quan,
On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
This commits adds support specifically f
On 31/03/2021 14:21, Joel Stanley wrote:
On Mon, 29 Mar 2021 at 12:18, Quan Nguyen wrote:
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
This commits adds support specifically for Aspeed AST2500 whi
On 02/04/2021 00:09, Rob Herring wrote:
On Tue, Mar 30, 2021 at 09:10:29PM +0700, Quan Nguyen wrote:
Add device tree binding document for the Aspeed SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
.../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++
1 file changed, 18 ins
This series add support for the Aspeed specific SSIF BMC driver which
is to perform in-band IPMI communication with the host in management
(BMC) side.
v2:
+ Fixed compiling error with COMPILE_TEST for arc
Quan Nguyen (3):
i2c: i2c-core-smbus: Expose PEC calculate function for generic use
dr
Add device tree binding document for the Aspeed SSIF BMC driver.
Signed-off-by: Quan Nguyen
---
.../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt
diff --git a/Do
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
This commits adds support specifically for Aspeed AST2500 which commonly
used as Board Management Controllers.
Signed-off-by: Quan Nguyen
---
drivers/cha
Expose the PEC calculation i2c_smbus_pec() for generic use.
Signed-off-by: Quan Nguyen
---
drivers/i2c/i2c-core-smbus.c | 12 ++--
include/linux/i2c.h | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbu
This series add support for the Aspeed specific SSIF BMC driver which
is to perform in-band IPMI communication with the host in management
(BMC) side.
Quan Nguyen (3):
i2c: i2c-core-smbus: Expose PEC calculate function for generic use
drivers: char: ipmi: Add Aspeed SSIF BMC driver
bindings:
Expose the PEC calculation i2c_smbus_pec() for generic use.
Signed-off-by: Quan Nguyen
---
drivers/i2c/i2c-core-smbus.c | 12 ++--
include/linux/i2c.h | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbu
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
This commits adds support specifically for Aspeed AST2500 which commonly
used as Board Management Controllers.
Signed-off-by: Quan Nguyen
---
drivers/cha
The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
in-band IPMI communication with their host in management (BMC) side.
This commits adds support specifically for Aspeed AST2500 which commonly
used as Board Management Controllers.
Signed-off-by: Quan Nguyen
---
drivers/cha
1 - 100 of 105 matches
Mail list logo
