hg: openjfx/8/graphics/rt: RT-28335 ArrayIndexOutOfBounds in canvas polys ReviewedBy: Jim, Kevin

Changeset: 66325e8963ef Author:"Joseph Andresen" Date: 2013-10-04 16:42 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/66325e8963ef RT-28335 ArrayIndexOutOfBounds in canvas polys ReviewedBy: Jim,Kevin ! modules/graphics/src/main/java/javafx/scene/canvas/GraphicsCon

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

Sounds good. Depends on whether it is usable from SceneBuilder and FXML, and the following: - We must *not* expose a ReadOnly property for these properties (and I don't think we do) No, we don't. - The FXML changes must be backwards compatible (they should be but we need to verify)

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

Depends on whether it is usable from SceneBuilder and FXML, and the following: - We must *not* expose a ReadOnly property for these properties (and I don't think we do) - The FXML changes must be backwards compatible (they should be but we need to verify) - The SceneBuilder can do someth

hg: openjfx/8/graphics/rt: RT-30750 Jitter on Resize Reviewed by: KevinR, SteveN, Artem, DaveH

Changeset: 137e59786fc1 Author:"Joseph Andresen" Date: 2013-10-04 12:21 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/137e59786fc1 RT-30750 Jitter on Resize Reviewed by: KevinR, SteveN, Artem, DaveH ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/Embedd

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

Certainly for divisions there is no reason to keep them immutable. For fixedEyeAtCameraZero, I don't think the reasons for keeping it immutable are compelling. Making either change in FX 8 is a different matter, though, given how late we are. The implementation assumes immutability and we woul

Re: Enabling Glass thread checks

+1 for FX Thread. -Thor On Oct 4, 2013, at 12:53 PM, Richard Bair wrote: > I always disliked FX Application thread, which is why I don't use it. The > FXAT or FAT are acronyms we ought to avoid. EDT was great for Swing because > it was super short, but we don't want to reuse EDT because that wou

Re: Enabling Glass thread checks

I always disliked FX Application thread, which is why I don't use it. The FXAT or FAT are acronyms we ought to avoid. EDT was great for Swing because it was super short, but we don't want to reuse EDT because that would be confusing. Personally I tend to use FX Thread because it is clear that th

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

I would turn that around and say that unless there is a compelling reason for something to be immutable, it should be mutable. Mutability is important for tools as well as for FXML as well as for developers. Immutable state is awesome for thread-safety or any type of concurrency. But these type

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

Yes, that pretty much captures the thinking behind it. My thought is that there is no real reason that subdivisions need to be immutable, although I wouldn't want to change it at this late date for FX 8 unless it is needed for FXML support. The fixedEyeAtCameraZero mode is not something I thi

Re: Enabling Glass thread checks

We are BAD. It should really be "FX Application Thread" but the "GUI", "event" nature of the thread is critical to what it is. That's why the terms keep getting added. Steve On 04/10/2013 3:36 PM, Richard Bair wrote: Ya, "event thread", "fx thread", "ui thread", "app thread", "FX Application

Re: Enabling Glass thread checks

Ya, "event thread", "fx thread", "ui thread", "app thread", "FX Application thread" --- they're all the same thing. It would be better if we settled on one name. Richard On Oct 4, 2013, at 12:00 PM, steve.x.northo...@oracle.com wrote: > It's the JavaFX Application Thread. We tend to use the t

Re: Enabling Glass thread checks

It's the JavaFX Application Thread. We tend to use the term "event thread" and "UI thread" to indicate that the thread is a distinguished UI thread that processes operating system events by running an event loop. Steve On 04/10/2013 2:45 PM, John Smith wrote: IllegalStateException("This oper

RE: Enabling Glass thread checks

> IllegalStateException("This operation is permitted on the event thread only") What is the event thread? Current warnings about thread rule violations appear to be something like below (from: http://stackoverflow.com/questions/12182592/javafx-2-x-swing-not-on-fx-application-thread): Except

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

We did discuss making divisions in the predefined 3D shapes mutable in earlier meeting. However we decided against it since it is a heavy weight operation as the supporting mesh will has to be regenerated. I believe the constructor with the divisions argument will not have much use in the futur

hg: openjfx/8/graphics/rt: RT-32841: Paper.Units does not need to be public

Changeset: c71c80693664 Author:prr Date: 2013-10-04 11:05 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/c71c80693664 RT-32841: Paper.Units does not need to be public Reviewed by: kcr, jgodinez ! modules/graphics/src/main/java/com/sun/javafx/print/PrintHelper.java

hg: openjfx/8/graphics/rt: Ensemble8: Add TreeTableView sample

Changeset: 53288988ddf1 Author:dmasada Date: 2013-10-04 10:37 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/53288988ddf1 Ensemble8: Add TreeTableView sample ! apps/samples/Ensemble8/src/generated/java/ensemble/generated/Samples.java + apps/samples/Ensemble8/src/s

hg: openjfx/8/graphics/rt: RT-33357: CSS Parser dies on image-pattern and repeating-image-pattern with -ea flag

Changeset: 6a633413eba4 Author:rbair Date: 2013-10-04 09:57 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/6a633413eba4 RT-33357: CSS Parser dies on image-pattern and repeating-image-pattern with -ea flag Reviewed-by: dgrieve ! modules/graphics/src/main/java/com/s

Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

Why are they not? It isn't immediately obvious to me why these are not mutable? I was reading https://javafx-jira.kenai.com/browse/RT-29577 and this struck me as odd. Richard

Re: bugfix mode

This page http://openjdk.java.net/projects/jdk8/milestones has the actual dates for JDK 8. The only place where we have a waiver to deviate for JavaFX is that our ZBB and Rampdown phase 2 are both scheduled for December 4. Richard On Oct 4, 2013, at 7:24 AM, Tom Eugelink wrote: > > Ok, clear

Re: Cannot compile following the OpenJFX instructions at https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

There is a known bug introduced in JDK 8 b108. See: http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-October/010592.html It is fixed in b110. -- Kevin Oscar Vargas Torres wrote: This is the error I keep getting: http://pastie.org/8377161 I am using Ubuntu L

Re: bugfix mode

Ok, clear. Then it is time I start looking at the issues that are reported on MigLayout and the CSS errors I"m getting. Tom On 2013-10-04 16:03, Richard Bair wrote: We are presently in full-on bug fixing mode. After October 24 only major, critical, and blocker bugs are being looked at, and

Re: bugfix mode

We are presently in full-on bug fixing mode. After October 24 only major, critical, and blocker bugs are being looked at, and December 4 is the last day, with only show stopper bugs fixable past that date. So if you have bugs, by all means now is the time to file and fix. It might already be to

hg: openjfx/8/graphics/rt: RT-33145: In SkinBase computeMinHeight and computeMinWidth, initialize minY/minX to max value and maxY/maxX to min value.

Changeset: 78ee0e010484 Author:David Grieve Date: 2013-10-04 09:44 -0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/78ee0e010484 RT-33145: In SkinBase computeMinHeight and computeMinWidth, initialize minY/minX to max value and maxY/maxX to min value. Reviewed by: jgi

hg: openjfx/8/graphics/rt: ECLIPSE: work around Eclipse jdk8 compiler problem

Changeset: 0917b41c31ac Author:snorthov Date: 2013-10-04 09:29 -0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/0917b41c31ac ECLIPSE: work around Eclipse jdk8 compiler problem ! modules/graphics/src/main/java/javafx/concurrent/Task.java

hg: openjfx/8/graphics/rt: RT-30898 - Regression : Tab travsersal issue with ScrollPane, reviewed by David

Changeset: 080c7905568c Author:mickf Date: 2013-10-04 13:53 +0100 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/080c7905568c RT-30898 - Regression : Tab travsersal issue with ScrollPane, reviewed by David ! modules/controls/src/main/java/com/sun/javafx/scene/control/be

Re: Lambdafication (was Re: Default methods in JFX-8)

Oh and btw - would you go for lambda with or without additional type info before parameter name? -Sven On Fri, Oct 4, 2013 at 2:05 PM, Sven Reimers wrote: > Ok. Here you go... > > I just did an inspection run for the controls module and my IDE came up > with (drum roll) 888 possible lambda c

hg: openjfx/8/graphics/rt: RT-31943: Gtk: jni_GetStringUTFChars segfault while running in jruby/jrubyfx

Changeset: 60ad6d456028 Author:Anthony Petrov Date: 2013-10-04 15:53 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/60ad6d456028 RT-31943: Gtk: jni_GetStringUTFChars segfault while running in jruby/jrubyfx Reviewed-by: Alexander Zvegintsev ! modules/graphics/src/

Re: Lambdafication (was Re: Default methods in JFX-8)

Ok. Here you go... I just did an inspection run for the controls module and my IDE came up with (drum roll) 888 possible lambda conversions.. Looking through them I discovered that usage of <> (aka diamond syntax) is not used (or at least not used a lot) in at least the controls modules. My ID

Re: Cannot compile following the OpenJFX instructions at https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

See this: http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-October/010592.html -- best regards, Anthony On 10/04/2013 02:59 PM, Oscar Vargas Torres wrote: This is the error I keep getting: http://pastie.org/8377161 I am using Ubuntu Linux 13.04 64 bits. I hav

Cannot compile following the OpenJFX instructions at https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

This is the error I keep getting: http://pastie.org/8377161 I am using Ubuntu Linux 13.04 64 bits. I have installed jdk8 b109 in my machine. I have tried for several hours now. I need some guidance!! What I understand is that I need antlr but the gradle build is not abl

hg: openjfx/8/graphics/rt: RT-28121 - remove related test files

Changeset: 7a8c5feb8c49 Author:Martin Sladecek Date: 2013-10-04 10:53 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/7a8c5feb8c49 RT-28121 - remove related test files - modules/fxml/src/test/java/javafx/fxml/RT_23413Test.java - modules/fxml/src/test/resources/java

hg: openjfx/8/graphics/rt: RT-26891: Re-enable glass thread checks by default once depenedent issues are fixed

Changeset: b3c81e6a32d0 Author:Petr Pchelko Date: 2013-10-04 12:41 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/b3c81e6a32d0 RT-26891: Re-enable glass thread checks by default once depenedent issues are fixed ! modules/graphics/src/main/java/com/sun/glass/ui/Ap

Enabling Glass thread checks

Hello, OpenJFX. FX is a single threaded UI toolkit. Glass (the underlying native window toolkit portability layer for FX) is being changed to ensure it is accessed from the UI thread. You can follow progress in https://javafx-jira.kenai.com/browse/RT-26891 We are reenabling the Glass thread che