hg: openjfx/8u-dev/rt: RT-34951 Provide property to exit when when the screen is first rendered

2014-01-07 Thread hang . vo
Changeset: 6958ed0ddda5 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2014-01-07 10:52 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6958ed0ddda5 RT-34951 Provide property to exit when when the screen is first rendered Reviewed-by: kcr !

Review request: RT-35015,[ScrollPane] ScrollPane can leave trails of horizontal lines.

2014-01-07 Thread Martin Sladecek
Jim, Jonathan, please review: http://cr.openjdk.java.net/~msladecek/rt-35015/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-35015 Thanks, -Martin

Future of Skins

2014-01-07 Thread John Hendrikx
Hi List, I'm wondering if Skins in their current form are finished or that more changes are still likely to come. The Skin interface is public, and SkinBase is as well. Unfortunately, it seems that even though SkinBase is treated differently by JavaFX from regular Skins, the opportunity was

hg: openjfx/8/graphics/rt: Sync up SceneBuilder changes

2014-01-07 Thread hang . vo
Changeset: 423cf238579d Author:Yves Joan yves.j...@oracle.com Date: 2014-01-07 12:06 +0100 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/423cf238579d Sync up SceneBuilder changes !

Re: Future of Skins

2014-01-07 Thread Tomas Mikula
Interesting ideas. I'm wondering, do you switch skins often enough that you are worried about performance (and thus care about reusability of skins)? Because I don't see how reusability of skins saves you lines of code - whether the code is in the constructor or in the initialize() method, it is

Re: Future of Skins

2014-01-07 Thread John Hendrikx
On 7/01/2014 14:50, Tomas Mikula wrote: Interesting ideas. I'm wondering, do you switch skins often enough that you are worried about performance (and thus care about reusability of skins)? Because I don't see how reusability of skins saves you lines of code - whether the code is in the

Re: JavaFX on headless Jenkins

2014-01-07 Thread David Hill
On 1/6/14, Jan 6, 3:13 PM, Tom Eugelink wrote: Yes please, I've got Jenkins setup so it starts a vncserver and it runs on linux, so I'm interesting in the option you mention (as long as it doesn't require too many hoops I need to jump through). This will take me a day of so. It would appear

Re: 8u API Review request: RT-153 : [Stage] Option to keep Stages always on top

2014-01-07 Thread Scott Palmer
A couple quick questions: Why is the property Read-Only? Can the setter only be called once? Does it have to be set before the Stage is shown? Should it be an initAlwaysOnTop(boolean value)? Cheers, Scott On Tue, Jan 7, 2014 at 8:27 AM, Martin Sladecek martin.slade...@oracle.comwrote:

Re: Future of Skins

2014-01-07 Thread Richard Bair
Could you write a single skin that delegates to one or more reusable skins? On Jan 7, 2014, at 7:26 AM, John Hendrikx hj...@xs4all.nl wrote: On 7/01/2014 14:50, Tomas Mikula wrote: Interesting ideas. I'm wondering, do you switch skins often enough that you are worried about performance (and

Re: 8u API Review request: RT-153 : [Stage] Option to keep Stages always on top

2014-01-07 Thread Kevin Rushforth
As a reminder, review comments should be made in JIRA. Can you add it there? -- Kevin Scott Palmer wrote: A couple quick questions: Why is the property Read-Only? Can the setter only be called once? Does it have to be set before the Stage is shown? Should it be an initAlwaysOnTop(boolean

Re: Future of Skins

2014-01-07 Thread Tomas Mikula
On Tue, Jan 7, 2014 at 4:26 PM, John Hendrikx hj...@xs4all.nl wrote: On 7/01/2014 14:50, Tomas Mikula wrote: Interesting ideas. I'm wondering, do you switch skins often enough that you are worried about performance (and thus care about reusability of skins)? Because I don't see how

Re: JavaFX on headless Jenkins

2014-01-07 Thread Tom Eugelink
Nope, Xvfb has the same problem... Xvfb starting$ /usr/bin/Xvfb :2 -screen 0 1024x768x24 -fbdir /var/lib/jenkins/2014-01-07_19-17-242962656246439721545xvfb ... :*test* Executing task ':test' (up-to-date check took 0.051 secs) due to: No history is available. Starting process 'Gradle Worker

Re: JavaFX on headless Jenkins

2014-01-07 Thread Tom Eugelink
Jenkins does that for me. On 2014-1-7 21:13, Matthieu BROUILLARD wrote: For JFXtras build on travis.org http://travis.org, I just followed some docs pages to setup xvfb, sorry I am not a linux/unix expert and don't know how to help more. /[Stupid linux user mode activated]/ If you do not

Re: Regression: JavaFX 8 doesn't call listeners in Skin implementations

2014-01-07 Thread Florian Brunner
Hi Steve, Ok, I've reported the issue here: https://javafx-jira.kenai.com/browse/RT-35208 I even have a small sample application with a small custom control showing the issue, but I don't have an option to add an attachement to the issue in Jira... -Florian Am Freitag, 3. Januar 2014,

8u20 review request: RT-35209 - errors in the diagnostics in glContext.createProgram

2014-01-07 Thread Jim Graham
Chien, Felipe, I've made some changes to the diagnostic code in glContext.c to help track down why WebLauncher is currently failing on Mac. I need a review and perhaps some help making sure that the changes compile on other platforms... Jira: https://javafx-jira.kenai.com/browse/RT-35209

CSS metadata boilerplate

2014-01-07 Thread John Hendrikx
Hi List, I'm in the process of adding CSS metadata to a new control, and I noticed there is a lot of boilerplate. In order to reduce this, I've created some custom classes StyleableProperty classes (SimpleStyleableXXXProperty), which reduces the boilerplate significantly without sacrificing

Re: CSS metadata boilerplate

2014-01-07 Thread Tom Eugelink
Yes, I had similar considerations. I was thinking about providing exactly such extended Property classes in JFXtras to remove as much of the boilerplate. Tom On 2014-1-8 3:34, John Hendrikx wrote: Hi List, I'm in the process of adding CSS metadata to a new control, and I noticed there is