Re: Is Bundler now working for command line parameters?

2014-07-02 Thread Tony Anecito
Hi Danno, Mac then Windows app stores. Regards, -Tony On Wednesday, July 2, 2014 2:41 PM, Danno Ferrin wrote: This won’t be fixed until 8u40. What platforms are you targeting?  Mac, Linux, Windows? On Jul 2, 2014, at 2:35 PM, Tony Anecito wrote: > Hi Danno, > > Is b20 have the fix

Re: Review Request: RT-37788

2014-07-02 Thread Petr Pchelko
Hello, Danno. I’ve noticed that you are leaking userDefaults and expandedOptions objects. Adding autorelease to them would save you some memory. With best regards. Petr. > On Jul 3, 2014, at 1:43 AM, Danno Ferrin wrote: > > Yes, this has to be fixed in native code. 8u40 it is then. > > I ca

[8u40] review request: RT-37790: ObservableList.java is missing from javafx-src.zip

2014-07-02 Thread Kevin Rushforth
David, Please review this simple build fix to restore some missing source files in javafx-src.zip in the JDK (it doesn't affect the runtime). The patch is in the JIRA. https://javafx-jira.kenai.com/browse/RT-37790 -- Kevin

hg: openjfx/8u-dev/rt: Fix RT-37300: Canvas needs a fast rectangular clip capability

2014-07-02 Thread james . graham
Changeset: ddf059995fc0 Author:flar Date: 2014-07-02 16:21 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ddf059995fc0 Fix RT-37300: Canvas needs a fast rectangular clip capability Reviewed by: Felipe ! modules/graphics/src/main/java/com/sun/javafx/geom/Path2D.java !

Code Review Request For RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device

2014-07-02 Thread Chien Yang
Hi Kevin, Please review this fix, details is in the JIRA: https://javafx-jira.kenai.com/browse/RT-37789 - Chien

Re: Review Request: RT-37788

2014-07-02 Thread Danno Ferrin
Yes, this has to be fixed in native code. 8u40 it is then. I can make it cause a crash, but that starts with shooting myself in the foot, and not much can be done to fix it (by passing in bogus VM arguments). On Jul 2, 2014, at 3:40 PM, Stephen F Northover wrote: > Personally, I wouldn't ch

Re: Review Request: RT-37788

2014-07-02 Thread Chris Bensen
The review is for 8u40, but Danno would like to get it into 8u20 last time we chatted which is why he was asking I believe. Chris On Jul 2, 2014, at 2:40 PM, Stephen F Northover wrote: > Personally, I wouldn't change any native code at this point unless it was > fixing a crash. The review

Re: Review Request: RT-37788

2014-07-02 Thread Stephen F Northover
Personally, I wouldn't change any native code at this point unless it was fixing a crash. The review is for 8u40, correct? Steve On 2014-07-02, 5:38 PM, Chris Bensen wrote: I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C seems as good as any Obj-C. My only complaint

Re: Review Request: RT-37788

2014-07-02 Thread Chris Bensen
I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C seems as good as any Obj-C. My only complaint at the moment is the following: 358 if ([pathParts count] > 2) { 359 // for 3 or more steps, the domain is first.second.third and the keys are "/first/second/thir

Re: Review Request: RT-37788

2014-07-02 Thread Stephen F Northover
I'm glad your not an objective C. I suggest getting Felipe to look at this code too should we decide to go ahead with it. Steve On 2014-07-02, 5:15 PM, Danno Ferrin wrote: Chris, Kevin, Steve, Please review this fix for RT-37788. Since I am not an objective C any comments are welcome. Als

Review Request: RT-37788

2014-07-02 Thread Danno Ferrin
Chris, Kevin, Steve, Please review this fix for RT-37788. Since I am not an objective C any comments are welcome. Also, please consider if this is too much for an 8u20 fix (the diff is against the current 8u40 codebase). Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/ JIRA: ht

Re: Is Bundler now working for command line parameters?

2014-07-02 Thread Danno Ferrin
This won’t be fixed until 8u40. What platforms are you targeting? Mac, Linux, Windows? On Jul 2, 2014, at 2:35 PM, Tony Anecito wrote: > Hi Danno, > > Is b20 have the fix for command line parameters that should get passed to the > "args" for the static main method? And if so how do I do tha

Is Bundler now working for command line parameters?

2014-07-02 Thread Tony Anecito
Hi Danno, Is b20 have the fix for command line parameters that should get passed to the "args" for the static main method? And if so how do I do that via the deployfx ant task? Thanks, -Tony

[8u40] Review request: RT-37602: [Spec] Cursor.setVisible behavior is unspecified

2014-07-02 Thread Anthony Petrov
Hi Daniel, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37602 -- best regards, Anthony

hg: openjfx/8u-dev/rt: 3 new changesets

2014-07-02 Thread kevin . rushforth
Changeset: dab88dec3067 Author:Felipe Heidrich Date: 2014-06-26 05:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dab88dec3067 RT-37704: [Regression, Linux] ArrayIndexOutOfBoundsException when trying to open HTMLEditor font name combobox. ! modules/graphics/src/ma

OpenJFX: API Review Process

2014-07-02 Thread Stephen F Northover
Hi all, We've been working hard to document OpenJFX development over the past few months and strangely, the API Review Process was not described anywhere. To fix this, I have updated the wiki: https://wiki.openjdk.java.net/display/OpenJFX/API+Review API is forever so it is very important th

hg: openjfx/8u20/rt: Added tag 8u20-b21 for changeset dab88dec3067

2014-07-02 Thread hang . vo
Changeset: 84eeb1f71882 Author:hudson Date: 2014-07-02 07:51 -0700 URL: http://hg.openjdk.java.net/openjfx/8u20/rt/rev/84eeb1f71882 Added tag 8u20-b21 for changeset dab88dec3067 ! .hgtags

hg: openjfx/8u-dev/rt: RT-37747 Additional app-thread checks should be added (back) after RT-17716

2014-07-02 Thread martin . sladecek
Changeset: 8cc538c3a7f8 Author:Martin Sladecek Date: 2014-07-02 13:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8cc538c3a7f8 RT-37747 Additional app-thread checks should be added (back) after RT-17716 Reviewed by: kcr, anthony ! modules/graphics/src/main/java/jav

hg: openjfx/8u-dev/rt: RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed

2014-07-02 Thread martin . sladecek
Changeset: c21b1705eb10 Author:Martin Sladecek Date: 2014-07-02 13:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c21b1705eb10 RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed Reviewed by: dgrieve ! modules/controls/

Re: Formatted text field API (RT-14000, RT-30881)

2014-07-02 Thread Martin Sladecek
There's a new proposal here: https://javafx-jira.kenai.com/browse/RT-14000 I merged FormattedTextField and content filter to a single Formatter class, that's now part of the TextInputControl. -Martin On 06/11/2014 10:50 AM, Martin Sladecek wrote: Hello, I would like to start some discussion