Re: [8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken

2014-08-26 Thread Anton V. Tarasov
Hi Steve, Sure, thanks for the reminder. Anton. On 27.08.2014 1:11, Stephen F Northover wrote: Hi Anton T, The policy for OpenJFX is that code reviews happen in the associated JIRA: https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews Thanks for reviewing this code, Steve On 2014-08

hg: openjfx/8u-dev/rt: RT-38442: [packager] Java FX Packaging options can cause Windows Packager to fail.

2014-08-26 Thread danno . ferrin
Changeset: e4cfda6bac5a Author:shemnon Date: 2014-08-26 14:28 -0600 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e4cfda6bac5a RT-38442: [packager] Java FX Packaging options can cause Windows Packager to fail. Summary: regexp needs double backslash, so that means quadruple

8u40 API review: RT-23822 - need API for LCD font smoothing in Canvas

2014-08-26 Thread Jim Graham
webrev: http://cr.openjdk.java.net/~flar/RT-23822/webrev.01/ Jira: https://javafx-jira.kenai.com/browse/RT-23822 Includes API unit tests and a graphical test is attached to the Jira issue... ...jim

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Jim Graham
We simply haven't implemented this yet: https://javafx-jira.kenai.com/browse/RT-28629 ...jim On 8/26/14 3:29 PM, Felipe Heidrich wrote: I'm curious. Why setSmooth doesn't work? I tried setSmooth but it doesn’t work. See the doc: "Indicates whether to use a better

hg: openjfx/8u-dev/rt: RT-38445: [Accessibility, Windows] Fix text traversal action

2014-08-26 Thread felipe . heidrich
Changeset: 4be6763a301a Author:Felipe Heidrich Date: 2014-08-26 16:28 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4be6763a301a RT-38445: [Accessibility, Windows] Fix text traversal action Need to make sure the range is set everytime get_DocumentRange() is called, f

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Felipe Heidrich
> > I'm curious. Why setSmooth doesn't work? > I tried setSmooth but it doesn’t work. See the doc: "Indicates whether to use a better quality filtering algorithm or a faster”. I expected this be a set for the interpolation algorithm (bilinear, bicubic, nearest neighbor, etc). My case I didn’t

hg: openjfx/8u-dev/rt: [Accessibility] cosmetic changes

2014-08-26 Thread felipe . heidrich
Changeset: e1d0a9e30bec Author:Felipe Heidrich Date: 2014-08-26 14:49 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e1d0a9e30bec [Accessibility] cosmetic changes ! modules/graphics/src/main/java/com/sun/glass/ui/win/WinAccessible.java

Re: [8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken

2014-08-26 Thread Stephen F Northover
Hi Anton T, The policy for OpenJFX is that code reviews happen in the associated JIRA: https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews Thanks for reviewing this code, Steve On 2014-08-26, 3:30 PM, Anton V. Tarasov wrote: Hi Anton, Does it make sense to add a boolean param to rend

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Edu García
I'm curious. Why setSmooth doesn't work? Also, do I really need to create an image in memory just to render something showing the pixels? On Aug 27, 2014 3:32 AM, "Nico Krebs | www.mensch-und-maschine.de" < nicokrebs@googlemail.com> wrote: > Thanx for that quick response! > > It is the right

Re: CSS: Use "none" or "null"?

2014-08-26 Thread Tomas Mikula
Thanks for the quick answer. Tomas On Tue, Aug 26, 2014 at 10:24 PM, David Grieve wrote: > Either one. > > > On 8/26/14, 4:21 PM, Tomas Mikula wrote: >> >> Just a quick question: Which one is correct, >> >> -fx-fill: none; >> >> or >> >> -fx-fill: null; >> >> ? >> >> Thanks, >> Tomas >

hg: openjfx/8u-dev/rt: RT-38187: [a11y] Intermittent NPE running HelloSanity or SceneBuilder with Narrator

2014-08-26 Thread felipe . heidrich
Changeset: 96b05e9b6bd4 Author:Felipe Heidrich Date: 2014-08-26 13:56 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/96b05e9b6bd4 RT-38187: [a11y] Intermittent NPE running HelloSanity or SceneBuilder with Narrator Fix missing isDisposed() checks in GetFocus() and get_

hg: openjfx/8u-dev/rt: RT-38187: [a11y] Intermittent NPE running HelloSanity or SceneBuilder with Narrator

2014-08-26 Thread felipe . heidrich
Changeset: e68dd7128fdd Author:Felipe Heidrich Date: 2014-08-26 13:49 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e68dd7128fdd RT-38187: [a11y] Intermittent NPE running HelloSanity or SceneBuilder with Narrator Remove possible NPE in GetSelection() ! modules/graph

Re: CSS: Use "none" or "null"?

2014-08-26 Thread David Grieve
Either one. On 8/26/14, 4:21 PM, Tomas Mikula wrote: Just a quick question: Which one is correct, -fx-fill: none; or -fx-fill: null; ? Thanks, Tomas

[8u40] Post-commit review: (RT-38391) [CSS] Add support for specifying durations

2014-08-26 Thread David Grieve
Added handling of 's' and 'ms' time units to the CSS parser. Added "public static StyleConverter getDurationConverter()" to javafx.css.StyleConverter Added corresponding createStyleableDurationProperty methods to javafx.css.StyleablePropertyFactory. https://javafx-jira.kenai.com/browse/RT-3839

CSS: Use "none" or "null"?

2014-08-26 Thread Tomas Mikula
Just a quick question: Which one is correct, -fx-fill: none; or -fx-fill: null; ? Thanks, Tomas

hg: openjfx/8u-dev/rt: RT-37792: [Accessibility] Combobox list items are counted incorrectly

2014-08-26 Thread felipe . heidrich
Changeset: 6feed77a2bfa Author:Felipe Heidrich Date: 2014-08-26 12:58 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6feed77a2bfa RT-37792: [Accessibility] Combobox list items are counted incorrectly ! modules/graphics/src/main/java/com/sun/glass/ui/win/WinAccessible.

hg: openjfx/8u-dev/rt: RT-38391: [CSS] Add support for specifying durations

2014-08-26 Thread david . grieve
Changeset: 6efbcb758363 Author:David Grieve Date: 2014-08-26 15:54 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6efbcb758363 RT-38391: [CSS] Add support for specifying durations ! apps/toys/Hello/src/main/java/hello/HelloCSS.java ! modules/graphics/src/main/docs/java

Re: [8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken

2014-08-26 Thread Anton V. Tarasov
Hi Anton, Does it make sense to add a boolean param to renderLayer() which would tell it if it should dispose the layer after rendering? In order to avoid the splitting. Also, could you please clarify the following. From your comments: 72 // WCBufferedContext might be referenced f

hg: openjfx/8u-dev/rt: RT-38185: [Accessibility] Intermittent crash / relaunch on exit on Windows 7 with Narrator

2014-08-26 Thread felipe . heidrich
Changeset: 5705e881dc1f Author:Felipe Heidrich Date: 2014-08-26 11:34 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5705e881dc1f RT-38185: [Accessibility] Intermittent crash / relaunch on exit on Windows 7 with Narrator ! modules/graphics/src/main/native-glass/win/G

hg: openjfx/8u-dev/rt: 2 new changesets

2014-08-26 Thread mo . chicharro
Changeset: 8889a4892b7d Author:mchicharro Date: 2014-08-26 18:29 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8889a4892b7d [SCENEBUILDER] Fix for DTL-6830 Auto Suggest Popup has changed appearance ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilde

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Nico Krebs | www.mensch-und-maschine.de
Thanx for that quick response! It is the right direction, but doing this for one image is not enough. when having multiple images, the distances between them must be scaled, too. I will extend your example to scale all nodes and their positions, too. I try it tomorrow and post the result here. N

Re: Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Felipe Heidrich
Hi Nico, Is this what you looking for: Image image - the image to scale up int width = (int)image.getWidth(); int height = (int)image.getHeight(); int z = (int)getZoom(); // 2, 4, 8, 16 (I only tested for powers of two) IntBuffer src = IntBuffer.allocate(width

Displaying pixel-perfect images without blur when zooming

2014-08-26 Thread Nico Krebs | www.mensch-und-maschine.de
Hi there, i want to display multiple images (layers) inside a scene and want to be able to zoom without having "blurry" images as you can see in the images in the attachment (on the left you can see very big scaled pixels as i need it and on the right is the "blurry" JavaFX-Result on which i canno

hg: openjfx/8u-dev/rt: RT-37698: Platform.isSupported(MEDIA|WEB) passes when it should not on embedded

2014-08-26 Thread david . hill
Changeset: 507a38bed103 Author:ddhill Date: 2014-08-26 11:57 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/507a38bed103 RT-37698: Platform.isSupported(MEDIA|WEB) passes when it should not on embedded Reviewed-by: kselle, kcr ! modules/graphics/src/main/java/com/sun/ja

[8u] Review request: RT-37884: [WebView] Java Logger settings corrupt webview

2014-08-26 Thread anton nashatyrev
Hello, could you please review the fix: https://javafx-jira.kenai.com/browse/RT-37884 Thank you! Anton.

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6816: Item chosen from auto-suggest menu is not applied immediately

2014-08-26 Thread jerome . cambon
Changeset: 69f0c8731747 Author:Jerome Cambon Date: 2014-08-26 16:50 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/69f0c8731747 [SCENEBUILDER] Fix for DTL-6816: Item chosen from auto-suggest menu is not applied immediately ! apps/scenebuilder/SceneBuilderKit/src/com/

hg: openjfx/8u-dev/rt: Replace dialog placeholder graphics for RT-38271

2014-08-26 Thread mo . chicharro
Changeset: d820fd5710a5 Author:mchicharro Date: 2014-08-26 15:22 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d820fd5710a5 Replace dialog placeholder graphics for RT-38271 ! modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/dialog-confirm.

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6815: Auto-suggest menus are showing focus when they do not have it

2014-08-26 Thread jerome . cambon
Changeset: c278fcc754e6 Author:Jerome Cambon Date: 2014-08-26 15:26 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c278fcc754e6 [SCENEBUILDER] Fix for DTL-6815: Auto-suggest menus are showing focus when they do not have it ! apps/scenebuilder/SceneBuilderKit/src/com/

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix DTL-6770: Add Dialog component to the Library

2014-08-26 Thread yves . joan
Changeset: 0c4d4cf6cb87 Author:yjoan Date: 2014-08-26 15:09 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0c4d4cf6cb87 [SCENEBUILDER] Fix DTL-6770: Add Dialog component to the Library ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/

hg: openjfx/8u-dev/rt: RT-38165 "A bound value cannot be set" exception should print the name of the property that is causing the problem

2014-08-26 Thread martin . sladecek
Changeset: 44cac66ba3ed Author:Martin Sladecek Date: 2014-08-26 14:23 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/44cac66ba3ed RT-38165 "A bound value cannot be set" exception should print the name of the property that is causing the problem ! modules/base/src/mai

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Improved FXOMCloner class to avoid WMI_WRONG_MAP_ITERATOR warning from FindBugs.

2014-08-26 Thread eric . le . ponner
Changeset: e282fa2c4093 Author:eric.le.ponner Date: 2014-08-26 11:16 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e282fa2c4093 [SCENEBUILDER] Improved FXOMCloner class to avoid WMI_WRONG_MAP_ITERATOR warning from FindBugs. ! apps/scenebuilder/SceneBuilderKit/src/c

hg: openjfx/8u-dev/rt: RT-37329 [SplitPane] Cannot set divider position in multiple splitpanes at once on button setOnAction()

2014-08-26 Thread martin . sladecek
Changeset: 0e57456b1327 Author:Martin Sladecek Date: 2014-08-26 11:04 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0e57456b1327 RT-37329 [SplitPane] Cannot set divider position in multiple splitpanes at once on button setOnAction() Reviewed by: jgiles ! modules/co

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Ignore transient file

2014-08-26 Thread yves . joan
Changeset: 41bbfc2cdc8d Author:yjoan Date: 2014-08-26 11:08 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/41bbfc2cdc8d [SCENEBUILDER] Ignore transient file ! .hgignore

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Some classes in FXOM now use LinkedHashMap (in place of HashMap) to preserve FXML declaration order.

2014-08-26 Thread eric . le . ponner
Changeset: caa2c16ce66b Author:eric.le.ponner Date: 2014-08-26 10:25 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/caa2c16ce66b [SCENEBUILDER] Some classes in FXOM now use LinkedHashMap (in place of HashMap) to preserve FXML declaration order. This will be useful for