Re: 8u40 & 9 CSS issues

2014-10-09 Thread Tom Eugelink
I created an issues https://javafx-jira.kenai.com/browse/RT-38950 But there is no way to add an attachment? Tom On 8-10-2014 19:21, David Grieve wrote: If it worked in 8u20 but not in 8u40, then there is a regression somewhere. Please file an issue in jira and include a reproducible example

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread Tom Eugelink
Nope, that's not it. :-( In fact commenting out the getUserAgentStylesheet and just relying on the static initializer (checking it actuelly gets executed) results in the well known "The -fx-skin property has not been defined bla bla", while that value is there. The TestFX tests partially run;

Re: Review for RT-38725

2014-10-09 Thread David DeHaven
> It's verified on 10.7.5 with XCode 4.5 and 10.9.5 with XCode 6 with either > the 10.7 or 10.9 sdk. As far as I've seen, Xcode 5.1.1 and 6 behave about the same on the command line. -DrD-

Re: [8u40] Review request for RT-38868: [JFXPanel] Access denied when scrolling in WebView in Sandboxed Applet

2014-10-09 Thread Stephen F Northover
Hi Anton, Jonathan is the owner of controls and Leonid owns web. Kevin and I can review any fix and put in the code, but you'd be better getting a review from these two guys. The code changes in question are trivial so they just need to know that they are happening in their area. I guess th

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread David Grieve
Try calling StyleManager.getInstance().addUserAgentStylesheet(...) from a static initializer, like below. If that fixes your SVG arrow problem, then it is a good bet that this change is the cause of your issues. On 10/9/14, 10:23 AM, Tom Eugelink wrote: My controls in JFXtras have been overridi

Result: New OpenJFX Committer: Morris Meyer

2014-10-09 Thread Kevin Rushforth
Voting for Morris Meyer to OpenJFX Committer [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. -- Kevin [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2014-September/015817.html

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread Tom Eugelink
My controls in JFXtras have been overriding getUserAgentStylesheet from day 1 (or better JavaFX 2.0), AFAIK that is the way to do it. But I'm curious if this change is the cause of the CSS issues I'm seeing in 8U40. On 9-10-2014 15:27, David Grieve wrote: In 8u20 and before, adding a styles

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread Werner Lehmann
Thanks, David. This means I would always override getUserAgentStylesheet (for 8u20 on Control, for 8u40+ on Region). And selectors in the stylesheet should be sufficiently specific because only 8u40+ actually limits them to the declaring node. For the record, I'm not talking about controlsfx

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread David Grieve
In 8u20 and before, adding a stylesheet via Control.getUserAgentStylesheet will simply add the user-agent stylesheet to the entire scene, not just the control. This has been fixed in 8u40 where the getUserAgentStylesheet method is now public API on Region and the styles added will affect only t

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread Werner Lehmann
Turns out that the 3rd party control adds its stylesheet like this: class SomeControlSkin... static { StyleManager.getInstance().addUserAgentStylesheet(...) } In this way it is not only using private API but also the stylesheet is not associated with only such control nodes and therefor

[8u40] Review request for RT-38868: [JFXPanel] Access denied when scrolling in WebView in Sandboxed Applet

2014-10-09 Thread Anton V. Tarasov
Hi Kevin, Please, review the fix: https://javafx-jira.kenai.com/browse/RT-38868 http://cr.openjdk.java.net/~ant/RT-38868/webrev.0 Where some reflection code is replaced with direct getters. Thanks, Anton.

CSS: style leaks from unrelated stylesheet

2014-10-09 Thread Werner Lehmann
Hi, I have a strange effect with stylesheets. Somehow a style is applied although the defining stylesheet is not in the scene. Consider this scenario: Primary stage with a 3rd party control. The control's jar file contains a stylesheet with style .list-cell { -fx-pref-height: 24; } Then