[9] Review request for 8090255 - Fix doclint errors in JavaFX API docs

Kevin, guys, Please review first part of fix for javadoc issue: JIRA: https://bugs.openjdk.java.net/browse/JDK-8090255 WEBREV: http://cr.openjdk.java.net/~ekleyman/RT-8090255/ The webrev includes also Kevin's and Felipe's patches. Thanks, Elina

Re: Review request for JDK-8141385

I've updated my diff according to Jonathan's recommendations: http://cr.openjdk.java.net/~arusakov/8141385/webrev.01 25.05.2016 14:23, Andrey Rusakov пишет: Hello, Everyone. Please look at my fix for JDK-8141385 : http://cr.openjdk.java.net/~aru

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

> On May 25, 2016, at 3:38 PM, Kevin Rushforth > wrote: > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8131888 > http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ > > This adds support for the javafx.embed.swt package back into the JDK, which > will be delive

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

Mandy, Thanks for your feedback. Comments inline. Mandy Chung wrote: On May 25, 2016, at 3:38 PM, Kevin Rushforth wrote: Please review the following: https://bugs.openjdk.java.net/browse/JDK-8131888 http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ This adds support for the javafx.embed

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

Hi, I highly doubt this will work in an OSGi-Env like Eclipse (which the 99%) use case for SWT useage. The SWT jar is not on the application classpath so how should a module (named or unnamed) find the SWT classes? Tom Von meinem iPhone gesendet > Am 26.05.2016 um 02:43 schrieb Mandy Chung :

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

If you add javafx-swt.jar to the custom classpath created by the OSGI container it should work in the same way it does today when you add jfxswt.jar. Can you suggest an easy way that I can test this? -- Kevin Tom Schindl wrote: Hi, I highly doubt this will work in an OSGi-Env like Eclipse

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

Rereading the jira it take that back if javafx.swt can still be loaded as a simple jar things will work Tom Von meinem iPhone gesendet > Am 26.05.2016 um 16:51 schrieb Tom Schindl : > > Hi, > > I highly doubt this will work in an OSGi-Env like Eclipse (which the 99%) use > case for SWT useag

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. -- Kevin Tom Schindl wrote: Rereading the jira it take that back if javafx.swt can still be loaded as a simple jar things will work Tom Von mein

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

> On May 26, 2016, at 8:38 AM, Kevin Rushforth > wrote: > > Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as > an automatic jar file and as just an ordinary jar on the classpath. an automatic module needs to be on modulepath. For container-like environment, it ca

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

I'll prepare a simple osgi swt test app Tom Von meinem iPhone gesendet > Am 26.05.2016 um 17:38 schrieb Kevin Rushforth : > > Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as > an automatic jar file and as just an ordinary jar on the classpath. > > -- Kevin > >

[9] Code Review Request For 8157900: Encapsulate JavaFX impl_* implementation methods in Node (peer and dirty)

Hi Kevin, Jonathon and Vadim, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157900 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157900/webrev.00/ PS: This is a huge webrev and touches many components. I believe most component owners would want to do a quick

[9] Review request for 8157600: Failed to launch hello.HelloSanity due to libglass.so: undefined symbol

bug: https://bugs.openjdk.java.net/browse/JDK-8157600 webrev: http://cr.openjdk.java.net/~flar/JDK-8157600/webrev.00/ ...jim