Building OpenJFX for the first time

2016-06-16 Thread John C. Turnbull
I would like to set up a development environment for the OpenJFX project but have never attempted this before. I am very familiar with all 3 major Java IDEs with my preference (in order of most favourite to least favourite) is Eclipse, IntelliJ, NetBeans (so whichever one is "best" doesn't real

LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-16 Thread Alexander Nyssen
Hi, in order to be able to contribute to OpenJFX, I am currently trying to set up my development environment. After checking out the latest head from hg clone http://hg.openjdk.java.net/openjfx/9-dev/rt , compilation succeeds, but tests fail with th

[Review request] Editable ComboBox / Spinner controls need uniform 'commit on focus lost' semantics

2016-06-16 Thread Jonathan Giles
Hi all, Please review my addition of 'commitValue' / 'cancelEdit' APIs to Spinner and ComboBox. These APIs mirror the API on TextInputControl, and allows for the controls (rather than their skins) to properly commit on focus loss. Previously committing on focus loss was handled by the contro

[Review request] Handling Enter key presses on Buttons in JavaFX

2016-06-16 Thread Jonathan Giles
Hi all, Thanks for all your feedback. I think we have mostly coalesced around doing the right thing per platform. I have therefore gone ahead and posted a webrev for review as part of the following Jira issue: Jira: https://bugs.openjdk.java.net/browse/JDK-8139509 Webrev: http://cr.openjdk.ja

JDK-8159565: Yet another testbug fix

2016-06-16 Thread Andrey Rusakov
Hello all! Pleas look at my fix for JDK-8159565. It solves quite annoying automation issue. Fix is applicable for both 8 and 9 tests. webrev: http://cr.openjdk.java.net/~arusakov/8159565/webrev.00/ P.S. Could anyone commit JDK-8158784? I don't have permissions to do that.