Re: [8u, 9] Review request: 8145516: Scene content shows too large on Retina display, when a regular screen attached

2016-06-17 Thread Jim Graham
Updating the subject line to request 8u backport approval. The fix applies cleanly to 8u and fixes the bug there as well... ...jim On 6/17/16 2:09 PM, Jim Graham wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8145516 webrev: http://cr.openjdk.java.net/~flar/JDK-8

[9] Code Review Request For 8157500: Create unit tests for new public methods in GridPane

2016-06-17 Thread Chien Yang
Hi Kevin, Please review the proposed unit test: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157500 Webev: http://cr.openjdk.java.net/~ckyang/JDK-8157500/webrev.00/ Thanks, - Chien

[9] Review request: 8145516: Scene content shows too large on Retina display, when a regular screen attached

2016-06-17 Thread Jim Graham
bug: https://bugs.openjdk.java.net/browse/JDK-8145516 webrev: http://cr.openjdk.java.net/~flar/JDK-8145516/webrev.00/ Information on the fix is in the bug report comments. I need to repair my 8u-dev repos to check, but I believe this can be ported directly to an 8u release...

RE: Building OpenJFX for the first time

2016-06-17 Thread John C. Turnbull
Thanks Kevin - that looks very helpful. -Original Message- From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of Kevin Rushforth Sent: Saturday, 18 June 2016 05:53 To: openjfx-dev@openjdk.java.net Subject: Re: Building OpenJFX for the first time https://wiki.openjdk

Re: Building OpenJFX for the first time

2016-06-17 Thread Kevin Rushforth
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX Dave Hill updated it recently, so it is reasonably current. -- Kevin John C. Turnbull wrote: I would like to set up a development environment for the OpenJFX project but have never attempted this before. I am very familiar wi

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-17 Thread Kevin Rushforth
It seems like the test is not written to handle multiple Locales, so if you could file a bug, we'll fix it (I note that it could probably be in a "BeforeClass" block as one-time setup rather than setting it before each test). As for your other test failures, I presume you are using FX 9-dev? A

Re: JavaFX 9 & FXCanvas

2016-06-17 Thread dalibor topic
On 15.06.2016 07:36, Alexander Nyßen wrote: Would it require he (as well as all GEF committers that worked on the mentioned fixes) would have to sign the OCA as well? If there are multiple authors to a contribution, then they all need to have an OCA on file. If one or more contributions are d

Re: PING: JDK-8146900: [SwingNode, DND]: drag-and-drop from JTable not working, drag recognized twice

2016-06-17 Thread Kevin Rushforth
I missed seeing this when you first posted it. I will add your comments to the bug report. Alexander Z may want to chime in since the bug is assigned to him and he is the component lead for SwingNode. -- Kevin Yasumasa Suenaga wrote: PING: Have you ever read this proposal? Yasumasa On 2016

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-17 Thread Alexander Nyssen
Hi, I could resolve this by changing the setup method of LocalDateTimeStringConverterTest to the following: @Before public void setup() { // tests require that default locale is English Locale.setDefault(Locale.ENGLISH); } Maybe that should be added to make it robust. Unfortunately, I a

PING: JDK-8146900: [SwingNode, DND]: drag-and-drop from JTable not working, drag recognized twice

2016-06-17 Thread Yasumasa Suenaga
PING: Have you ever read this proposal? Yasumasa On 2016/06/08 22:05, Yasumasa Suenaga wrote: Hi all, We are developing HeapStats [1] with JavaFX 8. This tool uses SwingNode to use JGraphX [2]. JGraphX suports Drag & Drop. However, DnD in SwingNode occurs InvalidDnDOperationException. Callst

[9] Review Request: 8159614: Can't get file size with javascript

2016-06-17 Thread Ankit Srivastava
Hi Arun, Murali & Kevin, Please review the webrev. JBS: https://bugs.openjdk.java.net/browse/JDK-8159614 WebRev: http://cr.openjdk.java.net/~asrivastava/8159614/webrev.00/ Solution updated in JBS. Regards, Ankit